You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/22 17:03:01 UTC
[GitHub] [incubator-superset] kkucharc opened a new pull request #11000: fix: enable several pylint rules partially in db_engines_specs module
kkucharc opened a new pull request #11000:
URL: https://github.com/apache/incubator-superset/pull/11000
### SUMMARY
Enabling pylint rules in `db_engines_specs` module (similar to [PR-10998](https://github.com/apache/incubator-superset/pull/10998)):
- `unused-import` isn't triggered anymore
- changed too long lines
- changed `fstring` to `string`
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kkucharc commented on pull request #11000: fix: enable several pylint rules partially in db_engines_specs module
Posted by GitBox <gi...@apache.org>.
kkucharc commented on pull request #11000:
URL: https://github.com/apache/incubator-superset/pull/11000#issuecomment-697215307
Thank you @mistercrunch for the review. @willbarrett would you take a look as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett merged pull request #11000: fix: enable several pylint rules partially in db_engines_specs module
Posted by GitBox <gi...@apache.org>.
willbarrett merged pull request #11000:
URL: https://github.com/apache/incubator-superset/pull/11000
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org