You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by "kw2542 (via GitHub)" <gi...@apache.org> on 2023/02/02 20:15:28 UTC

[GitHub] [beam] kw2542 commented on a diff in pull request #25265: Support samza portable UDF metrics.

kw2542 commented on code in PR #25265:
URL: https://github.com/apache/beam/pull/25265#discussion_r1095044933


##########
runners/samza/src/main/java/org/apache/beam/runners/samza/runtime/SamzaMetricsBundleProgressHandler.java:
##########
@@ -148,7 +151,10 @@ private void parseAndUpdateMetric(MetricsApi.MonitoringInfo monitoringInfo) {
         break;
 
       default:
-        LOG.warn("Unsupported metric type {}", monitoringInfo.getType());
+        if (LOG.isDebugEnabled()) {

Review Comment:
   +1, LOG.debug() checks debug enabled itself. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org