You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by Bryan Duxbury <br...@rapleaf.com> on 2010/08/13 06:40:59 UTC
[VOTE] Thrift 0.4.0 RC0
Hi all,
As discussed, in all the time it took for us to finally release Thrift 0.3,
we've accumulated enough changes for Thrift 0.4!
I propose we accept
http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc0.tar.gz<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz>as
the official Thrift 0.4.0 release.
I created this tarball by checking out URL:
https://svn.apache.org/repos/asf/incubator/thrift/branches/0.4.x and running
"./bootstrap.sh && ./configure && make dist".
The GPG signature for this tarball can be found at
http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc0.tar.gz.asc<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz.asc>.
It has an MD5 signature of c272591c1b3560fdef86104e2be214dc.
Please download, verify the signatures, untar, and install and test the
libraries you are familiar with. We need your +1 votes to make the release!
If you encounter any problems, please let me know immediately. This vote
will close 72 hours from now.
This release consists of 45 tickets that cover many bugs and performance
improvements. Please refer to the CHANGES file for the full list.
-Bryan
Re: [VOTE] Thrift 0.4.0 RC0
Posted by Rush Manbert <ru...@manbert.com>.
Ah, I see about BOOST_LDFLAGS. I just checked the thrift source that we run off and see that I fixed that bug in my 591 patch. That's why make check works for me.
You didn't write a Jira bug about that? (I'm getting ready to write 2 of them.)
On Aug 13, 2010, at 5:24 PM, Michael Lum wrote:
> Sure, I could submit a configure.ac patch to do the perl checks.
>
> The make check fails because UnitTests_LDADD in the test/Makefile.am doesn't include $(BOOST_LDFLAGS), so if boost is in a non-standard location (for example MacPorts puts it in /opt/local), the Makefile can't find it at link time. I sent a patch for that yesterday to the list, but can attach it to a JIRA ticket if need be.
>
> On 8/13/2010 5:12 PM, Rush Manbert wrote:
>> Well, if it's a runtime requirement, then the configure should check for it, but only if --with-perl=yes, and fail if it's not installed. Then if I don't want to install it I can just configure with --with-perl=no.
>>
>> HOWEVER, I started fresh and configured like this:
>>
>> ./configure --prefix=/Users/rmanbert/Kits/thrift/thrift-0.4.0_Install --with-boos
>> t=/Volumes/DevSsd/devSsd/dev/client/thirdPartyLibs/installedMac/individual/boost --with-zlib=/Volumes/DevSsd/devSsd/dev
>> /client/thirdPartyLibs/installedMac/individual/zlib --enable-gen-perl=no --with-perl=no
>>
>> The configure succeeded, but the make fails like this:
>> ../compiler/cpp/thrift --gen cpp:dense ThriftTest.thrift
>> [FAILURE:/Users/rmanbert/Kits/thrift/thrift-0.4.0/test/ThriftTest.thrift:27] No generator named 'perl' could be found!
>> make[3]: *** [gen-cpp/ThriftTest_types.cpp] Error 1
>> make[2]: *** [all-recursive] Error 1
>> make[1]: *** [all-recursive] Error 1
>> make: *** [all] Error 2
>>
>> which seems like a bug of a different stripe, and it makes me wonder whether any of the --enable-lang-gen options really work if you set them to no.
>>
>> So I started fresh again and configured like this:
>> ./configure --prefix=/Users/rmanbert/Kits/thrift/thrift-0.4.0_Install --with-boost=/Volumes/DevSsd/devSsd/dev/client/thirdPartyLibs/installedMac/individual/boost --with-zlib=/Volumes/DevSsd/devSsd/dev/client/third
>> PartyLibs/installedMac/individual/zlib --with-perl=no
>>
>> Configure succeeds.
>>
>> Make succeeds.
>>
>> Make check fails with this:
>> libtool: link: g++ -g -O2 -o .libs/UnitTests UnitTestMain.o TMemoryBufferTest.o TBufferBaseTest.o -Wl,-bind_at_load ./.libs/libtestgencpp.a /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/cpp/.libs/libthrift.dylib -lboost_unit_test_framework -lpthread
>> ld: library not found for -lboost_unit_test_framework
>> collect2: ld returned 1 exit status
>> make[3]: *** [UnitTests] Error 1
>> make[2]: *** [check-am] Error 2
>> make[1]: *** [check-recursive] Error 1
>> make: *** [check-recursive] Error 1
>>
>> because all of my boost libraries have threading, debug, etc. encoded into their names. So on my system the boost unit test library is named "libboost_unit_test_framework-mt.a" or "libboost_unit_test_framework-mt-d.a".
>>
>> The thrift libraries themselves got built, so it was okay that the libraries they need use this naming convention. Why does a link associated with the tests fail?
>>
>> So now I'm sort of -2. ;-)
>>
>> This is because:
>> 1) The perl librarues require Bit::Vector to be installed, but it's not checked for at configure time. I think it should fail unless you have specified --with-perl=no.
>> (If we all agree on this, I'll file the Jira. Maybe you can submit the patrch?)
>> 2) The C++ library tests have a hardcoded notion of what the name of the boost unit test library is, which doesn't match the boost library naming conventions. (available here: http://www.boost.org/doc/libs/1_43_0/more/getting_started/unix-variants.html#library-naming )
>> IIRC, this used to work, because I run the make check as part of our standard build of the libraries, but we're still running off of pre-0.1 code.
>>
>> There also seems to be a problem with specifying --enable-lang-gen=no to configure, but I'll let that one go.
>>
>> - Rush
>>
>> On Aug 13, 2010, at 4:11 PM, Michael Lum wrote:
>>
>>> It looks like Bit::Vector is referenced in Thrift::BinaryProtocol as well as the Makefile.PL, so it appears to be a runtime dependency, not just a test one.
>>>
>>> The other way to do this is to not build the Thrift perl libraries if the module detection fails, by tweaking the WITH_PERL variable.
>>>
>>> On 8/13/2010 3:29 PM, Rush Manbert wrote:
>>>> If I read it correctly, the effect of this patch is that the configure will fail on stock OSX 10.6.4. (That's what I have - no special Perl modules installed) Is that correct?
>>>>
>>>> I don't use Perl any more, so don't know what you get in a standard Perl installation. If Bit::Vector isn't included, then I would tend to classify this more as a bug in the tests and I wouldn't make the config fail if it's not there. But possibly this is specific to OSX?
>>>>
>>>> - Rush
>>>>
>>>> On Aug 13, 2010, at 3:00 PM, Michael Lum wrote:
>>>>
>>>>> It's complaining about Bit::Vector not being there. I'm not sure if its required by the Thrift library itself, or just the tests, but one way to address it would be this patch, which checks for Bit::Vector at configure time.
>>>>>
>>>>> --- configure.ac.orig 2010-08-13 14:31:33.000000000 -0700
>>>>> +++ configure.ac 2010-08-13 14:58:56.000000000 -0700
>>>>> @@ -118,6 +118,9 @@
>>>>> AX_THRIFT_LIB(perl, [Perl], yes)
>>>>> if test "$with_perl" = "yes"; then
>>>>> AC_PATH_PROG([PERL], [perl])
>>>>> + if test -n "`$PERL -MBit::Vector -e exit 2>&1`"; then
>>>>> + AC_MSG_ERROR([Perl module Bit::Vector not installed])
>>>>> + fi
>>>>> fi
>>>>> AM_CONDITIONAL(WITH_PERL, [test -n "$PERL"])
>>>>>
>>>>>
>>>>>
>>>>> On 8/13/2010 1:34 PM, Rush Manbert wrote:
>>>>>> On Aug 12, 2010, at 9:40 PM, Bryan Duxbury wrote:
>>>>>>
>>>>>>> Hi all,
>>>>>>>
>>>>>>> As discussed, in all the time it took for us to finally release Thrift 0.3,
>>>>>>> we've accumulated enough changes for Thrift 0.4!
>>>>>>>
>>>>>>> I propose we accept
>>>>>>> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc0.tar.gz<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz>as
>>>>>>> the official Thrift 0.4.0 release.
>>>>>>>
>>>>>> <snip>
>>>>>>
>>>>>> I used the tarball on Mac OS X 10.6.4, Xcode 3.2.2, boost 1.42, zlib 1.2.3.
>>>>>>
>>>>>> configures fine.
>>>>>>
>>>>>> make completes successfully.
>>>>>>
>>>>>> make check errors like so:
>>>>>> Making check in perl
>>>>>> Making check in test
>>>>>> make check-local
>>>>>> ../../../compiler/cpp/thrift --gen perl ../../../test/ThriftTest.thrift
>>>>>> make -f Makefile-perl.mk
>>>>>> find blib -name 'Makefile*' -exec rm -f {} \;
>>>>>> make check-local
>>>>>> /opt/local/bin/perl -Iblib/lib -I/Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl -I./test/gen-perl \
>>>>>> /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test.pl /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/*.t
>>>>>> /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/memory_buffer....Can't locate Bit/Vector.pm in @INC (@INC contains: blib/lib /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl ./test/gen-perl /opt/local/lib/perl5/site_perl/5.8.9/darwin-2level /opt/local/lib/perl5/site_perl/5.8.9 /opt/local/lib/perl5/site_perl /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level /opt/local/lib/perl5/vendor_perl/5.8.9 /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level /opt/local/lib/perl5/vendor_perl/5.8.9 /opt/local/lib/perl5/vendor_perl /opt/local/lib/perl5/5.8.9/darwin-2level /opt/local/lib/perl5/5.8.9/darwin-2level /opt/local/lib/perl5/5.8.9 . /opt/local/lib/perl5/site_perl/5.8.9/darwin-2level /opt/local/lib/perl5/site_perl/5.8.9 /opt/local/lib/perl5/site_perl /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level /opt/local/lib/perl5/vendor_perl/5.8.9 /opt/local/lib/perl5/vendor_perl /opt/local/lib/perl5/5.8.9/darwin-2level /
> op
>>> t/
>>>>> local/lib/perl5/5.8.9 .) at blib/lib/Thrift/BinaryProtocol.pm line 31.
>>>>>> BEGIN failed--compilation aborted at blib/lib/Thrift/BinaryProtocol.pm line 31.
>>>>>> Compilation failed in require at /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/memory_buffer.t line 27.
>>>>>> BEGIN failed--compilation aborted at /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/memory_buffer.t line 27.
>>>>>> # Looks like your test died before it could output anything.
>>>>>> /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/memory_buffer....dubious
>>>>>> Test returned status 255 (wstat 65280, 0xff00)
>>>>>> DIED. FAILED tests 1-6
>>>>>> Failed 6/6 tests, 0.00% okay
>>>>>> /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/processor........Can't locate Bit/Vector.pm in @INC (@INC contains: blib/lib /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl ./test/gen-perl /opt/local/lib/perl5/site_perl/5.8.9/darwin-2level /opt/local/lib/perl5/site_perl/5.8.9 /opt/local/lib/perl5/site_perl /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level /opt/local/lib/perl5/vendor_perl/5.8.9 /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level /opt/local/lib/perl5/vendor_perl/5.8.9 /opt/local/lib/perl5/vendor_perl /opt/local/lib/perl5/5.8.9/darwin-2level /opt/local/lib/perl5/5.8.9/darwin-2level /opt/local/lib/perl5/5.8.9 . /opt/local/lib/perl5/site_perl/5.8.9/darwin-2level /opt/local/lib/perl5/site_perl/5.8.9 /opt/local/lib/perl5/site_perl /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level /opt/local/lib/perl5/vendor_perl/5.8.9 /opt/local/lib/perl5/vendor_perl /opt/local/lib/perl5/5.8.9/darwin-2level /
> op
>>> t/
>>>>> local/lib/perl5/5.8.9 .) at blib/lib/Thrift/BinaryProtocol.pm line 31.
>>>>>> BEGIN failed--compilation aborted at blib/lib/Thrift/BinaryProtocol.pm line 31.
>>>>>> Compilation failed in require at /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/processor.t line 26.
>>>>>> BEGIN failed--compilation aborted at /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/processor.t line 26.
>>>>>> # Looks like your test died before it could output anything.
>>>>>> /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/processor........dubious
>>>>>> Test returned status 255 (wstat 65280, 0xff00)
>>>>>> DIED. FAILED tests 1-2
>>>>>> Failed 2/2 tests, 0.00% okay
>>>>>> Failed Test Stat Wstat Total Fail List of Failed
>>>>>> -------------------------------------------------------------------------------
>>>>>> /Users/rmanbert/Kits/thrift/thrift-0.4.0/ 255 65280 6 12 1-6
>>>>>> /Users/rmanbert/Kits/thrift/thrift-0.4.0/ 255 65280 2 4 1-2
>>>>>> Failed 2/2 test scripts. 8/8 subtests failed.
>>>>>> Files=2, Tests=8, 1 wallclock secs ( 0.05 cusr + 0.02 csys = 0.07 CPU)
>>>>>> Failed 2/2 test programs. 8/8 subtests failed.
>>>>>> make[4]: *** [check-local] Error 255
>>>>>> make[3]: *** [check-am] Error 2
>>>>>> make[2]: *** [check-recursive] Error 1
>>>>>> make[1]: *** [check-recursive] Error 1
>>>>>> make: *** [check-recursive] Error 1
>>>>>>
>>>>>> So I guess it's a -1 from me.
>>>>>>
>>>>>> - Rush
>>>>
>>
Re: [VOTE] Thrift 0.4.0 RC0
Posted by Michael Lum <mi...@openx.org>.
Sure, I could submit a configure.ac patch to do the perl checks.
The make check fails because UnitTests_LDADD in the test/Makefile.am
doesn't include $(BOOST_LDFLAGS), so if boost is in a non-standard
location (for example MacPorts puts it in /opt/local), the Makefile
can't find it at link time. I sent a patch for that yesterday to the
list, but can attach it to a JIRA ticket if need be.
On 8/13/2010 5:12 PM, Rush Manbert wrote:
> Well, if it's a runtime requirement, then the configure should check for it, but only if --with-perl=yes, and fail if it's not installed. Then if I don't want to install it I can just configure with --with-perl=no.
>
> HOWEVER, I started fresh and configured like this:
>
> ./configure --prefix=/Users/rmanbert/Kits/thrift/thrift-0.4.0_Install --with-boos
> t=/Volumes/DevSsd/devSsd/dev/client/thirdPartyLibs/installedMac/individual/boost --with-zlib=/Volumes/DevSsd/devSsd/dev
> /client/thirdPartyLibs/installedMac/individual/zlib --enable-gen-perl=no --with-perl=no
>
> The configure succeeded, but the make fails like this:
> ../compiler/cpp/thrift --gen cpp:dense ThriftTest.thrift
> [FAILURE:/Users/rmanbert/Kits/thrift/thrift-0.4.0/test/ThriftTest.thrift:27] No generator named 'perl' could be found!
> make[3]: *** [gen-cpp/ThriftTest_types.cpp] Error 1
> make[2]: *** [all-recursive] Error 1
> make[1]: *** [all-recursive] Error 1
> make: *** [all] Error 2
>
> which seems like a bug of a different stripe, and it makes me wonder whether any of the --enable-lang-gen options really work if you set them to no.
>
> So I started fresh again and configured like this:
> ./configure --prefix=/Users/rmanbert/Kits/thrift/thrift-0.4.0_Install --with-boost=/Volumes/DevSsd/devSsd/dev/client/thirdPartyLibs/installedMac/individual/boost --with-zlib=/Volumes/DevSsd/devSsd/dev/client/third
> PartyLibs/installedMac/individual/zlib --with-perl=no
>
> Configure succeeds.
>
> Make succeeds.
>
> Make check fails with this:
> libtool: link: g++ -g -O2 -o .libs/UnitTests UnitTestMain.o TMemoryBufferTest.o TBufferBaseTest.o -Wl,-bind_at_load ./.libs/libtestgencpp.a /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/cpp/.libs/libthrift.dylib -lboost_unit_test_framework -lpthread
> ld: library not found for -lboost_unit_test_framework
> collect2: ld returned 1 exit status
> make[3]: *** [UnitTests] Error 1
> make[2]: *** [check-am] Error 2
> make[1]: *** [check-recursive] Error 1
> make: *** [check-recursive] Error 1
>
> because all of my boost libraries have threading, debug, etc. encoded into their names. So on my system the boost unit test library is named "libboost_unit_test_framework-mt.a" or "libboost_unit_test_framework-mt-d.a".
>
> The thrift libraries themselves got built, so it was okay that the libraries they need use this naming convention. Why does a link associated with the tests fail?
>
> So now I'm sort of -2. ;-)
>
> This is because:
> 1) The perl librarues require Bit::Vector to be installed, but it's not checked for at configure time. I think it should fail unless you have specified --with-perl=no.
> (If we all agree on this, I'll file the Jira. Maybe you can submit the patrch?)
> 2) The C++ library tests have a hardcoded notion of what the name of the boost unit test library is, which doesn't match the boost library naming conventions. (available here: http://www.boost.org/doc/libs/1_43_0/more/getting_started/unix-variants.html#library-naming )
> IIRC, this used to work, because I run the make check as part of our standard build of the libraries, but we're still running off of pre-0.1 code.
>
> There also seems to be a problem with specifying --enable-lang-gen=no to configure, but I'll let that one go.
>
> - Rush
>
> On Aug 13, 2010, at 4:11 PM, Michael Lum wrote:
>
>> It looks like Bit::Vector is referenced in Thrift::BinaryProtocol as well as the Makefile.PL, so it appears to be a runtime dependency, not just a test one.
>>
>> The other way to do this is to not build the Thrift perl libraries if the module detection fails, by tweaking the WITH_PERL variable.
>>
>> On 8/13/2010 3:29 PM, Rush Manbert wrote:
>>> If I read it correctly, the effect of this patch is that the configure will fail on stock OSX 10.6.4. (That's what I have - no special Perl modules installed) Is that correct?
>>>
>>> I don't use Perl any more, so don't know what you get in a standard Perl installation. If Bit::Vector isn't included, then I would tend to classify this more as a bug in the tests and I wouldn't make the config fail if it's not there. But possibly this is specific to OSX?
>>>
>>> - Rush
>>>
>>> On Aug 13, 2010, at 3:00 PM, Michael Lum wrote:
>>>
>>>> It's complaining about Bit::Vector not being there. I'm not sure if its required by the Thrift library itself, or just the tests, but one way to address it would be this patch, which checks for Bit::Vector at configure time.
>>>>
>>>> --- configure.ac.orig 2010-08-13 14:31:33.000000000 -0700
>>>> +++ configure.ac 2010-08-13 14:58:56.000000000 -0700
>>>> @@ -118,6 +118,9 @@
>>>> AX_THRIFT_LIB(perl, [Perl], yes)
>>>> if test "$with_perl" = "yes"; then
>>>> AC_PATH_PROG([PERL], [perl])
>>>> + if test -n "`$PERL -MBit::Vector -e exit 2>&1`"; then
>>>> + AC_MSG_ERROR([Perl module Bit::Vector not installed])
>>>> + fi
>>>> fi
>>>> AM_CONDITIONAL(WITH_PERL, [test -n "$PERL"])
>>>>
>>>>
>>>>
>>>> On 8/13/2010 1:34 PM, Rush Manbert wrote:
>>>>> On Aug 12, 2010, at 9:40 PM, Bryan Duxbury wrote:
>>>>>
>>>>>> Hi all,
>>>>>>
>>>>>> As discussed, in all the time it took for us to finally release Thrift 0.3,
>>>>>> we've accumulated enough changes for Thrift 0.4!
>>>>>>
>>>>>> I propose we accept
>>>>>> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc0.tar.gz<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz>as
>>>>>> the official Thrift 0.4.0 release.
>>>>>>
>>>>> <snip>
>>>>>
>>>>> I used the tarball on Mac OS X 10.6.4, Xcode 3.2.2, boost 1.42, zlib 1.2.3.
>>>>>
>>>>> configures fine.
>>>>>
>>>>> make completes successfully.
>>>>>
>>>>> make check errors like so:
>>>>> Making check in perl
>>>>> Making check in test
>>>>> make check-local
>>>>> ../../../compiler/cpp/thrift --gen perl ../../../test/ThriftTest.thrift
>>>>> make -f Makefile-perl.mk
>>>>> find blib -name 'Makefile*' -exec rm -f {} \;
>>>>> make check-local
>>>>> /opt/local/bin/perl -Iblib/lib -I/Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl -I./test/gen-perl \
>>>>> /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test.pl /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/*.t
>>>>> /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/memory_buffer....Can't locate Bit/Vector.pm in @INC (@INC contains: blib/lib /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl ./test/gen-perl /opt/local/lib/perl5/site_perl/5.8.9/darwin-2level /opt/local/lib/perl5/site_perl/5.8.9 /opt/local/lib/perl5/site_perl /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level /opt/local/lib/perl5/vendor_perl/5.8.9 /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level /opt/local/lib/perl5/vendor_perl/5.8.9 /opt/local/lib/perl5/vendor_perl /opt/local/lib/perl5/5.8.9/darwin-2level /opt/local/lib/perl5/5.8.9/darwin-2level /opt/local/lib/perl5/5.8.9 . /opt/local/lib/perl5/site_perl/5.8.9/darwin-2level /opt/local/lib/perl5/site_perl/5.8.9 /opt/local/lib/perl5/site_perl /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level /opt/local/lib/perl5/vendor_perl/5.8.9 /opt/local/lib/perl5/vendor_perl /opt/local/lib/perl5/5.8.9/darwin-2level /
op
>> t/
>>>> local/lib/perl5/5.8.9 .) at blib/lib/Thrift/BinaryProtocol.pm line 31.
>>>>> BEGIN failed--compilation aborted at blib/lib/Thrift/BinaryProtocol.pm line 31.
>>>>> Compilation failed in require at /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/memory_buffer.t line 27.
>>>>> BEGIN failed--compilation aborted at /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/memory_buffer.t line 27.
>>>>> # Looks like your test died before it could output anything.
>>>>> /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/memory_buffer....dubious
>>>>> Test returned status 255 (wstat 65280, 0xff00)
>>>>> DIED. FAILED tests 1-6
>>>>> Failed 6/6 tests, 0.00% okay
>>>>> /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/processor........Can't locate Bit/Vector.pm in @INC (@INC contains: blib/lib /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl ./test/gen-perl /opt/local/lib/perl5/site_perl/5.8.9/darwin-2level /opt/local/lib/perl5/site_perl/5.8.9 /opt/local/lib/perl5/site_perl /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level /opt/local/lib/perl5/vendor_perl/5.8.9 /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level /opt/local/lib/perl5/vendor_perl/5.8.9 /opt/local/lib/perl5/vendor_perl /opt/local/lib/perl5/5.8.9/darwin-2level /opt/local/lib/perl5/5.8.9/darwin-2level /opt/local/lib/perl5/5.8.9 . /opt/local/lib/perl5/site_perl/5.8.9/darwin-2level /opt/local/lib/perl5/site_perl/5.8.9 /opt/local/lib/perl5/site_perl /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level /opt/local/lib/perl5/vendor_perl/5.8.9 /opt/local/lib/perl5/vendor_perl /opt/local/lib/perl5/5.8.9/darwin-2level /
op
>> t/
>>>> local/lib/perl5/5.8.9 .) at blib/lib/Thrift/BinaryProtocol.pm line 31.
>>>>> BEGIN failed--compilation aborted at blib/lib/Thrift/BinaryProtocol.pm line 31.
>>>>> Compilation failed in require at /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/processor.t line 26.
>>>>> BEGIN failed--compilation aborted at /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/processor.t line 26.
>>>>> # Looks like your test died before it could output anything.
>>>>> /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/processor........dubious
>>>>> Test returned status 255 (wstat 65280, 0xff00)
>>>>> DIED. FAILED tests 1-2
>>>>> Failed 2/2 tests, 0.00% okay
>>>>> Failed Test Stat Wstat Total Fail List of Failed
>>>>> -------------------------------------------------------------------------------
>>>>> /Users/rmanbert/Kits/thrift/thrift-0.4.0/ 255 65280 6 12 1-6
>>>>> /Users/rmanbert/Kits/thrift/thrift-0.4.0/ 255 65280 2 4 1-2
>>>>> Failed 2/2 test scripts. 8/8 subtests failed.
>>>>> Files=2, Tests=8, 1 wallclock secs ( 0.05 cusr + 0.02 csys = 0.07 CPU)
>>>>> Failed 2/2 test programs. 8/8 subtests failed.
>>>>> make[4]: *** [check-local] Error 255
>>>>> make[3]: *** [check-am] Error 2
>>>>> make[2]: *** [check-recursive] Error 1
>>>>> make[1]: *** [check-recursive] Error 1
>>>>> make: *** [check-recursive] Error 1
>>>>>
>>>>> So I guess it's a -1 from me.
>>>>>
>>>>> - Rush
>>>
>
Re: [VOTE] Thrift 0.4.0 RC0
Posted by Rush Manbert <ru...@manbert.com>.
Well, if it's a runtime requirement, then the configure should check for it, but only if --with-perl=yes, and fail if it's not installed. Then if I don't want to install it I can just configure with --with-perl=no.
HOWEVER, I started fresh and configured like this:
./configure --prefix=/Users/rmanbert/Kits/thrift/thrift-0.4.0_Install --with-boos
t=/Volumes/DevSsd/devSsd/dev/client/thirdPartyLibs/installedMac/individual/boost --with-zlib=/Volumes/DevSsd/devSsd/dev
/client/thirdPartyLibs/installedMac/individual/zlib --enable-gen-perl=no --with-perl=no
The configure succeeded, but the make fails like this:
../compiler/cpp/thrift --gen cpp:dense ThriftTest.thrift
[FAILURE:/Users/rmanbert/Kits/thrift/thrift-0.4.0/test/ThriftTest.thrift:27] No generator named 'perl' could be found!
make[3]: *** [gen-cpp/ThriftTest_types.cpp] Error 1
make[2]: *** [all-recursive] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2
which seems like a bug of a different stripe, and it makes me wonder whether any of the --enable-lang-gen options really work if you set them to no.
So I started fresh again and configured like this:
./configure --prefix=/Users/rmanbert/Kits/thrift/thrift-0.4.0_Install --with-boost=/Volumes/DevSsd/devSsd/dev/client/thirdPartyLibs/installedMac/individual/boost --with-zlib=/Volumes/DevSsd/devSsd/dev/client/third
PartyLibs/installedMac/individual/zlib --with-perl=no
Configure succeeds.
Make succeeds.
Make check fails with this:
libtool: link: g++ -g -O2 -o .libs/UnitTests UnitTestMain.o TMemoryBufferTest.o TBufferBaseTest.o -Wl,-bind_at_load ./.libs/libtestgencpp.a /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/cpp/.libs/libthrift.dylib -lboost_unit_test_framework -lpthread
ld: library not found for -lboost_unit_test_framework
collect2: ld returned 1 exit status
make[3]: *** [UnitTests] Error 1
make[2]: *** [check-am] Error 2
make[1]: *** [check-recursive] Error 1
make: *** [check-recursive] Error 1
because all of my boost libraries have threading, debug, etc. encoded into their names. So on my system the boost unit test library is named "libboost_unit_test_framework-mt.a" or "libboost_unit_test_framework-mt-d.a".
The thrift libraries themselves got built, so it was okay that the libraries they need use this naming convention. Why does a link associated with the tests fail?
So now I'm sort of -2. ;-)
This is because:
1) The perl librarues require Bit::Vector to be installed, but it's not checked for at configure time. I think it should fail unless you have specified --with-perl=no.
(If we all agree on this, I'll file the Jira. Maybe you can submit the patrch?)
2) The C++ library tests have a hardcoded notion of what the name of the boost unit test library is, which doesn't match the boost library naming conventions. (available here: http://www.boost.org/doc/libs/1_43_0/more/getting_started/unix-variants.html#library-naming )
IIRC, this used to work, because I run the make check as part of our standard build of the libraries, but we're still running off of pre-0.1 code.
There also seems to be a problem with specifying --enable-lang-gen=no to configure, but I'll let that one go.
- Rush
On Aug 13, 2010, at 4:11 PM, Michael Lum wrote:
> It looks like Bit::Vector is referenced in Thrift::BinaryProtocol as well as the Makefile.PL, so it appears to be a runtime dependency, not just a test one.
>
> The other way to do this is to not build the Thrift perl libraries if the module detection fails, by tweaking the WITH_PERL variable.
>
> On 8/13/2010 3:29 PM, Rush Manbert wrote:
>> If I read it correctly, the effect of this patch is that the configure will fail on stock OSX 10.6.4. (That's what I have - no special Perl modules installed) Is that correct?
>>
>> I don't use Perl any more, so don't know what you get in a standard Perl installation. If Bit::Vector isn't included, then I would tend to classify this more as a bug in the tests and I wouldn't make the config fail if it's not there. But possibly this is specific to OSX?
>>
>> - Rush
>>
>> On Aug 13, 2010, at 3:00 PM, Michael Lum wrote:
>>
>>> It's complaining about Bit::Vector not being there. I'm not sure if its required by the Thrift library itself, or just the tests, but one way to address it would be this patch, which checks for Bit::Vector at configure time.
>>>
>>> --- configure.ac.orig 2010-08-13 14:31:33.000000000 -0700
>>> +++ configure.ac 2010-08-13 14:58:56.000000000 -0700
>>> @@ -118,6 +118,9 @@
>>> AX_THRIFT_LIB(perl, [Perl], yes)
>>> if test "$with_perl" = "yes"; then
>>> AC_PATH_PROG([PERL], [perl])
>>> + if test -n "`$PERL -MBit::Vector -e exit 2>&1`"; then
>>> + AC_MSG_ERROR([Perl module Bit::Vector not installed])
>>> + fi
>>> fi
>>> AM_CONDITIONAL(WITH_PERL, [test -n "$PERL"])
>>>
>>>
>>>
>>> On 8/13/2010 1:34 PM, Rush Manbert wrote:
>>>> On Aug 12, 2010, at 9:40 PM, Bryan Duxbury wrote:
>>>>
>>>>> Hi all,
>>>>>
>>>>> As discussed, in all the time it took for us to finally release Thrift 0.3,
>>>>> we've accumulated enough changes for Thrift 0.4!
>>>>>
>>>>> I propose we accept
>>>>> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc0.tar.gz<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz>as
>>>>> the official Thrift 0.4.0 release.
>>>>>
>>>> <snip>
>>>>
>>>> I used the tarball on Mac OS X 10.6.4, Xcode 3.2.2, boost 1.42, zlib 1.2.3.
>>>>
>>>> configures fine.
>>>>
>>>> make completes successfully.
>>>>
>>>> make check errors like so:
>>>> Making check in perl
>>>> Making check in test
>>>> make check-local
>>>> ../../../compiler/cpp/thrift --gen perl ../../../test/ThriftTest.thrift
>>>> make -f Makefile-perl.mk
>>>> find blib -name 'Makefile*' -exec rm -f {} \;
>>>> make check-local
>>>> /opt/local/bin/perl -Iblib/lib -I/Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl -I./test/gen-perl \
>>>> /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test.pl /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/*.t
>>>> /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/memory_buffer....Can't locate Bit/Vector.pm in @INC (@INC contains: blib/lib /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl ./test/gen-perl /opt/local/lib/perl5/site_perl/5.8.9/darwin-2level /opt/local/lib/perl5/site_perl/5.8.9 /opt/local/lib/perl5/site_perl /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level /opt/local/lib/perl5/vendor_perl/5.8.9 /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level /opt/local/lib/perl5/vendor_perl/5.8.9 /opt/local/lib/perl5/vendor_perl /opt/local/lib/perl5/5.8.9/darwin-2level /opt/local/lib/perl5/5.8.9/darwin-2level /opt/local/lib/perl5/5.8.9 . /opt/local/lib/perl5/site_perl/5.8.9/darwin-2level /opt/local/lib/perl5/site_perl/5.8.9 /opt/local/lib/perl5/site_perl /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level /opt/local/lib/perl5/vendor_perl/5.8.9 /opt/local/lib/perl5/vendor_perl /opt/local/lib/perl5/5.8.9/darwin-2level /op
> t/
>>> local/lib/perl5/5.8.9 .) at blib/lib/Thrift/BinaryProtocol.pm line 31.
>>>> BEGIN failed--compilation aborted at blib/lib/Thrift/BinaryProtocol.pm line 31.
>>>> Compilation failed in require at /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/memory_buffer.t line 27.
>>>> BEGIN failed--compilation aborted at /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/memory_buffer.t line 27.
>>>> # Looks like your test died before it could output anything.
>>>> /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/memory_buffer....dubious
>>>> Test returned status 255 (wstat 65280, 0xff00)
>>>> DIED. FAILED tests 1-6
>>>> Failed 6/6 tests, 0.00% okay
>>>> /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/processor........Can't locate Bit/Vector.pm in @INC (@INC contains: blib/lib /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl ./test/gen-perl /opt/local/lib/perl5/site_perl/5.8.9/darwin-2level /opt/local/lib/perl5/site_perl/5.8.9 /opt/local/lib/perl5/site_perl /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level /opt/local/lib/perl5/vendor_perl/5.8.9 /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level /opt/local/lib/perl5/vendor_perl/5.8.9 /opt/local/lib/perl5/vendor_perl /opt/local/lib/perl5/5.8.9/darwin-2level /opt/local/lib/perl5/5.8.9/darwin-2level /opt/local/lib/perl5/5.8.9 . /opt/local/lib/perl5/site_perl/5.8.9/darwin-2level /opt/local/lib/perl5/site_perl/5.8.9 /opt/local/lib/perl5/site_perl /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level /opt/local/lib/perl5/vendor_perl/5.8.9 /opt/local/lib/perl5/vendor_perl /opt/local/lib/perl5/5.8.9/darwin-2level /op
> t/
>>> local/lib/perl5/5.8.9 .) at blib/lib/Thrift/BinaryProtocol.pm line 31.
>>>> BEGIN failed--compilation aborted at blib/lib/Thrift/BinaryProtocol.pm line 31.
>>>> Compilation failed in require at /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/processor.t line 26.
>>>> BEGIN failed--compilation aborted at /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/processor.t line 26.
>>>> # Looks like your test died before it could output anything.
>>>> /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/processor........dubious
>>>> Test returned status 255 (wstat 65280, 0xff00)
>>>> DIED. FAILED tests 1-2
>>>> Failed 2/2 tests, 0.00% okay
>>>> Failed Test Stat Wstat Total Fail List of Failed
>>>> -------------------------------------------------------------------------------
>>>> /Users/rmanbert/Kits/thrift/thrift-0.4.0/ 255 65280 6 12 1-6
>>>> /Users/rmanbert/Kits/thrift/thrift-0.4.0/ 255 65280 2 4 1-2
>>>> Failed 2/2 test scripts. 8/8 subtests failed.
>>>> Files=2, Tests=8, 1 wallclock secs ( 0.05 cusr + 0.02 csys = 0.07 CPU)
>>>> Failed 2/2 test programs. 8/8 subtests failed.
>>>> make[4]: *** [check-local] Error 255
>>>> make[3]: *** [check-am] Error 2
>>>> make[2]: *** [check-recursive] Error 1
>>>> make[1]: *** [check-recursive] Error 1
>>>> make: *** [check-recursive] Error 1
>>>>
>>>> So I guess it's a -1 from me.
>>>>
>>>> - Rush
>>
Re: [VOTE] Thrift 0.4.0 RC0
Posted by Michael Lum <mi...@openx.org>.
It looks like Bit::Vector is referenced in Thrift::BinaryProtocol as
well as the Makefile.PL, so it appears to be a runtime dependency, not
just a test one.
The other way to do this is to not build the Thrift perl libraries if
the module detection fails, by tweaking the WITH_PERL variable.
On 8/13/2010 3:29 PM, Rush Manbert wrote:
> If I read it correctly, the effect of this patch is that the configure will fail on stock OSX 10.6.4. (That's what I have - no special Perl modules installed) Is that correct?
>
> I don't use Perl any more, so don't know what you get in a standard Perl installation. If Bit::Vector isn't included, then I would tend to classify this more as a bug in the tests and I wouldn't make the config fail if it's not there. But possibly this is specific to OSX?
>
> - Rush
>
> On Aug 13, 2010, at 3:00 PM, Michael Lum wrote:
>
>> It's complaining about Bit::Vector not being there. I'm not sure if its required by the Thrift library itself, or just the tests, but one way to address it would be this patch, which checks for Bit::Vector at configure time.
>>
>> --- configure.ac.orig 2010-08-13 14:31:33.000000000 -0700
>> +++ configure.ac 2010-08-13 14:58:56.000000000 -0700
>> @@ -118,6 +118,9 @@
>> AX_THRIFT_LIB(perl, [Perl], yes)
>> if test "$with_perl" = "yes"; then
>> AC_PATH_PROG([PERL], [perl])
>> + if test -n "`$PERL -MBit::Vector -e exit 2>&1`"; then
>> + AC_MSG_ERROR([Perl module Bit::Vector not installed])
>> + fi
>> fi
>> AM_CONDITIONAL(WITH_PERL, [test -n "$PERL"])
>>
>>
>>
>> On 8/13/2010 1:34 PM, Rush Manbert wrote:
>>> On Aug 12, 2010, at 9:40 PM, Bryan Duxbury wrote:
>>>
>>>> Hi all,
>>>>
>>>> As discussed, in all the time it took for us to finally release Thrift 0.3,
>>>> we've accumulated enough changes for Thrift 0.4!
>>>>
>>>> I propose we accept
>>>> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc0.tar.gz<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz>as
>>>> the official Thrift 0.4.0 release.
>>>>
>>> <snip>
>>>
>>> I used the tarball on Mac OS X 10.6.4, Xcode 3.2.2, boost 1.42, zlib 1.2.3.
>>>
>>> configures fine.
>>>
>>> make completes successfully.
>>>
>>> make check errors like so:
>>> Making check in perl
>>> Making check in test
>>> make check-local
>>> ../../../compiler/cpp/thrift --gen perl ../../../test/ThriftTest.thrift
>>> make -f Makefile-perl.mk
>>> find blib -name 'Makefile*' -exec rm -f {} \;
>>> make check-local
>>> /opt/local/bin/perl -Iblib/lib -I/Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl -I./test/gen-perl \
>>> /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test.pl /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/*.t
>>> /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/memory_buffer....Can't locate Bit/Vector.pm in @INC (@INC contains: blib/lib /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl ./test/gen-perl /opt/local/lib/perl5/site_perl/5.8.9/darwin-2level /opt/local/lib/perl5/site_perl/5.8.9 /opt/local/lib/perl5/site_perl /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level /opt/local/lib/perl5/vendor_perl/5.8.9 /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level /opt/local/lib/perl5/vendor_perl/5.8.9 /opt/local/lib/perl5/vendor_perl /opt/local/lib/perl5/5.8.9/darwin-2level /opt/local/lib/perl5/5.8.9/darwin-2level /opt/local/lib/perl5/5.8.9 . /opt/local/lib/perl5/site_perl/5.8.9/darwin-2level /opt/local/lib/perl5/site_perl/5.8.9 /opt/local/lib/perl5/site_perl /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level /opt/local/lib/perl5/vendor_perl/5.8.9 /opt/local/lib/perl5/vendor_perl /opt/local/lib/perl5/5.8.9/darwin-2level /op
t/
>> local/lib/perl5/5.8.9 .) at blib/lib/Thrift/BinaryProtocol.pm line 31.
>>> BEGIN failed--compilation aborted at blib/lib/Thrift/BinaryProtocol.pm line 31.
>>> Compilation failed in require at /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/memory_buffer.t line 27.
>>> BEGIN failed--compilation aborted at /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/memory_buffer.t line 27.
>>> # Looks like your test died before it could output anything.
>>> /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/memory_buffer....dubious
>>> Test returned status 255 (wstat 65280, 0xff00)
>>> DIED. FAILED tests 1-6
>>> Failed 6/6 tests, 0.00% okay
>>> /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/processor........Can't locate Bit/Vector.pm in @INC (@INC contains: blib/lib /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl ./test/gen-perl /opt/local/lib/perl5/site_perl/5.8.9/darwin-2level /opt/local/lib/perl5/site_perl/5.8.9 /opt/local/lib/perl5/site_perl /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level /opt/local/lib/perl5/vendor_perl/5.8.9 /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level /opt/local/lib/perl5/vendor_perl/5.8.9 /opt/local/lib/perl5/vendor_perl /opt/local/lib/perl5/5.8.9/darwin-2level /opt/local/lib/perl5/5.8.9/darwin-2level /opt/local/lib/perl5/5.8.9 . /opt/local/lib/perl5/site_perl/5.8.9/darwin-2level /opt/local/lib/perl5/site_perl/5.8.9 /opt/local/lib/perl5/site_perl /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level /opt/local/lib/perl5/vendor_perl/5.8.9 /opt/local/lib/perl5/vendor_perl /opt/local/lib/perl5/5.8.9/darwin-2level /op
t/
>> local/lib/perl5/5.8.9 .) at blib/lib/Thrift/BinaryProtocol.pm line 31.
>>> BEGIN failed--compilation aborted at blib/lib/Thrift/BinaryProtocol.pm line 31.
>>> Compilation failed in require at /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/processor.t line 26.
>>> BEGIN failed--compilation aborted at /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/processor.t line 26.
>>> # Looks like your test died before it could output anything.
>>> /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/processor........dubious
>>> Test returned status 255 (wstat 65280, 0xff00)
>>> DIED. FAILED tests 1-2
>>> Failed 2/2 tests, 0.00% okay
>>> Failed Test Stat Wstat Total Fail List of Failed
>>> -------------------------------------------------------------------------------
>>> /Users/rmanbert/Kits/thrift/thrift-0.4.0/ 255 65280 6 12 1-6
>>> /Users/rmanbert/Kits/thrift/thrift-0.4.0/ 255 65280 2 4 1-2
>>> Failed 2/2 test scripts. 8/8 subtests failed.
>>> Files=2, Tests=8, 1 wallclock secs ( 0.05 cusr + 0.02 csys = 0.07 CPU)
>>> Failed 2/2 test programs. 8/8 subtests failed.
>>> make[4]: *** [check-local] Error 255
>>> make[3]: *** [check-am] Error 2
>>> make[2]: *** [check-recursive] Error 1
>>> make[1]: *** [check-recursive] Error 1
>>> make: *** [check-recursive] Error 1
>>>
>>> So I guess it's a -1 from me.
>>>
>>> - Rush
>
Re: [VOTE] Thrift 0.4.0 RC0
Posted by Rush Manbert <ru...@manbert.com>.
If I read it correctly, the effect of this patch is that the configure will fail on stock OSX 10.6.4. (That's what I have - no special Perl modules installed) Is that correct?
I don't use Perl any more, so don't know what you get in a standard Perl installation. If Bit::Vector isn't included, then I would tend to classify this more as a bug in the tests and I wouldn't make the config fail if it's not there. But possibly this is specific to OSX?
- Rush
On Aug 13, 2010, at 3:00 PM, Michael Lum wrote:
> It's complaining about Bit::Vector not being there. I'm not sure if its required by the Thrift library itself, or just the tests, but one way to address it would be this patch, which checks for Bit::Vector at configure time.
>
> --- configure.ac.orig 2010-08-13 14:31:33.000000000 -0700
> +++ configure.ac 2010-08-13 14:58:56.000000000 -0700
> @@ -118,6 +118,9 @@
> AX_THRIFT_LIB(perl, [Perl], yes)
> if test "$with_perl" = "yes"; then
> AC_PATH_PROG([PERL], [perl])
> + if test -n "`$PERL -MBit::Vector -e exit 2>&1`"; then
> + AC_MSG_ERROR([Perl module Bit::Vector not installed])
> + fi
> fi
> AM_CONDITIONAL(WITH_PERL, [test -n "$PERL"])
>
>
>
> On 8/13/2010 1:34 PM, Rush Manbert wrote:
>> On Aug 12, 2010, at 9:40 PM, Bryan Duxbury wrote:
>>
>>> Hi all,
>>>
>>> As discussed, in all the time it took for us to finally release Thrift 0.3,
>>> we've accumulated enough changes for Thrift 0.4!
>>>
>>> I propose we accept
>>> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc0.tar.gz<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz>as
>>> the official Thrift 0.4.0 release.
>>>
>> <snip>
>>
>> I used the tarball on Mac OS X 10.6.4, Xcode 3.2.2, boost 1.42, zlib 1.2.3.
>>
>> configures fine.
>>
>> make completes successfully.
>>
>> make check errors like so:
>> Making check in perl
>> Making check in test
>> make check-local
>> ../../../compiler/cpp/thrift --gen perl ../../../test/ThriftTest.thrift
>> make -f Makefile-perl.mk
>> find blib -name 'Makefile*' -exec rm -f {} \;
>> make check-local
>> /opt/local/bin/perl -Iblib/lib -I/Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl -I./test/gen-perl \
>> /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test.pl /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/*.t
>> /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/memory_buffer....Can't locate Bit/Vector.pm in @INC (@INC contains: blib/lib /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl ./test/gen-perl /opt/local/lib/perl5/site_perl/5.8.9/darwin-2level /opt/local/lib/perl5/site_perl/5.8.9 /opt/local/lib/perl5/site_perl /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level /opt/local/lib/perl5/vendor_perl/5.8.9 /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level /opt/local/lib/perl5/vendor_perl/5.8.9 /opt/local/lib/perl5/vendor_perl /opt/local/lib/perl5/5.8.9/darwin-2level /opt/local/lib/perl5/5.8.9/darwin-2level /opt/local/lib/perl5/5.8.9 . /opt/local/lib/perl5/site_perl/5.8.9/darwin-2level /opt/local/lib/perl5/site_perl/5.8.9 /opt/local/lib/perl5/site_perl /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level /opt/local/lib/perl5/vendor_perl/5.8.9 /opt/local/lib/perl5/vendor_perl /opt/local/lib/perl5/5.8.9/darwin-2level /opt/
> local/lib/perl5/5.8.9 .) at blib/lib/Thrift/BinaryProtocol.pm line 31.
>> BEGIN failed--compilation aborted at blib/lib/Thrift/BinaryProtocol.pm line 31.
>> Compilation failed in require at /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/memory_buffer.t line 27.
>> BEGIN failed--compilation aborted at /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/memory_buffer.t line 27.
>> # Looks like your test died before it could output anything.
>> /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/memory_buffer....dubious
>> Test returned status 255 (wstat 65280, 0xff00)
>> DIED. FAILED tests 1-6
>> Failed 6/6 tests, 0.00% okay
>> /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/processor........Can't locate Bit/Vector.pm in @INC (@INC contains: blib/lib /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl ./test/gen-perl /opt/local/lib/perl5/site_perl/5.8.9/darwin-2level /opt/local/lib/perl5/site_perl/5.8.9 /opt/local/lib/perl5/site_perl /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level /opt/local/lib/perl5/vendor_perl/5.8.9 /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level /opt/local/lib/perl5/vendor_perl/5.8.9 /opt/local/lib/perl5/vendor_perl /opt/local/lib/perl5/5.8.9/darwin-2level /opt/local/lib/perl5/5.8.9/darwin-2level /opt/local/lib/perl5/5.8.9 . /opt/local/lib/perl5/site_perl/5.8.9/darwin-2level /opt/local/lib/perl5/site_perl/5.8.9 /opt/local/lib/perl5/site_perl /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level /opt/local/lib/perl5/vendor_perl/5.8.9 /opt/local/lib/perl5/vendor_perl /opt/local/lib/perl5/5.8.9/darwin-2level /opt/
> local/lib/perl5/5.8.9 .) at blib/lib/Thrift/BinaryProtocol.pm line 31.
>> BEGIN failed--compilation aborted at blib/lib/Thrift/BinaryProtocol.pm line 31.
>> Compilation failed in require at /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/processor.t line 26.
>> BEGIN failed--compilation aborted at /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/processor.t line 26.
>> # Looks like your test died before it could output anything.
>> /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/processor........dubious
>> Test returned status 255 (wstat 65280, 0xff00)
>> DIED. FAILED tests 1-2
>> Failed 2/2 tests, 0.00% okay
>> Failed Test Stat Wstat Total Fail List of Failed
>> -------------------------------------------------------------------------------
>> /Users/rmanbert/Kits/thrift/thrift-0.4.0/ 255 65280 6 12 1-6
>> /Users/rmanbert/Kits/thrift/thrift-0.4.0/ 255 65280 2 4 1-2
>> Failed 2/2 test scripts. 8/8 subtests failed.
>> Files=2, Tests=8, 1 wallclock secs ( 0.05 cusr + 0.02 csys = 0.07 CPU)
>> Failed 2/2 test programs. 8/8 subtests failed.
>> make[4]: *** [check-local] Error 255
>> make[3]: *** [check-am] Error 2
>> make[2]: *** [check-recursive] Error 1
>> make[1]: *** [check-recursive] Error 1
>> make: *** [check-recursive] Error 1
>>
>> So I guess it's a -1 from me.
>>
>> - Rush
Re: [VOTE] Thrift 0.4.0 RC0
Posted by Michael Lum <mi...@openx.org>.
It's complaining about Bit::Vector not being there. I'm not sure if its
required by the Thrift library itself, or just the tests, but one way to
address it would be this patch, which checks for Bit::Vector at
configure time.
--- configure.ac.orig 2010-08-13 14:31:33.000000000 -0700
+++ configure.ac 2010-08-13 14:58:56.000000000 -0700
@@ -118,6 +118,9 @@
AX_THRIFT_LIB(perl, [Perl], yes)
if test "$with_perl" = "yes"; then
AC_PATH_PROG([PERL], [perl])
+ if test -n "`$PERL -MBit::Vector -e exit 2>&1`"; then
+ AC_MSG_ERROR([Perl module Bit::Vector not installed])
+ fi
fi
AM_CONDITIONAL(WITH_PERL, [test -n "$PERL"])
On 8/13/2010 1:34 PM, Rush Manbert wrote:
> On Aug 12, 2010, at 9:40 PM, Bryan Duxbury wrote:
>
>> Hi all,
>>
>> As discussed, in all the time it took for us to finally release Thrift 0.3,
>> we've accumulated enough changes for Thrift 0.4!
>>
>> I propose we accept
>> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc0.tar.gz<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz>as
>> the official Thrift 0.4.0 release.
>>
> <snip>
>
> I used the tarball on Mac OS X 10.6.4, Xcode 3.2.2, boost 1.42, zlib 1.2.3.
>
> configures fine.
>
> make completes successfully.
>
> make check errors like so:
> Making check in perl
> Making check in test
> make check-local
> ../../../compiler/cpp/thrift --gen perl ../../../test/ThriftTest.thrift
> make -f Makefile-perl.mk
> find blib -name 'Makefile*' -exec rm -f {} \;
> make check-local
> /opt/local/bin/perl -Iblib/lib -I/Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl -I./test/gen-perl \
> /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test.pl /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/*.t
> /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/memory_buffer....Can't locate Bit/Vector.pm in @INC (@INC contains: blib/lib /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl ./test/gen-perl /opt/local/lib/perl5/site_perl/5.8.9/darwin-2level /opt/local/lib/perl5/site_perl/5.8.9 /opt/local/lib/perl5/site_perl /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level /opt/local/lib/perl5/vendor_perl/5.8.9 /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level /opt/local/lib/perl5/vendor_perl/5.8.9 /opt/local/lib/perl5/vendor_perl /opt/local/lib/perl5/5.8.9/darwin-2level /opt/local/lib/perl5/5.8.9/darwin-2level /opt/local/lib/perl5/5.8.9 . /opt/local/lib/perl5/site_perl/5.8.9/darwin-2level /opt/local/lib/perl5/site_perl/5.8.9 /opt/local/lib/perl5/site_perl /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level /opt/local/lib/perl5/vendor_perl/5.8.9 /opt/local/lib/perl5/vendor_perl /opt/local/lib/perl5/5.8.9/darwin-2level /opt/
local/lib/perl5/5.8.9 .) at blib/lib/Thrift/BinaryProtocol.pm line 31.
> BEGIN failed--compilation aborted at blib/lib/Thrift/BinaryProtocol.pm line 31.
> Compilation failed in require at /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/memory_buffer.t line 27.
> BEGIN failed--compilation aborted at /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/memory_buffer.t line 27.
> # Looks like your test died before it could output anything.
> /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/memory_buffer....dubious
> Test returned status 255 (wstat 65280, 0xff00)
> DIED. FAILED tests 1-6
> Failed 6/6 tests, 0.00% okay
> /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/processor........Can't locate Bit/Vector.pm in @INC (@INC contains: blib/lib /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl ./test/gen-perl /opt/local/lib/perl5/site_perl/5.8.9/darwin-2level /opt/local/lib/perl5/site_perl/5.8.9 /opt/local/lib/perl5/site_perl /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level /opt/local/lib/perl5/vendor_perl/5.8.9 /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level /opt/local/lib/perl5/vendor_perl/5.8.9 /opt/local/lib/perl5/vendor_perl /opt/local/lib/perl5/5.8.9/darwin-2level /opt/local/lib/perl5/5.8.9/darwin-2level /opt/local/lib/perl5/5.8.9 . /opt/local/lib/perl5/site_perl/5.8.9/darwin-2level /opt/local/lib/perl5/site_perl/5.8.9 /opt/local/lib/perl5/site_perl /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level /opt/local/lib/perl5/vendor_perl/5.8.9 /opt/local/lib/perl5/vendor_perl /opt/local/lib/perl5/5.8.9/darwin-2level /opt/
local/lib/perl5/5.8.9 .) at blib/lib/Thrift/BinaryProtocol.pm line 31.
> BEGIN failed--compilation aborted at blib/lib/Thrift/BinaryProtocol.pm line 31.
> Compilation failed in require at /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/processor.t line 26.
> BEGIN failed--compilation aborted at /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/processor.t line 26.
> # Looks like your test died before it could output anything.
> /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/processor........dubious
> Test returned status 255 (wstat 65280, 0xff00)
> DIED. FAILED tests 1-2
> Failed 2/2 tests, 0.00% okay
> Failed Test Stat Wstat Total Fail List of Failed
> -------------------------------------------------------------------------------
> /Users/rmanbert/Kits/thrift/thrift-0.4.0/ 255 65280 6 12 1-6
> /Users/rmanbert/Kits/thrift/thrift-0.4.0/ 255 65280 2 4 1-2
> Failed 2/2 test scripts. 8/8 subtests failed.
> Files=2, Tests=8, 1 wallclock secs ( 0.05 cusr + 0.02 csys = 0.07 CPU)
> Failed 2/2 test programs. 8/8 subtests failed.
> make[4]: *** [check-local] Error 255
> make[3]: *** [check-am] Error 2
> make[2]: *** [check-recursive] Error 1
> make[1]: *** [check-recursive] Error 1
> make: *** [check-recursive] Error 1
>
> So I guess it's a -1 from me.
>
> - Rush
Re: [VOTE] Thrift 0.4.0 RC0
Posted by Rush Manbert <ru...@manbert.com>.
On Aug 12, 2010, at 9:40 PM, Bryan Duxbury wrote:
> Hi all,
>
> As discussed, in all the time it took for us to finally release Thrift 0.3,
> we've accumulated enough changes for Thrift 0.4!
>
> I propose we accept
> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc0.tar.gz<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz>as
> the official Thrift 0.4.0 release.
>
<snip>
I used the tarball on Mac OS X 10.6.4, Xcode 3.2.2, boost 1.42, zlib 1.2.3.
configures fine.
make completes successfully.
make check errors like so:
Making check in perl
Making check in test
make check-local
../../../compiler/cpp/thrift --gen perl ../../../test/ThriftTest.thrift
make -f Makefile-perl.mk
find blib -name 'Makefile*' -exec rm -f {} \;
make check-local
/opt/local/bin/perl -Iblib/lib -I/Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl -I./test/gen-perl \
/Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test.pl /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/*.t
/Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/memory_buffer....Can't locate Bit/Vector.pm in @INC (@INC contains: blib/lib /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl ./test/gen-perl /opt/local/lib/perl5/site_perl/5.8.9/darwin-2level /opt/local/lib/perl5/site_perl/5.8.9 /opt/local/lib/perl5/site_perl /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level /opt/local/lib/perl5/vendor_perl/5.8.9 /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level /opt/local/lib/perl5/vendor_perl/5.8.9 /opt/local/lib/perl5/vendor_perl /opt/local/lib/perl5/5.8.9/darwin-2level /opt/local/lib/perl5/5.8.9/darwin-2level /opt/local/lib/perl5/5.8.9 . /opt/local/lib/perl5/site_perl/5.8.9/darwin-2level /opt/local/lib/perl5/site_perl/5.8.9 /opt/local/lib/perl5/site_perl /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level /opt/local/lib/perl5/vendor_perl/5.8.9 /opt/local/lib/perl5/vendor_perl /opt/local/lib/perl5/5.8.9/darwin-2level /opt/local/lib/perl5/5.8.9 .) at blib/lib/Thrift/BinaryProtocol.pm line 31.
BEGIN failed--compilation aborted at blib/lib/Thrift/BinaryProtocol.pm line 31.
Compilation failed in require at /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/memory_buffer.t line 27.
BEGIN failed--compilation aborted at /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/memory_buffer.t line 27.
# Looks like your test died before it could output anything.
/Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/memory_buffer....dubious
Test returned status 255 (wstat 65280, 0xff00)
DIED. FAILED tests 1-6
Failed 6/6 tests, 0.00% okay
/Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/processor........Can't locate Bit/Vector.pm in @INC (@INC contains: blib/lib /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl ./test/gen-perl /opt/local/lib/perl5/site_perl/5.8.9/darwin-2level /opt/local/lib/perl5/site_perl/5.8.9 /opt/local/lib/perl5/site_perl /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level /opt/local/lib/perl5/vendor_perl/5.8.9 /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level /opt/local/lib/perl5/vendor_perl/5.8.9 /opt/local/lib/perl5/vendor_perl /opt/local/lib/perl5/5.8.9/darwin-2level /opt/local/lib/perl5/5.8.9/darwin-2level /opt/local/lib/perl5/5.8.9 . /opt/local/lib/perl5/site_perl/5.8.9/darwin-2level /opt/local/lib/perl5/site_perl/5.8.9 /opt/local/lib/perl5/site_perl /opt/local/lib/perl5/vendor_perl/5.8.9/darwin-2level /opt/local/lib/perl5/vendor_perl/5.8.9 /opt/local/lib/perl5/vendor_perl /opt/local/lib/perl5/5.8.9/darwin-2level /opt/local/lib/perl5/5.8.9 .) at blib/lib/Thrift/BinaryProtocol.pm line 31.
BEGIN failed--compilation aborted at blib/lib/Thrift/BinaryProtocol.pm line 31.
Compilation failed in require at /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/processor.t line 26.
BEGIN failed--compilation aborted at /Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/processor.t line 26.
# Looks like your test died before it could output anything.
/Users/rmanbert/Kits/thrift/thrift-0.4.0/lib/perl/test/processor........dubious
Test returned status 255 (wstat 65280, 0xff00)
DIED. FAILED tests 1-2
Failed 2/2 tests, 0.00% okay
Failed Test Stat Wstat Total Fail List of Failed
-------------------------------------------------------------------------------
/Users/rmanbert/Kits/thrift/thrift-0.4.0/ 255 65280 6 12 1-6
/Users/rmanbert/Kits/thrift/thrift-0.4.0/ 255 65280 2 4 1-2
Failed 2/2 test scripts. 8/8 subtests failed.
Files=2, Tests=8, 1 wallclock secs ( 0.05 cusr + 0.02 csys = 0.07 CPU)
Failed 2/2 test programs. 8/8 subtests failed.
make[4]: *** [check-local] Error 255
make[3]: *** [check-am] Error 2
make[2]: *** [check-recursive] Error 1
make[1]: *** [check-recursive] Error 1
make: *** [check-recursive] Error 1
So I guess it's a -1 from me.
- Rush
Re: [VOTE] Thrift 0.4.0 RC0
Posted by Todd Lipcon <to...@cloudera.com>.
On Thu, Aug 26, 2010 at 10:37 PM, Todd Lipcon <to...@cloudera.com> wrote:
> Anyone have any fix for this? Trying to run java unit tests for first time
> in a long time and seeing it as well. ulimit is 1024 here. Sun java 6_20
>
>
Never mind - filed THRIFT-873, will commit when my coworker confirms the
patch fixes it for him too.
-Todd
>
> On Mon, Aug 16, 2010 at 10:14 AM, Anthony Molinaro <
> anthonym@alumni.caltech.edu> wrote:
>
>> Yeah, actually they pass for me as well in Mac with only 256. So I'm
>> thinking
>> it could somehow be vmware, or maybe I have some bad network config, do
>> the tests open a lot of sockets?
>>
>> The java versions are almost identical
>>
>> CentOS
>> % java -version
>> java version "1.6.0_20"
>> Java(TM) SE Runtime Environment (build 1.6.0_20-b02)
>> Java HotSpot(TM) 64-Bit Server VM (build 16.3-b01, mixed mode)
>>
>> MacOSX
>> % java -version
>> java version "1.6.0_20"
>> Java(TM) SE Runtime Environment (build 1.6.0_20-b02-279-10M3065)
>> Java HotSpot(TM) 64-Bit Server VM (build 16.3-b01-279, mixed mode)
>>
>> So I'm thinking it must either be some sort of networking configuration,
>> or some sort of vmware specific problem.
>>
>> Either way, looks like it might be an environment not a software problem.
>>
>> -Anthony
>>
>> On Mon, Aug 16, 2010 at 07:20:21AM -0700, Bryan Duxbury wrote:
>> > The Java unit tests *do* run in a single VM, so there is a chance that
>> if
>> > things are leaked you could have later tests contaminated. I made this
>> > change to the test suite so that the tests would execute very quickly.
>> >
>> > By all signs, the ulimit on my Mac is 256, but my tests pass.
>> >
>> > On Sun, Aug 15, 2010 at 11:20 PM, Anthony Molinaro <
>> > anthonym@alumni.caltech.edu> wrote:
>> >
>> > > Okay, so I got it to pass the tests. I started playing with the
>> number
>> > > of threads in the async test since that was the first that failed, and
>> > > that works, but seemed odd. 100 works fine, 400 works fine, 490
>> causes
>> > > a test several past the async test to fail.
>> > >
>> > > This makes me think somehow junit is running everything in the same
>> > > java vm, and it's somehow leaking some file descriptors with my
>> version
>> > > of java (or maybe in thrift lib, hard to say).
>> > >
>> > > Since the problem was open file descriptors, I checked and my ulimit
>> > > was 1024, so with 500 threads in the async test, if for some reason
>> > > some of the tests open a bunch of network connections or something,
>> > > and fail to close them you could run out of file descriptors and
>> things
>> > > would start failing.
>> > >
>> > > So I upped my limit to 65535 and now the tests pass. So not sure if
>> > > this warrants a ticket or not, it could be an issue with file
>> descriptors
>> > > leaking somewhere, it could maybe be a problem with the version of
>> > > java I'm running (although we've been running cassandra and our own
>> > > high throughput, high traffic webserver with it, without issue,
>> although
>> > > not on vmware which is the 'machine' I'm running on).
>> > >
>> > > Bryan, what is your file descriptor limit set to?
>> > >
>> > > Anyway, still want a ticket?
>> > >
>> > > -Anthony
>> > >
>> > >
>> > > On Sun, Aug 15, 2010 at 02:19:14PM -0700, Bryan Duxbury wrote:
>> > > > On my local machine, the java library tests cleanly. The errors in
>> your
>> > > > build output seem to be related to available file handles, which
>> should
>> > > > never be an issue. I'm not sure this is a real bug or not, but could
>> you
>> > > > please open a ticket for us to investigate?
>> > > >
>> > > > On Sat, Aug 14, 2010 at 1:37 PM, Anthony Molinaro <
>> > > > anthonym@alumni.caltech.edu> wrote:
>> > > >
>> > > > > -1 from me, make check fails on Centos 5.3 because of java
>> failures
>> > > > >
>> > > > > % java -version
>> > > > > java version "1.6.0_20"
>> > > > > Java(TM) SE Runtime Environment (build 1.6.0_20-b02)
>> > > > > Java HotSpot(TM) 64-Bit Server VM (build 16.3-b01, mixed mode)
>> > > > >
>> > > > > Build/check output attached
>> > > > >
>> > > > > -Anthony
>> > > > >
>> > > > > --
>> > > > >
>> > >
>> ------------------------------------------------------------------------
>> > > > > Anthony Molinaro <
>> > > anthonym@alumni.caltech.edu>
>> > > > >
>> > >
>> > > --
>> > >
>> ------------------------------------------------------------------------
>> > > Anthony Molinaro <
>> anthonym@alumni.caltech.edu>
>> > >
>>
>> --
>> ------------------------------------------------------------------------
>> Anthony Molinaro <an...@alumni.caltech.edu>
>>
>
>
>
> --
> Todd Lipcon
> Software Engineer, Cloudera
>
--
Todd Lipcon
Software Engineer, Cloudera
Re: [VOTE] Thrift 0.4.0 RC0
Posted by Todd Lipcon <to...@cloudera.com>.
Anyone have any fix for this? Trying to run java unit tests for first time
in a long time and seeing it as well. ulimit is 1024 here. Sun java 6_20
-Todd
On Mon, Aug 16, 2010 at 10:14 AM, Anthony Molinaro <
anthonym@alumni.caltech.edu> wrote:
> Yeah, actually they pass for me as well in Mac with only 256. So I'm
> thinking
> it could somehow be vmware, or maybe I have some bad network config, do
> the tests open a lot of sockets?
>
> The java versions are almost identical
>
> CentOS
> % java -version
> java version "1.6.0_20"
> Java(TM) SE Runtime Environment (build 1.6.0_20-b02)
> Java HotSpot(TM) 64-Bit Server VM (build 16.3-b01, mixed mode)
>
> MacOSX
> % java -version
> java version "1.6.0_20"
> Java(TM) SE Runtime Environment (build 1.6.0_20-b02-279-10M3065)
> Java HotSpot(TM) 64-Bit Server VM (build 16.3-b01-279, mixed mode)
>
> So I'm thinking it must either be some sort of networking configuration,
> or some sort of vmware specific problem.
>
> Either way, looks like it might be an environment not a software problem.
>
> -Anthony
>
> On Mon, Aug 16, 2010 at 07:20:21AM -0700, Bryan Duxbury wrote:
> > The Java unit tests *do* run in a single VM, so there is a chance that if
> > things are leaked you could have later tests contaminated. I made this
> > change to the test suite so that the tests would execute very quickly.
> >
> > By all signs, the ulimit on my Mac is 256, but my tests pass.
> >
> > On Sun, Aug 15, 2010 at 11:20 PM, Anthony Molinaro <
> > anthonym@alumni.caltech.edu> wrote:
> >
> > > Okay, so I got it to pass the tests. I started playing with the number
> > > of threads in the async test since that was the first that failed, and
> > > that works, but seemed odd. 100 works fine, 400 works fine, 490 causes
> > > a test several past the async test to fail.
> > >
> > > This makes me think somehow junit is running everything in the same
> > > java vm, and it's somehow leaking some file descriptors with my version
> > > of java (or maybe in thrift lib, hard to say).
> > >
> > > Since the problem was open file descriptors, I checked and my ulimit
> > > was 1024, so with 500 threads in the async test, if for some reason
> > > some of the tests open a bunch of network connections or something,
> > > and fail to close them you could run out of file descriptors and things
> > > would start failing.
> > >
> > > So I upped my limit to 65535 and now the tests pass. So not sure if
> > > this warrants a ticket or not, it could be an issue with file
> descriptors
> > > leaking somewhere, it could maybe be a problem with the version of
> > > java I'm running (although we've been running cassandra and our own
> > > high throughput, high traffic webserver with it, without issue,
> although
> > > not on vmware which is the 'machine' I'm running on).
> > >
> > > Bryan, what is your file descriptor limit set to?
> > >
> > > Anyway, still want a ticket?
> > >
> > > -Anthony
> > >
> > >
> > > On Sun, Aug 15, 2010 at 02:19:14PM -0700, Bryan Duxbury wrote:
> > > > On my local machine, the java library tests cleanly. The errors in
> your
> > > > build output seem to be related to available file handles, which
> should
> > > > never be an issue. I'm not sure this is a real bug or not, but could
> you
> > > > please open a ticket for us to investigate?
> > > >
> > > > On Sat, Aug 14, 2010 at 1:37 PM, Anthony Molinaro <
> > > > anthonym@alumni.caltech.edu> wrote:
> > > >
> > > > > -1 from me, make check fails on Centos 5.3 because of java failures
> > > > >
> > > > > % java -version
> > > > > java version "1.6.0_20"
> > > > > Java(TM) SE Runtime Environment (build 1.6.0_20-b02)
> > > > > Java HotSpot(TM) 64-Bit Server VM (build 16.3-b01, mixed mode)
> > > > >
> > > > > Build/check output attached
> > > > >
> > > > > -Anthony
> > > > >
> > > > > --
> > > > >
> > >
> ------------------------------------------------------------------------
> > > > > Anthony Molinaro <
> > > anthonym@alumni.caltech.edu>
> > > > >
> > >
> > > --
> > >
> ------------------------------------------------------------------------
> > > Anthony Molinaro <
> anthonym@alumni.caltech.edu>
> > >
>
> --
> ------------------------------------------------------------------------
> Anthony Molinaro <an...@alumni.caltech.edu>
>
--
Todd Lipcon
Software Engineer, Cloudera
Re: [VOTE] Thrift 0.4.0 RC0
Posted by Bryan Duxbury <br...@rapleaf.com>.
I'm going to -1 this tarball myself due to issues with the PHP extension
building. I'll post another RC momentarily.
On Mon, Aug 16, 2010 at 10:14 AM, Anthony Molinaro <
anthonym@alumni.caltech.edu> wrote:
> Yeah, actually they pass for me as well in Mac with only 256. So I'm
> thinking
> it could somehow be vmware, or maybe I have some bad network config, do
> the tests open a lot of sockets?
>
> The java versions are almost identical
>
> CentOS
> % java -version
> java version "1.6.0_20"
> Java(TM) SE Runtime Environment (build 1.6.0_20-b02)
> Java HotSpot(TM) 64-Bit Server VM (build 16.3-b01, mixed mode)
>
> MacOSX
> % java -version
> java version "1.6.0_20"
> Java(TM) SE Runtime Environment (build 1.6.0_20-b02-279-10M3065)
> Java HotSpot(TM) 64-Bit Server VM (build 16.3-b01-279, mixed mode)
>
> So I'm thinking it must either be some sort of networking configuration,
> or some sort of vmware specific problem.
>
> Either way, looks like it might be an environment not a software problem.
>
> -Anthony
>
> On Mon, Aug 16, 2010 at 07:20:21AM -0700, Bryan Duxbury wrote:
> > The Java unit tests *do* run in a single VM, so there is a chance that if
> > things are leaked you could have later tests contaminated. I made this
> > change to the test suite so that the tests would execute very quickly.
> >
> > By all signs, the ulimit on my Mac is 256, but my tests pass.
> >
> > On Sun, Aug 15, 2010 at 11:20 PM, Anthony Molinaro <
> > anthonym@alumni.caltech.edu> wrote:
> >
> > > Okay, so I got it to pass the tests. I started playing with the number
> > > of threads in the async test since that was the first that failed, and
> > > that works, but seemed odd. 100 works fine, 400 works fine, 490 causes
> > > a test several past the async test to fail.
> > >
> > > This makes me think somehow junit is running everything in the same
> > > java vm, and it's somehow leaking some file descriptors with my version
> > > of java (or maybe in thrift lib, hard to say).
> > >
> > > Since the problem was open file descriptors, I checked and my ulimit
> > > was 1024, so with 500 threads in the async test, if for some reason
> > > some of the tests open a bunch of network connections or something,
> > > and fail to close them you could run out of file descriptors and things
> > > would start failing.
> > >
> > > So I upped my limit to 65535 and now the tests pass. So not sure if
> > > this warrants a ticket or not, it could be an issue with file
> descriptors
> > > leaking somewhere, it could maybe be a problem with the version of
> > > java I'm running (although we've been running cassandra and our own
> > > high throughput, high traffic webserver with it, without issue,
> although
> > > not on vmware which is the 'machine' I'm running on).
> > >
> > > Bryan, what is your file descriptor limit set to?
> > >
> > > Anyway, still want a ticket?
> > >
> > > -Anthony
> > >
> > >
> > > On Sun, Aug 15, 2010 at 02:19:14PM -0700, Bryan Duxbury wrote:
> > > > On my local machine, the java library tests cleanly. The errors in
> your
> > > > build output seem to be related to available file handles, which
> should
> > > > never be an issue. I'm not sure this is a real bug or not, but could
> you
> > > > please open a ticket for us to investigate?
> > > >
> > > > On Sat, Aug 14, 2010 at 1:37 PM, Anthony Molinaro <
> > > > anthonym@alumni.caltech.edu> wrote:
> > > >
> > > > > -1 from me, make check fails on Centos 5.3 because of java failures
> > > > >
> > > > > % java -version
> > > > > java version "1.6.0_20"
> > > > > Java(TM) SE Runtime Environment (build 1.6.0_20-b02)
> > > > > Java HotSpot(TM) 64-Bit Server VM (build 16.3-b01, mixed mode)
> > > > >
> > > > > Build/check output attached
> > > > >
> > > > > -Anthony
> > > > >
> > > > > --
> > > > >
> > >
> ------------------------------------------------------------------------
> > > > > Anthony Molinaro <
> > > anthonym@alumni.caltech.edu>
> > > > >
> > >
> > > --
> > >
> ------------------------------------------------------------------------
> > > Anthony Molinaro <
> anthonym@alumni.caltech.edu>
> > >
>
> --
> ------------------------------------------------------------------------
> Anthony Molinaro <an...@alumni.caltech.edu>
>
Re: [VOTE] Thrift 0.4.0 RC0
Posted by Anthony Molinaro <an...@alumni.caltech.edu>.
Yeah, actually they pass for me as well in Mac with only 256. So I'm thinking
it could somehow be vmware, or maybe I have some bad network config, do
the tests open a lot of sockets?
The java versions are almost identical
CentOS
% java -version
java version "1.6.0_20"
Java(TM) SE Runtime Environment (build 1.6.0_20-b02)
Java HotSpot(TM) 64-Bit Server VM (build 16.3-b01, mixed mode)
MacOSX
% java -version
java version "1.6.0_20"
Java(TM) SE Runtime Environment (build 1.6.0_20-b02-279-10M3065)
Java HotSpot(TM) 64-Bit Server VM (build 16.3-b01-279, mixed mode)
So I'm thinking it must either be some sort of networking configuration,
or some sort of vmware specific problem.
Either way, looks like it might be an environment not a software problem.
-Anthony
On Mon, Aug 16, 2010 at 07:20:21AM -0700, Bryan Duxbury wrote:
> The Java unit tests *do* run in a single VM, so there is a chance that if
> things are leaked you could have later tests contaminated. I made this
> change to the test suite so that the tests would execute very quickly.
>
> By all signs, the ulimit on my Mac is 256, but my tests pass.
>
> On Sun, Aug 15, 2010 at 11:20 PM, Anthony Molinaro <
> anthonym@alumni.caltech.edu> wrote:
>
> > Okay, so I got it to pass the tests. I started playing with the number
> > of threads in the async test since that was the first that failed, and
> > that works, but seemed odd. 100 works fine, 400 works fine, 490 causes
> > a test several past the async test to fail.
> >
> > This makes me think somehow junit is running everything in the same
> > java vm, and it's somehow leaking some file descriptors with my version
> > of java (or maybe in thrift lib, hard to say).
> >
> > Since the problem was open file descriptors, I checked and my ulimit
> > was 1024, so with 500 threads in the async test, if for some reason
> > some of the tests open a bunch of network connections or something,
> > and fail to close them you could run out of file descriptors and things
> > would start failing.
> >
> > So I upped my limit to 65535 and now the tests pass. So not sure if
> > this warrants a ticket or not, it could be an issue with file descriptors
> > leaking somewhere, it could maybe be a problem with the version of
> > java I'm running (although we've been running cassandra and our own
> > high throughput, high traffic webserver with it, without issue, although
> > not on vmware which is the 'machine' I'm running on).
> >
> > Bryan, what is your file descriptor limit set to?
> >
> > Anyway, still want a ticket?
> >
> > -Anthony
> >
> >
> > On Sun, Aug 15, 2010 at 02:19:14PM -0700, Bryan Duxbury wrote:
> > > On my local machine, the java library tests cleanly. The errors in your
> > > build output seem to be related to available file handles, which should
> > > never be an issue. I'm not sure this is a real bug or not, but could you
> > > please open a ticket for us to investigate?
> > >
> > > On Sat, Aug 14, 2010 at 1:37 PM, Anthony Molinaro <
> > > anthonym@alumni.caltech.edu> wrote:
> > >
> > > > -1 from me, make check fails on Centos 5.3 because of java failures
> > > >
> > > > % java -version
> > > > java version "1.6.0_20"
> > > > Java(TM) SE Runtime Environment (build 1.6.0_20-b02)
> > > > Java HotSpot(TM) 64-Bit Server VM (build 16.3-b01, mixed mode)
> > > >
> > > > Build/check output attached
> > > >
> > > > -Anthony
> > > >
> > > > --
> > > >
> > ------------------------------------------------------------------------
> > > > Anthony Molinaro <
> > anthonym@alumni.caltech.edu>
> > > >
> >
> > --
> > ------------------------------------------------------------------------
> > Anthony Molinaro <an...@alumni.caltech.edu>
> >
--
------------------------------------------------------------------------
Anthony Molinaro <an...@alumni.caltech.edu>
Re: [VOTE] Thrift 0.4.0 RC0
Posted by Bryan Duxbury <br...@rapleaf.com>.
The Java unit tests *do* run in a single VM, so there is a chance that if
things are leaked you could have later tests contaminated. I made this
change to the test suite so that the tests would execute very quickly.
By all signs, the ulimit on my Mac is 256, but my tests pass.
On Sun, Aug 15, 2010 at 11:20 PM, Anthony Molinaro <
anthonym@alumni.caltech.edu> wrote:
> Okay, so I got it to pass the tests. I started playing with the number
> of threads in the async test since that was the first that failed, and
> that works, but seemed odd. 100 works fine, 400 works fine, 490 causes
> a test several past the async test to fail.
>
> This makes me think somehow junit is running everything in the same
> java vm, and it's somehow leaking some file descriptors with my version
> of java (or maybe in thrift lib, hard to say).
>
> Since the problem was open file descriptors, I checked and my ulimit
> was 1024, so with 500 threads in the async test, if for some reason
> some of the tests open a bunch of network connections or something,
> and fail to close them you could run out of file descriptors and things
> would start failing.
>
> So I upped my limit to 65535 and now the tests pass. So not sure if
> this warrants a ticket or not, it could be an issue with file descriptors
> leaking somewhere, it could maybe be a problem with the version of
> java I'm running (although we've been running cassandra and our own
> high throughput, high traffic webserver with it, without issue, although
> not on vmware which is the 'machine' I'm running on).
>
> Bryan, what is your file descriptor limit set to?
>
> Anyway, still want a ticket?
>
> -Anthony
>
>
> On Sun, Aug 15, 2010 at 02:19:14PM -0700, Bryan Duxbury wrote:
> > On my local machine, the java library tests cleanly. The errors in your
> > build output seem to be related to available file handles, which should
> > never be an issue. I'm not sure this is a real bug or not, but could you
> > please open a ticket for us to investigate?
> >
> > On Sat, Aug 14, 2010 at 1:37 PM, Anthony Molinaro <
> > anthonym@alumni.caltech.edu> wrote:
> >
> > > -1 from me, make check fails on Centos 5.3 because of java failures
> > >
> > > % java -version
> > > java version "1.6.0_20"
> > > Java(TM) SE Runtime Environment (build 1.6.0_20-b02)
> > > Java HotSpot(TM) 64-Bit Server VM (build 16.3-b01, mixed mode)
> > >
> > > Build/check output attached
> > >
> > > -Anthony
> > >
> > > --
> > >
> ------------------------------------------------------------------------
> > > Anthony Molinaro <
> anthonym@alumni.caltech.edu>
> > >
>
> --
> ------------------------------------------------------------------------
> Anthony Molinaro <an...@alumni.caltech.edu>
>
Re: [VOTE] Thrift 0.4.0 RC0
Posted by Anthony Molinaro <an...@alumni.caltech.edu>.
Okay, so I got it to pass the tests. I started playing with the number
of threads in the async test since that was the first that failed, and
that works, but seemed odd. 100 works fine, 400 works fine, 490 causes
a test several past the async test to fail.
This makes me think somehow junit is running everything in the same
java vm, and it's somehow leaking some file descriptors with my version
of java (or maybe in thrift lib, hard to say).
Since the problem was open file descriptors, I checked and my ulimit
was 1024, so with 500 threads in the async test, if for some reason
some of the tests open a bunch of network connections or something,
and fail to close them you could run out of file descriptors and things
would start failing.
So I upped my limit to 65535 and now the tests pass. So not sure if
this warrants a ticket or not, it could be an issue with file descriptors
leaking somewhere, it could maybe be a problem with the version of
java I'm running (although we've been running cassandra and our own
high throughput, high traffic webserver with it, without issue, although
not on vmware which is the 'machine' I'm running on).
Bryan, what is your file descriptor limit set to?
Anyway, still want a ticket?
-Anthony
On Sun, Aug 15, 2010 at 02:19:14PM -0700, Bryan Duxbury wrote:
> On my local machine, the java library tests cleanly. The errors in your
> build output seem to be related to available file handles, which should
> never be an issue. I'm not sure this is a real bug or not, but could you
> please open a ticket for us to investigate?
>
> On Sat, Aug 14, 2010 at 1:37 PM, Anthony Molinaro <
> anthonym@alumni.caltech.edu> wrote:
>
> > -1 from me, make check fails on Centos 5.3 because of java failures
> >
> > % java -version
> > java version "1.6.0_20"
> > Java(TM) SE Runtime Environment (build 1.6.0_20-b02)
> > Java HotSpot(TM) 64-Bit Server VM (build 16.3-b01, mixed mode)
> >
> > Build/check output attached
> >
> > -Anthony
> >
> > --
> > ------------------------------------------------------------------------
> > Anthony Molinaro <an...@alumni.caltech.edu>
> >
--
------------------------------------------------------------------------
Anthony Molinaro <an...@alumni.caltech.edu>
Re: [VOTE] Thrift 0.4.0 RC0
Posted by Bryan Duxbury <br...@rapleaf.com>.
On my local machine, the java library tests cleanly. The errors in your
build output seem to be related to available file handles, which should
never be an issue. I'm not sure this is a real bug or not, but could you
please open a ticket for us to investigate?
On Sat, Aug 14, 2010 at 1:37 PM, Anthony Molinaro <
anthonym@alumni.caltech.edu> wrote:
> -1 from me, make check fails on Centos 5.3 because of java failures
>
> % java -version
> java version "1.6.0_20"
> Java(TM) SE Runtime Environment (build 1.6.0_20-b02)
> Java HotSpot(TM) 64-Bit Server VM (build 16.3-b01, mixed mode)
>
> Build/check output attached
>
> -Anthony
>
> --
> ------------------------------------------------------------------------
> Anthony Molinaro <an...@alumni.caltech.edu>
>
Re: [VOTE] Thrift 0.4.0 RC0
Posted by Anthony Molinaro <an...@alumni.caltech.edu>.
-1 from me, make check fails on Centos 5.3 because of java failures
% java -version
java version "1.6.0_20"
Java(TM) SE Runtime Environment (build 1.6.0_20-b02)
Java HotSpot(TM) 64-Bit Server VM (build 16.3-b01, mixed mode)
Build/check output attached
-Anthony
--
------------------------------------------------------------------------
Anthony Molinaro <an...@alumni.caltech.edu>
Re: [VOTE] Thrift 0.4.0 RC0
Posted by Joe Schaefer <jo...@yahoo.com>.
----- Original Message ----
> From: Joe Schaefer <jo...@yahoo.com>
> To: thrift-dev@incubator.apache.org
> Sent: Sat, August 14, 2010 3:45:40 PM
> Subject: Re: [VOTE] Thrift 0.4.0 RC0
>
> % ~/src/apache/committers/tools/releases/compare_dirs.pl 0.4.x thrift-0.4.0 \
> .gitignore ._CHANGES ._configure.ac Makefile.in aclocal.m4 config.guess \
> config.h config.hin config.sub configure depcomp install-sh ltmain.sh \
> missing ylwrap rat_exclude thrift-0.4.0/compiler/cpp/thriftl.cc \
> thrift-0.4.0/compiler/cpp/thrifty.cc \
> thrift-0.4.0/compiler/cpp/thrifty.h 0.4.x/compiler/py \
> 0.4.x/compiler/src Makefile ._Rakefile client.sh
> No differences detected.
> %
>
>
> The above compares the branch (0.4.x) against the tarball (thrift-0.4.0).
> The result looks fine, so I'm +1 for release pending the commit to trunk
> for the NOTICE file.
And here is my sig which may be appended to the detached signature file
for the release:
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
iD8DBQBMZvPQsxshPSCPUGQRApDCAJ9xSwVUMygUT61I3Cb/R07X6zA43ACdGM/1
n0++BLISy5CpkyF+jvJqujw=
=kTXa
-----END PGP SIGNATURE-----
Re: [VOTE] Thrift 0.4.0 RC0
Posted by Joe Schaefer <jo...@yahoo.com>.
% ~/src/apache/committers/tools/releases/compare_dirs.pl 0.4.x thrift-0.4.0 \
.gitignore ._CHANGES ._configure.ac Makefile.in aclocal.m4 config.guess \
config.h config.hin config.sub configure depcomp install-sh ltmain.sh \
missing ylwrap rat_exclude thrift-0.4.0/compiler/cpp/thriftl.cc \
thrift-0.4.0/compiler/cpp/thrifty.cc \
thrift-0.4.0/compiler/cpp/thrifty.h 0.4.x/compiler/py \
0.4.x/compiler/src Makefile ._Rakefile client.sh
No differences detected.
%
The above compares the branch (0.4.x) against the tarball (thrift-0.4.0).
The result looks fine, so I'm +1 for release pending the commit to trunk
for the NOTICE file.
Re: [VOTE] Thrift 0.4.0 RC0
Posted by James Clarke <cl...@gmail.com>.
I cannot get this to build on Mac OS X 10.6.4. It appears the cpp library
is failing.
boost @1.43.0_0
zlib @1.2.5_0
libevent @1.4.14b_0
Here is where it fails.
Making all in cpp
/bin/sh ../../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I.
-I../.. -I/opt/local/include -I./src -Wall -g -O2 -MT Thrift.lo -MD -MP
-MF .deps/Thrift.Tpo -c -o Thrift.lo `test -f 'src/Thrift.cpp' || echo
'./'`src/Thrift.cpp
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I../.. -I/opt/local/include
-I./src -Wall -g -O2 -MT Thrift.lo -MD -MP -MF .deps/Thrift.Tpo -c
src/Thrift.cpp -fno-common -DPIC -o .libs/Thrift.o
src/Thrift.cpp: In member function 'void
apache::thrift::TOutput::printf(const char*, ...)':
src/Thrift.cpp:45: error: 'malloc' was not declared in this scope
src/Thrift.cpp:59: error: 'free' was not declared in this scope
make[3]: *** [Thrift.lo] Error 1
make[2]: *** [all-recursive] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2
However, it built fine on my CentOS machine.
On Thu, Aug 12, 2010 at 23:40, Bryan Duxbury <br...@rapleaf.com> wrote:
> Hi all,
>
> As discussed, in all the time it took for us to finally release Thrift 0.3,
> we've accumulated enough changes for Thrift 0.4!
>
> I propose we accept
> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc0.tar.gz<
> http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz>as
> the official Thrift 0.4.0 release.
>
> I created this tarball by checking out URL:
> https://svn.apache.org/repos/asf/incubator/thrift/branches/0.4.x and
> running
> "./bootstrap.sh && ./configure && make dist".
>
> The GPG signature for this tarball can be found at
> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc0.tar.gz.asc<
> http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz.asc>.
> It has an MD5 signature of c272591c1b3560fdef86104e2be214dc.
>
> Please download, verify the signatures, untar, and install and test the
> libraries you are familiar with. We need your +1 votes to make the release!
> If you encounter any problems, please let me know immediately. This vote
> will close 72 hours from now.
>
> This release consists of 45 tickets that cover many bugs and performance
> improvements. Please refer to the CHANGES file for the full list.
>
> -Bryan
>
Re: [VOTE] Thrift 0.4.0 RC0
Posted by Michael Lum <mi...@openx.org>.
On 8/13/2010 1:28 PM, George Godik wrote:
> Hi Everyone
>
> Anybody else having issues with the configure script ?
>
> I break on
>
> ./configure: line 20618: syntax error near unexpected token `thrift,'
> ./configure: line 20618: ` AC_ERLANG_SUBST_INSTALL_LIB_SUBDIR(thrift,
> 0.4.0)'
This happens on systems using autoconf 2.59 that are bootstrapping the
thrift build. Installing autoconf 2.61 or greater will fix it. Some
macro trickery could get it to work on 2.59.
>
>
> On Fri, Aug 13, 2010 at 4:14 PM, Mark Slee<ms...@facebook.com> wrote:
>
>> +1 from me. Looks sane.
>>
>> -----Original Message-----
>> From: David Reiss [mailto:dreiss@facebook.com]
>> Sent: Friday, August 13, 2010 8:19 AM
>> To: thrift-dev@incubator.apache.org
>> Subject: Re: [VOTE] Thrift 0.4.0 RC0
>>
>> +1
>>
>> There are a few "._BLAH" files in there that would be nice to remove, but
>> not critical.
>>
>> As an aside...
>>
>> Does anyone use configure and make to build the ruby stuff? If not, can we
>> just
>> delete Ruby support from the configure script? It's gotten in my way
>> several
>> times when working on the build, and I don't know enough about Ruby to fix
>> it.
>>
>> --David
>>
>> On 08/13/2010 07:30 AM, Bryan Duxbury wrote:
>>> I certainly do intend to maintain the rubygem. I'm not sure that I have
>> the
>>> necessary credentials to publish the gem to rubyforge, though. You can
>> build
>>> the gem by doing "cd lib/rb&& rake package".
>>>
>>> On Fri, Aug 13, 2010 at 4:36 AM, Rajesh Malepati<ch...@gmail.com>
>> wrote:
>>>
>>>> +1
>>>>
>>>> My ruby client/server tests pass. I had to regenerate the ruby classes
>>>> though. The 0.2 generated ones are incompatible with 0.4.
>>>>
>>>> One small question. Evan Weaver used to release ruby library as a gem.
>>>> That didn't happen for 0.3.
>>>>
>>>> See http://rubygems.org/gems/thrift and
>> http://github.com/fauna/thrift-rb
>>>> I also see Kevin Ballard, Kevin Clark and Mark Slee as authors on the
>>>> rubygems.org page. Is there any interest in maintaining the gem
>>>> version?
>>>>
>>>> On Fri, Aug 13, 2010 at 12:27 PM, Michael Lum<mi...@openx.org>
>>>> wrote:
>>>>> Works fine on CentOS 5.5. On Snow Leopard, make check was returning
>>>> this:
>>>>>
>>>>> libtool: link: g++ -g -O2 -o .libs/UnitTests UnitTests-UnitTestMain.o
>>>>> UnitTests-TMemoryBufferTest.o UnitTests-TBufferBaseTest.o
>>>> -Wl,-bind_at_load
>>>>> ./.libs/libtestgencpp.a
>>>>> /Users/mlum/temp/0.4.x/thrift-0.4.0/lib/cpp/.libs/libthrift.dylib
>>>>> -lboost_unit_test_framework -lpthread
>>>>> ld: library not found for -lboost_unit_test_framework
>>>>> collect2: ld returned 1 exit status
>>>>> make[2]: *** [UnitTests] Error 1
>>>>> make[1]: *** [check-am] Error 2
>>>>> make: *** [check-recursive] Error 1
>>>>>
>>>>> I have boost-1.42.0 installed using MacPorts in /opt/local. Changing
>> the
>>>>> Makefile.am to add $(BOOST_LDFLAGS) to UnitTests_LDADD causes this test
>>>> to
>>>>> pass. All other tests passed.
>>>>>
>>>>> --- test/Makefile.am.orig 2010-08-12 23:29:21.000000000 -0700
>>>>> +++ test/Makefile.am 2010-08-12 23:34:28.000000000 -0700
>>>>> @@ -68,7 +68,7 @@
>>>>> TMemoryBufferTest.cpp \
>>>>> TBufferBaseTest.cpp
>>>>>
>>>>> -UnitTests_LDADD = libtestgencpp.la -lboost_unit_test_framework
>>>>> +UnitTests_LDADD = libtestgencpp.la $(BOOST_LDFLAGS)
>>>>> -lboost_unit_test_framework
>>>>>
>>>>> #
>>>>> # TFDTransportTest
>>>>>
>>>>> Otherwise, +1.
>>>>>
>>>>> On 8/12/2010 9:40 PM, Bryan Duxbury wrote:
>>>>>>
>>>>>> Hi all,
>>>>>>
>>>>>> As discussed, in all the time it took for us to finally release Thrift
>>>>>> 0.3,
>>>>>> we've accumulated enough changes for Thrift 0.4!
>>>>>>
>>>>>> I propose we accept
>>>>>>
>>>>>> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc0.tar.gz<
>> http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz>
>>>> <http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz>as
>>>>>> the official Thrift 0.4.0 release.
>>>>>>
>>>>>> I created this tarball by checking out URL:
>>>>>> https://svn.apache.org/repos/asf/incubator/thrift/branches/0.4.x and
>>>>>> running
>>>>>> "./bootstrap.sh&& ./configure&& make dist".
>>>>>>
>>>>>> The GPG signature for this tarball can be found at
>>>>>>
>>>>>> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc0.tar.gz.asc<
>> http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz.asc>
>>>> <http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz.asc>.
>>>>>> It has an MD5 signature of c272591c1b3560fdef86104e2be214dc.
>>>>>>
>>>>>> Please download, verify the signatures, untar, and install and test
>> the
>>>>>> libraries you are familiar with. We need your +1 votes to make the
>>>>>> release!
>>>>>> If you encounter any problems, please let me know immediately. This
>> vote
>>>>>> will close 72 hours from now.
>>>>>>
>>>>>> This release consists of 45 tickets that cover many bugs and
>> performance
>>>>>> improvements. Please refer to the CHANGES file for the full list.
>>>>>>
>>>>>> -Bryan
>>>>>>
>>>>>
>>>>
>>>
>>
>
Re: [VOTE] Thrift 0.4.0 RC0
Posted by George Godik <gg...@gmail.com>.
David - I assume you're addressing me and not Rush
It seems I did run bootstrap.sh - clean dir helped
Thanks
On Fri, Aug 13, 2010 at 4:44 PM, David Reiss <dr...@facebook.com> wrote:
> did you re-run ./bootstrap.sh? You aren't supposed to do that for release
> tarballs.
>
> On 08/13/2010 01:30 PM, George Godik wrote:
> > Sorry, some details
> >
> > Running
> >
> > GNU bash, version 3.2.25(1)-release (x86_64-redhat-linux-gnu)
> > Copyright (C) 2005 Free Software Foundation, Inc.
> >
> > on
> >
> > Red Hat Enterprise Linux Server release 5.3 (Tikanga)
> >
> > On Fri, Aug 13, 2010 at 4:28 PM, George Godik <gg...@gmail.com> wrote:
> >
> >> Hi Everyone
> >>
> >> Anybody else having issues with the configure script ?
> >>
> >> I break on
> >>
> >> ./configure: line 20618: syntax error near unexpected token `thrift,'
> >> ./configure: line 20618: ` AC_ERLANG_SUBST_INSTALL_LIB_SUBDIR(thrift,
> >> 0.4.0)'
> >>
> >>
> >> On Fri, Aug 13, 2010 at 4:14 PM, Mark Slee <ms...@facebook.com> wrote:
> >>
> >>> +1 from me. Looks sane.
> >>>
> >>> -----Original Message-----
> >>> From: David Reiss [mailto:dreiss@facebook.com]
> >>> Sent: Friday, August 13, 2010 8:19 AM
> >>> To: thrift-dev@incubator.apache.org
> >>> Subject: Re: [VOTE] Thrift 0.4.0 RC0
> >>>
> >>> +1
> >>>
> >>> There are a few "._BLAH" files in there that would be nice to remove,
> but
> >>> not critical.
> >>>
> >>> As an aside...
> >>>
> >>> Does anyone use configure and make to build the ruby stuff? If not,
> can
> >>> we just
> >>> delete Ruby support from the configure script? It's gotten in my way
> >>> several
> >>> times when working on the build, and I don't know enough about Ruby to
> fix
> >>> it.
> >>>
> >>> --David
> >>>
> >>> On 08/13/2010 07:30 AM, Bryan Duxbury wrote:
> >>>> I certainly do intend to maintain the rubygem. I'm not sure that I
> have
> >>> the
> >>>> necessary credentials to publish the gem to rubyforge, though. You can
> >>> build
> >>>> the gem by doing "cd lib/rb && rake package".
> >>>>
> >>>> On Fri, Aug 13, 2010 at 4:36 AM, Rajesh Malepati <ch...@gmail.com>
> >>> wrote:
> >>>>
> >>>>> +1
> >>>>>
> >>>>> My ruby client/server tests pass. I had to regenerate the ruby
> classes
> >>>>> though. The 0.2 generated ones are incompatible with 0.4.
> >>>>>
> >>>>> One small question. Evan Weaver used to release ruby library as a
> gem.
> >>>>> That didn't happen for 0.3.
> >>>>>
> >>>>> See http://rubygems.org/gems/thrift and
> >>> http://github.com/fauna/thrift-rb
> >>>>> I also see Kevin Ballard, Kevin Clark and Mark Slee as authors on the
> >>>>> rubygems.org page. Is there any interest in maintaining the gem
> >>>>> version?
> >>>>>
> >>>>> On Fri, Aug 13, 2010 at 12:27 PM, Michael Lum <michael.lum@openx.org
> >
> >>>>> wrote:
> >>>>>> Works fine on CentOS 5.5. On Snow Leopard, make check was returning
> >>>>> this:
> >>>>>>
> >>>>>> libtool: link: g++ -g -O2 -o .libs/UnitTests
> UnitTests-UnitTestMain.o
> >>>>>> UnitTests-TMemoryBufferTest.o UnitTests-TBufferBaseTest.o
> >>>>> -Wl,-bind_at_load
> >>>>>> ./.libs/libtestgencpp.a
> >>>>>> /Users/mlum/temp/0.4.x/thrift-0.4.0/lib/cpp/.libs/libthrift.dylib
> >>>>>> -lboost_unit_test_framework -lpthread
> >>>>>> ld: library not found for -lboost_unit_test_framework
> >>>>>> collect2: ld returned 1 exit status
> >>>>>> make[2]: *** [UnitTests] Error 1
> >>>>>> make[1]: *** [check-am] Error 2
> >>>>>> make: *** [check-recursive] Error 1
> >>>>>>
> >>>>>> I have boost-1.42.0 installed using MacPorts in /opt/local.
> Changing
> >>> the
> >>>>>> Makefile.am to add $(BOOST_LDFLAGS) to UnitTests_LDADD causes this
> >>> test
> >>>>> to
> >>>>>> pass. All other tests passed.
> >>>>>>
> >>>>>> --- test/Makefile.am.orig 2010-08-12 23:29:21.000000000 -0700
> >>>>>> +++ test/Makefile.am 2010-08-12 23:34:28.000000000 -0700
> >>>>>> @@ -68,7 +68,7 @@
> >>>>>> TMemoryBufferTest.cpp \
> >>>>>> TBufferBaseTest.cpp
> >>>>>>
> >>>>>> -UnitTests_LDADD = libtestgencpp.la -lboost_unit_test_framework
> >>>>>> +UnitTests_LDADD = libtestgencpp.la $(BOOST_LDFLAGS)
> >>>>>> -lboost_unit_test_framework
> >>>>>>
> >>>>>> #
> >>>>>> # TFDTransportTest
> >>>>>>
> >>>>>> Otherwise, +1.
> >>>>>>
> >>>>>> On 8/12/2010 9:40 PM, Bryan Duxbury wrote:
> >>>>>>>
> >>>>>>> Hi all,
> >>>>>>>
> >>>>>>> As discussed, in all the time it took for us to finally release
> >>> Thrift
> >>>>>>> 0.3,
> >>>>>>> we've accumulated enough changes for Thrift 0.4!
> >>>>>>>
> >>>>>>> I propose we accept
> >>>>>>>
> >>>>>>> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc0.tar.gz<
> >>> http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz>
> >>>>> <http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz>as
> >>>>>>> the official Thrift 0.4.0 release.
> >>>>>>>
> >>>>>>> I created this tarball by checking out URL:
> >>>>>>> https://svn.apache.org/repos/asf/incubator/thrift/branches/0.4.xand
> >>>>>>> running
> >>>>>>> "./bootstrap.sh&& ./configure&& make dist".
> >>>>>>>
> >>>>>>> The GPG signature for this tarball can be found at
> >>>>>>>
> >>>>>>> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc0.tar.gz.asc
> <
> >>> http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz.asc>
> >>>>> <
> http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz.asc
> >>>> .
> >>>>>>> It has an MD5 signature of c272591c1b3560fdef86104e2be214dc.
> >>>>>>>
> >>>>>>> Please download, verify the signatures, untar, and install and test
> >>> the
> >>>>>>> libraries you are familiar with. We need your +1 votes to make the
> >>>>>>> release!
> >>>>>>> If you encounter any problems, please let me know immediately. This
> >>> vote
> >>>>>>> will close 72 hours from now.
> >>>>>>>
> >>>>>>> This release consists of 45 tickets that cover many bugs and
> >>> performance
> >>>>>>> improvements. Please refer to the CHANGES file for the full list.
> >>>>>>>
> >>>>>>> -Bryan
> >>>>>>>
> >>>>>>
> >>>>>
> >>>>
> >>>
> >>
> >>
> >
>
Re: [VOTE] Thrift 0.4.0 RC0
Posted by David Reiss <dr...@facebook.com>.
did you re-run ./bootstrap.sh? You aren't supposed to do that for release tarballs.
On 08/13/2010 01:30 PM, George Godik wrote:
> Sorry, some details
>
> Running
>
> GNU bash, version 3.2.25(1)-release (x86_64-redhat-linux-gnu)
> Copyright (C) 2005 Free Software Foundation, Inc.
>
> on
>
> Red Hat Enterprise Linux Server release 5.3 (Tikanga)
>
> On Fri, Aug 13, 2010 at 4:28 PM, George Godik <gg...@gmail.com> wrote:
>
>> Hi Everyone
>>
>> Anybody else having issues with the configure script ?
>>
>> I break on
>>
>> ./configure: line 20618: syntax error near unexpected token `thrift,'
>> ./configure: line 20618: ` AC_ERLANG_SUBST_INSTALL_LIB_SUBDIR(thrift,
>> 0.4.0)'
>>
>>
>> On Fri, Aug 13, 2010 at 4:14 PM, Mark Slee <ms...@facebook.com> wrote:
>>
>>> +1 from me. Looks sane.
>>>
>>> -----Original Message-----
>>> From: David Reiss [mailto:dreiss@facebook.com]
>>> Sent: Friday, August 13, 2010 8:19 AM
>>> To: thrift-dev@incubator.apache.org
>>> Subject: Re: [VOTE] Thrift 0.4.0 RC0
>>>
>>> +1
>>>
>>> There are a few "._BLAH" files in there that would be nice to remove, but
>>> not critical.
>>>
>>> As an aside...
>>>
>>> Does anyone use configure and make to build the ruby stuff? If not, can
>>> we just
>>> delete Ruby support from the configure script? It's gotten in my way
>>> several
>>> times when working on the build, and I don't know enough about Ruby to fix
>>> it.
>>>
>>> --David
>>>
>>> On 08/13/2010 07:30 AM, Bryan Duxbury wrote:
>>>> I certainly do intend to maintain the rubygem. I'm not sure that I have
>>> the
>>>> necessary credentials to publish the gem to rubyforge, though. You can
>>> build
>>>> the gem by doing "cd lib/rb && rake package".
>>>>
>>>> On Fri, Aug 13, 2010 at 4:36 AM, Rajesh Malepati <ch...@gmail.com>
>>> wrote:
>>>>
>>>>> +1
>>>>>
>>>>> My ruby client/server tests pass. I had to regenerate the ruby classes
>>>>> though. The 0.2 generated ones are incompatible with 0.4.
>>>>>
>>>>> One small question. Evan Weaver used to release ruby library as a gem.
>>>>> That didn't happen for 0.3.
>>>>>
>>>>> See http://rubygems.org/gems/thrift and
>>> http://github.com/fauna/thrift-rb
>>>>> I also see Kevin Ballard, Kevin Clark and Mark Slee as authors on the
>>>>> rubygems.org page. Is there any interest in maintaining the gem
>>>>> version?
>>>>>
>>>>> On Fri, Aug 13, 2010 at 12:27 PM, Michael Lum <mi...@openx.org>
>>>>> wrote:
>>>>>> Works fine on CentOS 5.5. On Snow Leopard, make check was returning
>>>>> this:
>>>>>>
>>>>>> libtool: link: g++ -g -O2 -o .libs/UnitTests UnitTests-UnitTestMain.o
>>>>>> UnitTests-TMemoryBufferTest.o UnitTests-TBufferBaseTest.o
>>>>> -Wl,-bind_at_load
>>>>>> ./.libs/libtestgencpp.a
>>>>>> /Users/mlum/temp/0.4.x/thrift-0.4.0/lib/cpp/.libs/libthrift.dylib
>>>>>> -lboost_unit_test_framework -lpthread
>>>>>> ld: library not found for -lboost_unit_test_framework
>>>>>> collect2: ld returned 1 exit status
>>>>>> make[2]: *** [UnitTests] Error 1
>>>>>> make[1]: *** [check-am] Error 2
>>>>>> make: *** [check-recursive] Error 1
>>>>>>
>>>>>> I have boost-1.42.0 installed using MacPorts in /opt/local. Changing
>>> the
>>>>>> Makefile.am to add $(BOOST_LDFLAGS) to UnitTests_LDADD causes this
>>> test
>>>>> to
>>>>>> pass. All other tests passed.
>>>>>>
>>>>>> --- test/Makefile.am.orig 2010-08-12 23:29:21.000000000 -0700
>>>>>> +++ test/Makefile.am 2010-08-12 23:34:28.000000000 -0700
>>>>>> @@ -68,7 +68,7 @@
>>>>>> TMemoryBufferTest.cpp \
>>>>>> TBufferBaseTest.cpp
>>>>>>
>>>>>> -UnitTests_LDADD = libtestgencpp.la -lboost_unit_test_framework
>>>>>> +UnitTests_LDADD = libtestgencpp.la $(BOOST_LDFLAGS)
>>>>>> -lboost_unit_test_framework
>>>>>>
>>>>>> #
>>>>>> # TFDTransportTest
>>>>>>
>>>>>> Otherwise, +1.
>>>>>>
>>>>>> On 8/12/2010 9:40 PM, Bryan Duxbury wrote:
>>>>>>>
>>>>>>> Hi all,
>>>>>>>
>>>>>>> As discussed, in all the time it took for us to finally release
>>> Thrift
>>>>>>> 0.3,
>>>>>>> we've accumulated enough changes for Thrift 0.4!
>>>>>>>
>>>>>>> I propose we accept
>>>>>>>
>>>>>>> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc0.tar.gz<
>>> http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz>
>>>>> <http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz>as
>>>>>>> the official Thrift 0.4.0 release.
>>>>>>>
>>>>>>> I created this tarball by checking out URL:
>>>>>>> https://svn.apache.org/repos/asf/incubator/thrift/branches/0.4.x and
>>>>>>> running
>>>>>>> "./bootstrap.sh&& ./configure&& make dist".
>>>>>>>
>>>>>>> The GPG signature for this tarball can be found at
>>>>>>>
>>>>>>> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc0.tar.gz.asc<
>>> http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz.asc>
>>>>> <http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz.asc
>>>> .
>>>>>>> It has an MD5 signature of c272591c1b3560fdef86104e2be214dc.
>>>>>>>
>>>>>>> Please download, verify the signatures, untar, and install and test
>>> the
>>>>>>> libraries you are familiar with. We need your +1 votes to make the
>>>>>>> release!
>>>>>>> If you encounter any problems, please let me know immediately. This
>>> vote
>>>>>>> will close 72 hours from now.
>>>>>>>
>>>>>>> This release consists of 45 tickets that cover many bugs and
>>> performance
>>>>>>> improvements. Please refer to the CHANGES file for the full list.
>>>>>>>
>>>>>>> -Bryan
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>>
>
Re: [VOTE] Thrift 0.4.0 RC0
Posted by George Godik <gg...@gmail.com>.
Sorry, some details
Running
GNU bash, version 3.2.25(1)-release (x86_64-redhat-linux-gnu)
Copyright (C) 2005 Free Software Foundation, Inc.
on
Red Hat Enterprise Linux Server release 5.3 (Tikanga)
On Fri, Aug 13, 2010 at 4:28 PM, George Godik <gg...@gmail.com> wrote:
> Hi Everyone
>
> Anybody else having issues with the configure script ?
>
> I break on
>
> ./configure: line 20618: syntax error near unexpected token `thrift,'
> ./configure: line 20618: ` AC_ERLANG_SUBST_INSTALL_LIB_SUBDIR(thrift,
> 0.4.0)'
>
>
> On Fri, Aug 13, 2010 at 4:14 PM, Mark Slee <ms...@facebook.com> wrote:
>
>> +1 from me. Looks sane.
>>
>> -----Original Message-----
>> From: David Reiss [mailto:dreiss@facebook.com]
>> Sent: Friday, August 13, 2010 8:19 AM
>> To: thrift-dev@incubator.apache.org
>> Subject: Re: [VOTE] Thrift 0.4.0 RC0
>>
>> +1
>>
>> There are a few "._BLAH" files in there that would be nice to remove, but
>> not critical.
>>
>> As an aside...
>>
>> Does anyone use configure and make to build the ruby stuff? If not, can
>> we just
>> delete Ruby support from the configure script? It's gotten in my way
>> several
>> times when working on the build, and I don't know enough about Ruby to fix
>> it.
>>
>> --David
>>
>> On 08/13/2010 07:30 AM, Bryan Duxbury wrote:
>> > I certainly do intend to maintain the rubygem. I'm not sure that I have
>> the
>> > necessary credentials to publish the gem to rubyforge, though. You can
>> build
>> > the gem by doing "cd lib/rb && rake package".
>> >
>> > On Fri, Aug 13, 2010 at 4:36 AM, Rajesh Malepati <ch...@gmail.com>
>> wrote:
>> >
>> >> +1
>> >>
>> >> My ruby client/server tests pass. I had to regenerate the ruby classes
>> >> though. The 0.2 generated ones are incompatible with 0.4.
>> >>
>> >> One small question. Evan Weaver used to release ruby library as a gem.
>> >> That didn't happen for 0.3.
>> >>
>> >> See http://rubygems.org/gems/thrift and
>> http://github.com/fauna/thrift-rb
>> >> I also see Kevin Ballard, Kevin Clark and Mark Slee as authors on the
>> >> rubygems.org page. Is there any interest in maintaining the gem
>> >> version?
>> >>
>> >> On Fri, Aug 13, 2010 at 12:27 PM, Michael Lum <mi...@openx.org>
>> >> wrote:
>> >>> Works fine on CentOS 5.5. On Snow Leopard, make check was returning
>> >> this:
>> >>>
>> >>> libtool: link: g++ -g -O2 -o .libs/UnitTests UnitTests-UnitTestMain.o
>> >>> UnitTests-TMemoryBufferTest.o UnitTests-TBufferBaseTest.o
>> >> -Wl,-bind_at_load
>> >>> ./.libs/libtestgencpp.a
>> >>> /Users/mlum/temp/0.4.x/thrift-0.4.0/lib/cpp/.libs/libthrift.dylib
>> >>> -lboost_unit_test_framework -lpthread
>> >>> ld: library not found for -lboost_unit_test_framework
>> >>> collect2: ld returned 1 exit status
>> >>> make[2]: *** [UnitTests] Error 1
>> >>> make[1]: *** [check-am] Error 2
>> >>> make: *** [check-recursive] Error 1
>> >>>
>> >>> I have boost-1.42.0 installed using MacPorts in /opt/local. Changing
>> the
>> >>> Makefile.am to add $(BOOST_LDFLAGS) to UnitTests_LDADD causes this
>> test
>> >> to
>> >>> pass. All other tests passed.
>> >>>
>> >>> --- test/Makefile.am.orig 2010-08-12 23:29:21.000000000 -0700
>> >>> +++ test/Makefile.am 2010-08-12 23:34:28.000000000 -0700
>> >>> @@ -68,7 +68,7 @@
>> >>> TMemoryBufferTest.cpp \
>> >>> TBufferBaseTest.cpp
>> >>>
>> >>> -UnitTests_LDADD = libtestgencpp.la -lboost_unit_test_framework
>> >>> +UnitTests_LDADD = libtestgencpp.la $(BOOST_LDFLAGS)
>> >>> -lboost_unit_test_framework
>> >>>
>> >>> #
>> >>> # TFDTransportTest
>> >>>
>> >>> Otherwise, +1.
>> >>>
>> >>> On 8/12/2010 9:40 PM, Bryan Duxbury wrote:
>> >>>>
>> >>>> Hi all,
>> >>>>
>> >>>> As discussed, in all the time it took for us to finally release
>> Thrift
>> >>>> 0.3,
>> >>>> we've accumulated enough changes for Thrift 0.4!
>> >>>>
>> >>>> I propose we accept
>> >>>>
>> >>>> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc0.tar.gz<
>> http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz>
>> >> <http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz>as
>> >>>> the official Thrift 0.4.0 release.
>> >>>>
>> >>>> I created this tarball by checking out URL:
>> >>>> https://svn.apache.org/repos/asf/incubator/thrift/branches/0.4.x and
>> >>>> running
>> >>>> "./bootstrap.sh&& ./configure&& make dist".
>> >>>>
>> >>>> The GPG signature for this tarball can be found at
>> >>>>
>> >>>> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc0.tar.gz.asc<
>> http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz.asc>
>> >> <http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz.asc
>> >.
>> >>>> It has an MD5 signature of c272591c1b3560fdef86104e2be214dc.
>> >>>>
>> >>>> Please download, verify the signatures, untar, and install and test
>> the
>> >>>> libraries you are familiar with. We need your +1 votes to make the
>> >>>> release!
>> >>>> If you encounter any problems, please let me know immediately. This
>> vote
>> >>>> will close 72 hours from now.
>> >>>>
>> >>>> This release consists of 45 tickets that cover many bugs and
>> performance
>> >>>> improvements. Please refer to the CHANGES file for the full list.
>> >>>>
>> >>>> -Bryan
>> >>>>
>> >>>
>> >>
>> >
>>
>
>
Re: [VOTE] Thrift 0.4.0 RC0
Posted by George Godik <gg...@gmail.com>.
Hi Everyone
Anybody else having issues with the configure script ?
I break on
./configure: line 20618: syntax error near unexpected token `thrift,'
./configure: line 20618: ` AC_ERLANG_SUBST_INSTALL_LIB_SUBDIR(thrift,
0.4.0)'
On Fri, Aug 13, 2010 at 4:14 PM, Mark Slee <ms...@facebook.com> wrote:
> +1 from me. Looks sane.
>
> -----Original Message-----
> From: David Reiss [mailto:dreiss@facebook.com]
> Sent: Friday, August 13, 2010 8:19 AM
> To: thrift-dev@incubator.apache.org
> Subject: Re: [VOTE] Thrift 0.4.0 RC0
>
> +1
>
> There are a few "._BLAH" files in there that would be nice to remove, but
> not critical.
>
> As an aside...
>
> Does anyone use configure and make to build the ruby stuff? If not, can we
> just
> delete Ruby support from the configure script? It's gotten in my way
> several
> times when working on the build, and I don't know enough about Ruby to fix
> it.
>
> --David
>
> On 08/13/2010 07:30 AM, Bryan Duxbury wrote:
> > I certainly do intend to maintain the rubygem. I'm not sure that I have
> the
> > necessary credentials to publish the gem to rubyforge, though. You can
> build
> > the gem by doing "cd lib/rb && rake package".
> >
> > On Fri, Aug 13, 2010 at 4:36 AM, Rajesh Malepati <ch...@gmail.com>
> wrote:
> >
> >> +1
> >>
> >> My ruby client/server tests pass. I had to regenerate the ruby classes
> >> though. The 0.2 generated ones are incompatible with 0.4.
> >>
> >> One small question. Evan Weaver used to release ruby library as a gem.
> >> That didn't happen for 0.3.
> >>
> >> See http://rubygems.org/gems/thrift and
> http://github.com/fauna/thrift-rb
> >> I also see Kevin Ballard, Kevin Clark and Mark Slee as authors on the
> >> rubygems.org page. Is there any interest in maintaining the gem
> >> version?
> >>
> >> On Fri, Aug 13, 2010 at 12:27 PM, Michael Lum <mi...@openx.org>
> >> wrote:
> >>> Works fine on CentOS 5.5. On Snow Leopard, make check was returning
> >> this:
> >>>
> >>> libtool: link: g++ -g -O2 -o .libs/UnitTests UnitTests-UnitTestMain.o
> >>> UnitTests-TMemoryBufferTest.o UnitTests-TBufferBaseTest.o
> >> -Wl,-bind_at_load
> >>> ./.libs/libtestgencpp.a
> >>> /Users/mlum/temp/0.4.x/thrift-0.4.0/lib/cpp/.libs/libthrift.dylib
> >>> -lboost_unit_test_framework -lpthread
> >>> ld: library not found for -lboost_unit_test_framework
> >>> collect2: ld returned 1 exit status
> >>> make[2]: *** [UnitTests] Error 1
> >>> make[1]: *** [check-am] Error 2
> >>> make: *** [check-recursive] Error 1
> >>>
> >>> I have boost-1.42.0 installed using MacPorts in /opt/local. Changing
> the
> >>> Makefile.am to add $(BOOST_LDFLAGS) to UnitTests_LDADD causes this test
> >> to
> >>> pass. All other tests passed.
> >>>
> >>> --- test/Makefile.am.orig 2010-08-12 23:29:21.000000000 -0700
> >>> +++ test/Makefile.am 2010-08-12 23:34:28.000000000 -0700
> >>> @@ -68,7 +68,7 @@
> >>> TMemoryBufferTest.cpp \
> >>> TBufferBaseTest.cpp
> >>>
> >>> -UnitTests_LDADD = libtestgencpp.la -lboost_unit_test_framework
> >>> +UnitTests_LDADD = libtestgencpp.la $(BOOST_LDFLAGS)
> >>> -lboost_unit_test_framework
> >>>
> >>> #
> >>> # TFDTransportTest
> >>>
> >>> Otherwise, +1.
> >>>
> >>> On 8/12/2010 9:40 PM, Bryan Duxbury wrote:
> >>>>
> >>>> Hi all,
> >>>>
> >>>> As discussed, in all the time it took for us to finally release Thrift
> >>>> 0.3,
> >>>> we've accumulated enough changes for Thrift 0.4!
> >>>>
> >>>> I propose we accept
> >>>>
> >>>> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc0.tar.gz<
> http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz>
> >> <http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz>as
> >>>> the official Thrift 0.4.0 release.
> >>>>
> >>>> I created this tarball by checking out URL:
> >>>> https://svn.apache.org/repos/asf/incubator/thrift/branches/0.4.x and
> >>>> running
> >>>> "./bootstrap.sh&& ./configure&& make dist".
> >>>>
> >>>> The GPG signature for this tarball can be found at
> >>>>
> >>>> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc0.tar.gz.asc<
> http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz.asc>
> >> <http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz.asc>.
> >>>> It has an MD5 signature of c272591c1b3560fdef86104e2be214dc.
> >>>>
> >>>> Please download, verify the signatures, untar, and install and test
> the
> >>>> libraries you are familiar with. We need your +1 votes to make the
> >>>> release!
> >>>> If you encounter any problems, please let me know immediately. This
> vote
> >>>> will close 72 hours from now.
> >>>>
> >>>> This release consists of 45 tickets that cover many bugs and
> performance
> >>>> improvements. Please refer to the CHANGES file for the full list.
> >>>>
> >>>> -Bryan
> >>>>
> >>>
> >>
> >
>
RE: [VOTE] Thrift 0.4.0 RC0
Posted by Mark Slee <ms...@facebook.com>.
+1 from me. Looks sane.
-----Original Message-----
From: David Reiss [mailto:dreiss@facebook.com]
Sent: Friday, August 13, 2010 8:19 AM
To: thrift-dev@incubator.apache.org
Subject: Re: [VOTE] Thrift 0.4.0 RC0
+1
There are a few "._BLAH" files in there that would be nice to remove, but not critical.
As an aside...
Does anyone use configure and make to build the ruby stuff? If not, can we just
delete Ruby support from the configure script? It's gotten in my way several
times when working on the build, and I don't know enough about Ruby to fix it.
--David
On 08/13/2010 07:30 AM, Bryan Duxbury wrote:
> I certainly do intend to maintain the rubygem. I'm not sure that I have the
> necessary credentials to publish the gem to rubyforge, though. You can build
> the gem by doing "cd lib/rb && rake package".
>
> On Fri, Aug 13, 2010 at 4:36 AM, Rajesh Malepati <ch...@gmail.com> wrote:
>
>> +1
>>
>> My ruby client/server tests pass. I had to regenerate the ruby classes
>> though. The 0.2 generated ones are incompatible with 0.4.
>>
>> One small question. Evan Weaver used to release ruby library as a gem.
>> That didn't happen for 0.3.
>>
>> See http://rubygems.org/gems/thrift and http://github.com/fauna/thrift-rb
>> I also see Kevin Ballard, Kevin Clark and Mark Slee as authors on the
>> rubygems.org page. Is there any interest in maintaining the gem
>> version?
>>
>> On Fri, Aug 13, 2010 at 12:27 PM, Michael Lum <mi...@openx.org>
>> wrote:
>>> Works fine on CentOS 5.5. On Snow Leopard, make check was returning
>> this:
>>>
>>> libtool: link: g++ -g -O2 -o .libs/UnitTests UnitTests-UnitTestMain.o
>>> UnitTests-TMemoryBufferTest.o UnitTests-TBufferBaseTest.o
>> -Wl,-bind_at_load
>>> ./.libs/libtestgencpp.a
>>> /Users/mlum/temp/0.4.x/thrift-0.4.0/lib/cpp/.libs/libthrift.dylib
>>> -lboost_unit_test_framework -lpthread
>>> ld: library not found for -lboost_unit_test_framework
>>> collect2: ld returned 1 exit status
>>> make[2]: *** [UnitTests] Error 1
>>> make[1]: *** [check-am] Error 2
>>> make: *** [check-recursive] Error 1
>>>
>>> I have boost-1.42.0 installed using MacPorts in /opt/local. Changing the
>>> Makefile.am to add $(BOOST_LDFLAGS) to UnitTests_LDADD causes this test
>> to
>>> pass. All other tests passed.
>>>
>>> --- test/Makefile.am.orig 2010-08-12 23:29:21.000000000 -0700
>>> +++ test/Makefile.am 2010-08-12 23:34:28.000000000 -0700
>>> @@ -68,7 +68,7 @@
>>> TMemoryBufferTest.cpp \
>>> TBufferBaseTest.cpp
>>>
>>> -UnitTests_LDADD = libtestgencpp.la -lboost_unit_test_framework
>>> +UnitTests_LDADD = libtestgencpp.la $(BOOST_LDFLAGS)
>>> -lboost_unit_test_framework
>>>
>>> #
>>> # TFDTransportTest
>>>
>>> Otherwise, +1.
>>>
>>> On 8/12/2010 9:40 PM, Bryan Duxbury wrote:
>>>>
>>>> Hi all,
>>>>
>>>> As discussed, in all the time it took for us to finally release Thrift
>>>> 0.3,
>>>> we've accumulated enough changes for Thrift 0.4!
>>>>
>>>> I propose we accept
>>>>
>>>> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc0.tar.gz<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz>
>> <http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz>as
>>>> the official Thrift 0.4.0 release.
>>>>
>>>> I created this tarball by checking out URL:
>>>> https://svn.apache.org/repos/asf/incubator/thrift/branches/0.4.x and
>>>> running
>>>> "./bootstrap.sh&& ./configure&& make dist".
>>>>
>>>> The GPG signature for this tarball can be found at
>>>>
>>>> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc0.tar.gz.asc<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz.asc>
>> <http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz.asc>.
>>>> It has an MD5 signature of c272591c1b3560fdef86104e2be214dc.
>>>>
>>>> Please download, verify the signatures, untar, and install and test the
>>>> libraries you are familiar with. We need your +1 votes to make the
>>>> release!
>>>> If you encounter any problems, please let me know immediately. This vote
>>>> will close 72 hours from now.
>>>>
>>>> This release consists of 45 tickets that cover many bugs and performance
>>>> improvements. Please refer to the CHANGES file for the full list.
>>>>
>>>> -Bryan
>>>>
>>>
>>
>
Re: [VOTE] Thrift 0.4.0 RC0
Posted by Bryan Duxbury <br...@rapleaf.com>.
On Fri, Aug 13, 2010 at 8:34 AM, Kevin Clark <ke...@gmail.com> wrote:
> Bryan - I can probably give you appropriate credentials, though it'd
> have to wait til I'm back in civilization (start of September).
>
Sounds good.
Re: [VOTE] Thrift 0.4.0 RC0
Posted by Kevin Clark <ke...@gmail.com>.
We used to do it at Powerset. If you're installing thrift for 4
languages it's nice to use the same technique for the 5th. Though I
don't recall if the Ruby make target was changed to just generate the
gem these days, in which case it probably doesn't matter.
Bryan - I can probably give you appropriate credentials, though it'd
have to wait til I'm back in civilization (start of September).
On Fri, Aug 13, 2010 at 8:18 AM, David Reiss <dr...@facebook.com> wrote:
> +1
>
> There are a few "._BLAH" files in there that would be nice to remove, but not critical.
>
> As an aside...
>
> Does anyone use configure and make to build the ruby stuff? If not, can we just
> delete Ruby support from the configure script? It's gotten in my way several
> times when working on the build, and I don't know enough about Ruby to fix it.
>
> --David
>
> On 08/13/2010 07:30 AM, Bryan Duxbury wrote:
>> I certainly do intend to maintain the rubygem. I'm not sure that I have the
>> necessary credentials to publish the gem to rubyforge, though. You can build
>> the gem by doing "cd lib/rb && rake package".
>>
>> On Fri, Aug 13, 2010 at 4:36 AM, Rajesh Malepati <ch...@gmail.com> wrote:
>>
>>> +1
>>>
>>> My ruby client/server tests pass. I had to regenerate the ruby classes
>>> though. The 0.2 generated ones are incompatible with 0.4.
>>>
>>> One small question. Evan Weaver used to release ruby library as a gem.
>>> That didn't happen for 0.3.
>>>
>>> See http://rubygems.org/gems/thrift and http://github.com/fauna/thrift-rb
>>> I also see Kevin Ballard, Kevin Clark and Mark Slee as authors on the
>>> rubygems.org page. Is there any interest in maintaining the gem
>>> version?
>>>
>>> On Fri, Aug 13, 2010 at 12:27 PM, Michael Lum <mi...@openx.org>
>>> wrote:
>>>> Works fine on CentOS 5.5. On Snow Leopard, make check was returning
>>> this:
>>>>
>>>> libtool: link: g++ -g -O2 -o .libs/UnitTests UnitTests-UnitTestMain.o
>>>> UnitTests-TMemoryBufferTest.o UnitTests-TBufferBaseTest.o
>>> -Wl,-bind_at_load
>>>> ./.libs/libtestgencpp.a
>>>> /Users/mlum/temp/0.4.x/thrift-0.4.0/lib/cpp/.libs/libthrift.dylib
>>>> -lboost_unit_test_framework -lpthread
>>>> ld: library not found for -lboost_unit_test_framework
>>>> collect2: ld returned 1 exit status
>>>> make[2]: *** [UnitTests] Error 1
>>>> make[1]: *** [check-am] Error 2
>>>> make: *** [check-recursive] Error 1
>>>>
>>>> I have boost-1.42.0 installed using MacPorts in /opt/local. Changing the
>>>> Makefile.am to add $(BOOST_LDFLAGS) to UnitTests_LDADD causes this test
>>> to
>>>> pass. All other tests passed.
>>>>
>>>> --- test/Makefile.am.orig 2010-08-12 23:29:21.000000000 -0700
>>>> +++ test/Makefile.am 2010-08-12 23:34:28.000000000 -0700
>>>> @@ -68,7 +68,7 @@
>>>> TMemoryBufferTest.cpp \
>>>> TBufferBaseTest.cpp
>>>>
>>>> -UnitTests_LDADD = libtestgencpp.la -lboost_unit_test_framework
>>>> +UnitTests_LDADD = libtestgencpp.la $(BOOST_LDFLAGS)
>>>> -lboost_unit_test_framework
>>>>
>>>> #
>>>> # TFDTransportTest
>>>>
>>>> Otherwise, +1.
>>>>
>>>> On 8/12/2010 9:40 PM, Bryan Duxbury wrote:
>>>>>
>>>>> Hi all,
>>>>>
>>>>> As discussed, in all the time it took for us to finally release Thrift
>>>>> 0.3,
>>>>> we've accumulated enough changes for Thrift 0.4!
>>>>>
>>>>> I propose we accept
>>>>>
>>>>> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc0.tar.gz<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz>
>>> <http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz>as
>>>>> the official Thrift 0.4.0 release.
>>>>>
>>>>> I created this tarball by checking out URL:
>>>>> https://svn.apache.org/repos/asf/incubator/thrift/branches/0.4.x and
>>>>> running
>>>>> "./bootstrap.sh&& ./configure&& make dist".
>>>>>
>>>>> The GPG signature for this tarball can be found at
>>>>>
>>>>> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc0.tar.gz.asc<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz.asc>
>>> <http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz.asc>.
>>>>> It has an MD5 signature of c272591c1b3560fdef86104e2be214dc.
>>>>>
>>>>> Please download, verify the signatures, untar, and install and test the
>>>>> libraries you are familiar with. We need your +1 votes to make the
>>>>> release!
>>>>> If you encounter any problems, please let me know immediately. This vote
>>>>> will close 72 hours from now.
>>>>>
>>>>> This release consists of 45 tickets that cover many bugs and performance
>>>>> improvements. Please refer to the CHANGES file for the full list.
>>>>>
>>>>> -Bryan
>>>>>
>>>>
>>>
>>
>
--
Kevin Clark
http://glu.ttono.us
Re: [VOTE] Thrift 0.4.0 RC0
Posted by Anthony Molinaro <an...@alumni.caltech.edu>.
On Fri, Aug 13, 2010 at 09:15:50AM -0700, Bryan Duxbury wrote:
> On Fri, Aug 13, 2010 at 8:18 AM, David Reiss <dr...@facebook.com> wrote:
> > As an aside...
> >
> > Does anyone use configure and make to build the ruby stuff? If not, can we
> > just
> > delete Ruby support from the configure script? It's gotten in my way
> > several
> > times when working on the build, and I don't know enough about Ruby to fix
> > it.
> >
>
> I personally would be OK with this change, since I've never once used it. I
> agree that there's an argument to be made for consistency, though. I'd like
> to hear some more opinions.
The main issue I've had with the ruby stuff is it doesn't respect DESTDIR
so is pretty much impossible to package using standard rpm/deb tools, so
I usually disable it. Thus I'd be fine with removing it unless someone
more up on the ruby tech could get DESTDIR to work, then I'd be okay with
it staying.
You can easily reproduce the problem if someone is interested in attempting
a fix.
1. download an instant build
2. % ./configure
3. % make
4. % mkdir tmp
5. % make DESTDIR=`pwd`/tmp install
You'll get this
gmake[3]: Entering directory `/home/molinaro/thrift-instant-r985088/lib/rb'
gmake install-exec-hook
gmake[4]: Entering directory `/home/molinaro/thrift-instant-r985088/lib/rb'
/usr/bin/ruby setup.rb install
rm -f InstalledFiles
---> lib
mkdir -p /usr/lib/ruby/site_ruby/1.8
install thrift.rb /usr/lib/ruby/site_ruby/1.8/
setup.rb:633:in `initialize': Permission denied - /usr/lib/ruby/site_ruby/1.8/thrift.rb (Errno::EACCES)
from setup.rb:633:in `open'
from setup.rb:633:in `install'
from setup.rb:1377:in `install_files'
from setup.rb:1376:in `each'
from setup.rb:1376:in `install_files'
from setup.rb:1350:in `install_dir_lib'
from setup.rb:1532:in `__send__'
from setup.rb:1532:in `traverse'
... 7 levels...
from setup.rb:826:in `__send__'
from setup.rb:826:in `invoke'
from setup.rb:773:in `invoke'
from setup.rb:1578
gmake[4]: *** [install-exec-hook] Error 1
gmake[4]: Leaving directory `/home/molinaro/thrift-instant-r985088/lib/rb'
gmake[3]: *** [install-exec-am] Error 2
gmake[3]: Leaving directory `/home/molinaro/thrift-instant-r985088/lib/rb'
gmake[2]: *** [install-am] Error 2
gmake[2]: Leaving directory `/home/molinaro/thrift-instant-r985088/lib/rb'
gmake[1]: *** [install-recursive] Error 1
It's probably an easy fix for someone familiar with ruby/rake, and would
probably take care of most of the problem.
-Anthony
--
------------------------------------------------------------------------
Anthony Molinaro <an...@alumni.caltech.edu>
Re: [VOTE] Thrift 0.4.0 RC0
Posted by Bryan Duxbury <br...@rapleaf.com>.
On Fri, Aug 13, 2010 at 8:18 AM, David Reiss <dr...@facebook.com> wrote:
> +1
>
> There are a few "._BLAH" files in there that would be nice to remove, but
> not critical.
>
Do you feel like opening a ticket for this cleanup? We can tackle it in the
next release.
>
> As an aside...
>
> Does anyone use configure and make to build the ruby stuff? If not, can we
> just
> delete Ruby support from the configure script? It's gotten in my way
> several
> times when working on the build, and I don't know enough about Ruby to fix
> it.
>
I personally would be OK with this change, since I've never once used it. I
agree that there's an argument to be made for consistency, though. I'd like
to hear some more opinions.
>
> --David
>
> On 08/13/2010 07:30 AM, Bryan Duxbury wrote:
> > I certainly do intend to maintain the rubygem. I'm not sure that I have
> the
> > necessary credentials to publish the gem to rubyforge, though. You can
> build
> > the gem by doing "cd lib/rb && rake package".
> >
> > On Fri, Aug 13, 2010 at 4:36 AM, Rajesh Malepati <ch...@gmail.com>
> wrote:
> >
> >> +1
> >>
> >> My ruby client/server tests pass. I had to regenerate the ruby classes
> >> though. The 0.2 generated ones are incompatible with 0.4.
> >>
> >> One small question. Evan Weaver used to release ruby library as a gem.
> >> That didn't happen for 0.3.
> >>
> >> See http://rubygems.org/gems/thrift and
> http://github.com/fauna/thrift-rb
> >> I also see Kevin Ballard, Kevin Clark and Mark Slee as authors on the
> >> rubygems.org page. Is there any interest in maintaining the gem
> >> version?
> >>
> >> On Fri, Aug 13, 2010 at 12:27 PM, Michael Lum <mi...@openx.org>
> >> wrote:
> >>> Works fine on CentOS 5.5. On Snow Leopard, make check was returning
> >> this:
> >>>
> >>> libtool: link: g++ -g -O2 -o .libs/UnitTests UnitTests-UnitTestMain.o
> >>> UnitTests-TMemoryBufferTest.o UnitTests-TBufferBaseTest.o
> >> -Wl,-bind_at_load
> >>> ./.libs/libtestgencpp.a
> >>> /Users/mlum/temp/0.4.x/thrift-0.4.0/lib/cpp/.libs/libthrift.dylib
> >>> -lboost_unit_test_framework -lpthread
> >>> ld: library not found for -lboost_unit_test_framework
> >>> collect2: ld returned 1 exit status
> >>> make[2]: *** [UnitTests] Error 1
> >>> make[1]: *** [check-am] Error 2
> >>> make: *** [check-recursive] Error 1
> >>>
> >>> I have boost-1.42.0 installed using MacPorts in /opt/local. Changing
> the
> >>> Makefile.am to add $(BOOST_LDFLAGS) to UnitTests_LDADD causes this test
> >> to
> >>> pass. All other tests passed.
> >>>
> >>> --- test/Makefile.am.orig 2010-08-12 23:29:21.000000000 -0700
> >>> +++ test/Makefile.am 2010-08-12 23:34:28.000000000 -0700
> >>> @@ -68,7 +68,7 @@
> >>> TMemoryBufferTest.cpp \
> >>> TBufferBaseTest.cpp
> >>>
> >>> -UnitTests_LDADD = libtestgencpp.la -lboost_unit_test_framework
> >>> +UnitTests_LDADD = libtestgencpp.la $(BOOST_LDFLAGS)
> >>> -lboost_unit_test_framework
> >>>
> >>> #
> >>> # TFDTransportTest
> >>>
> >>> Otherwise, +1.
> >>>
> >>> On 8/12/2010 9:40 PM, Bryan Duxbury wrote:
> >>>>
> >>>> Hi all,
> >>>>
> >>>> As discussed, in all the time it took for us to finally release Thrift
> >>>> 0.3,
> >>>> we've accumulated enough changes for Thrift 0.4!
> >>>>
> >>>> I propose we accept
> >>>>
> >>>> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc0.tar.gz<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz>
> <http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz>
> >> <http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz>as
> >>>> the official Thrift 0.4.0 release.
> >>>>
> >>>> I created this tarball by checking out URL:
> >>>> https://svn.apache.org/repos/asf/incubator/thrift/branches/0.4.x and
> >>>> running
> >>>> "./bootstrap.sh&& ./configure&& make dist".
> >>>>
> >>>> The GPG signature for this tarball can be found at
> >>>>
> >>>> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc0.tar.gz.asc<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz.asc>
> <http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz.asc>
> >> <http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz.asc>.
> >>>> It has an MD5 signature of c272591c1b3560fdef86104e2be214dc.
> >>>>
> >>>> Please download, verify the signatures, untar, and install and test
> the
> >>>> libraries you are familiar with. We need your +1 votes to make the
> >>>> release!
> >>>> If you encounter any problems, please let me know immediately. This
> vote
> >>>> will close 72 hours from now.
> >>>>
> >>>> This release consists of 45 tickets that cover many bugs and
> performance
> >>>> improvements. Please refer to the CHANGES file for the full list.
> >>>>
> >>>> -Bryan
> >>>>
> >>>
> >>
> >
>
Re: [VOTE] Thrift 0.4.0 RC0
Posted by David Reiss <dr...@facebook.com>.
+1
There are a few "._BLAH" files in there that would be nice to remove, but not critical.
As an aside...
Does anyone use configure and make to build the ruby stuff? If not, can we just
delete Ruby support from the configure script? It's gotten in my way several
times when working on the build, and I don't know enough about Ruby to fix it.
--David
On 08/13/2010 07:30 AM, Bryan Duxbury wrote:
> I certainly do intend to maintain the rubygem. I'm not sure that I have the
> necessary credentials to publish the gem to rubyforge, though. You can build
> the gem by doing "cd lib/rb && rake package".
>
> On Fri, Aug 13, 2010 at 4:36 AM, Rajesh Malepati <ch...@gmail.com> wrote:
>
>> +1
>>
>> My ruby client/server tests pass. I had to regenerate the ruby classes
>> though. The 0.2 generated ones are incompatible with 0.4.
>>
>> One small question. Evan Weaver used to release ruby library as a gem.
>> That didn't happen for 0.3.
>>
>> See http://rubygems.org/gems/thrift and http://github.com/fauna/thrift-rb
>> I also see Kevin Ballard, Kevin Clark and Mark Slee as authors on the
>> rubygems.org page. Is there any interest in maintaining the gem
>> version?
>>
>> On Fri, Aug 13, 2010 at 12:27 PM, Michael Lum <mi...@openx.org>
>> wrote:
>>> Works fine on CentOS 5.5. On Snow Leopard, make check was returning
>> this:
>>>
>>> libtool: link: g++ -g -O2 -o .libs/UnitTests UnitTests-UnitTestMain.o
>>> UnitTests-TMemoryBufferTest.o UnitTests-TBufferBaseTest.o
>> -Wl,-bind_at_load
>>> ./.libs/libtestgencpp.a
>>> /Users/mlum/temp/0.4.x/thrift-0.4.0/lib/cpp/.libs/libthrift.dylib
>>> -lboost_unit_test_framework -lpthread
>>> ld: library not found for -lboost_unit_test_framework
>>> collect2: ld returned 1 exit status
>>> make[2]: *** [UnitTests] Error 1
>>> make[1]: *** [check-am] Error 2
>>> make: *** [check-recursive] Error 1
>>>
>>> I have boost-1.42.0 installed using MacPorts in /opt/local. Changing the
>>> Makefile.am to add $(BOOST_LDFLAGS) to UnitTests_LDADD causes this test
>> to
>>> pass. All other tests passed.
>>>
>>> --- test/Makefile.am.orig 2010-08-12 23:29:21.000000000 -0700
>>> +++ test/Makefile.am 2010-08-12 23:34:28.000000000 -0700
>>> @@ -68,7 +68,7 @@
>>> TMemoryBufferTest.cpp \
>>> TBufferBaseTest.cpp
>>>
>>> -UnitTests_LDADD = libtestgencpp.la -lboost_unit_test_framework
>>> +UnitTests_LDADD = libtestgencpp.la $(BOOST_LDFLAGS)
>>> -lboost_unit_test_framework
>>>
>>> #
>>> # TFDTransportTest
>>>
>>> Otherwise, +1.
>>>
>>> On 8/12/2010 9:40 PM, Bryan Duxbury wrote:
>>>>
>>>> Hi all,
>>>>
>>>> As discussed, in all the time it took for us to finally release Thrift
>>>> 0.3,
>>>> we've accumulated enough changes for Thrift 0.4!
>>>>
>>>> I propose we accept
>>>>
>>>> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc0.tar.gz<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz>
>> <http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz>as
>>>> the official Thrift 0.4.0 release.
>>>>
>>>> I created this tarball by checking out URL:
>>>> https://svn.apache.org/repos/asf/incubator/thrift/branches/0.4.x and
>>>> running
>>>> "./bootstrap.sh&& ./configure&& make dist".
>>>>
>>>> The GPG signature for this tarball can be found at
>>>>
>>>> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc0.tar.gz.asc<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz.asc>
>> <http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz.asc>.
>>>> It has an MD5 signature of c272591c1b3560fdef86104e2be214dc.
>>>>
>>>> Please download, verify the signatures, untar, and install and test the
>>>> libraries you are familiar with. We need your +1 votes to make the
>>>> release!
>>>> If you encounter any problems, please let me know immediately. This vote
>>>> will close 72 hours from now.
>>>>
>>>> This release consists of 45 tickets that cover many bugs and performance
>>>> improvements. Please refer to the CHANGES file for the full list.
>>>>
>>>> -Bryan
>>>>
>>>
>>
>
Re: [VOTE] Thrift 0.4.0 RC0
Posted by Bryan Duxbury <br...@rapleaf.com>.
I certainly do intend to maintain the rubygem. I'm not sure that I have the
necessary credentials to publish the gem to rubyforge, though. You can build
the gem by doing "cd lib/rb && rake package".
On Fri, Aug 13, 2010 at 4:36 AM, Rajesh Malepati <ch...@gmail.com> wrote:
> +1
>
> My ruby client/server tests pass. I had to regenerate the ruby classes
> though. The 0.2 generated ones are incompatible with 0.4.
>
> One small question. Evan Weaver used to release ruby library as a gem.
> That didn't happen for 0.3.
>
> See http://rubygems.org/gems/thrift and http://github.com/fauna/thrift-rb
> I also see Kevin Ballard, Kevin Clark and Mark Slee as authors on the
> rubygems.org page. Is there any interest in maintaining the gem
> version?
>
> On Fri, Aug 13, 2010 at 12:27 PM, Michael Lum <mi...@openx.org>
> wrote:
> > Works fine on CentOS 5.5. On Snow Leopard, make check was returning
> this:
> >
> > libtool: link: g++ -g -O2 -o .libs/UnitTests UnitTests-UnitTestMain.o
> > UnitTests-TMemoryBufferTest.o UnitTests-TBufferBaseTest.o
> -Wl,-bind_at_load
> > ./.libs/libtestgencpp.a
> > /Users/mlum/temp/0.4.x/thrift-0.4.0/lib/cpp/.libs/libthrift.dylib
> > -lboost_unit_test_framework -lpthread
> > ld: library not found for -lboost_unit_test_framework
> > collect2: ld returned 1 exit status
> > make[2]: *** [UnitTests] Error 1
> > make[1]: *** [check-am] Error 2
> > make: *** [check-recursive] Error 1
> >
> > I have boost-1.42.0 installed using MacPorts in /opt/local. Changing the
> > Makefile.am to add $(BOOST_LDFLAGS) to UnitTests_LDADD causes this test
> to
> > pass. All other tests passed.
> >
> > --- test/Makefile.am.orig 2010-08-12 23:29:21.000000000 -0700
> > +++ test/Makefile.am 2010-08-12 23:34:28.000000000 -0700
> > @@ -68,7 +68,7 @@
> > TMemoryBufferTest.cpp \
> > TBufferBaseTest.cpp
> >
> > -UnitTests_LDADD = libtestgencpp.la -lboost_unit_test_framework
> > +UnitTests_LDADD = libtestgencpp.la $(BOOST_LDFLAGS)
> > -lboost_unit_test_framework
> >
> > #
> > # TFDTransportTest
> >
> > Otherwise, +1.
> >
> > On 8/12/2010 9:40 PM, Bryan Duxbury wrote:
> >>
> >> Hi all,
> >>
> >> As discussed, in all the time it took for us to finally release Thrift
> >> 0.3,
> >> we've accumulated enough changes for Thrift 0.4!
> >>
> >> I propose we accept
> >>
> >> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc0.tar.gz<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz>
> <http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz>as
> >> the official Thrift 0.4.0 release.
> >>
> >> I created this tarball by checking out URL:
> >> https://svn.apache.org/repos/asf/incubator/thrift/branches/0.4.x and
> >> running
> >> "./bootstrap.sh&& ./configure&& make dist".
> >>
> >> The GPG signature for this tarball can be found at
> >>
> >> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc0.tar.gz.asc<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz.asc>
> <http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz.asc>.
> >> It has an MD5 signature of c272591c1b3560fdef86104e2be214dc.
> >>
> >> Please download, verify the signatures, untar, and install and test the
> >> libraries you are familiar with. We need your +1 votes to make the
> >> release!
> >> If you encounter any problems, please let me know immediately. This vote
> >> will close 72 hours from now.
> >>
> >> This release consists of 45 tickets that cover many bugs and performance
> >> improvements. Please refer to the CHANGES file for the full list.
> >>
> >> -Bryan
> >>
> >
>
Re: [VOTE] Thrift 0.4.0 RC0
Posted by Rajesh Malepati <ch...@gmail.com>.
+1
My ruby client/server tests pass. I had to regenerate the ruby classes
though. The 0.2 generated ones are incompatible with 0.4.
One small question. Evan Weaver used to release ruby library as a gem.
That didn't happen for 0.3.
See http://rubygems.org/gems/thrift and http://github.com/fauna/thrift-rb
I also see Kevin Ballard, Kevin Clark and Mark Slee as authors on the
rubygems.org page. Is there any interest in maintaining the gem
version?
On Fri, Aug 13, 2010 at 12:27 PM, Michael Lum <mi...@openx.org> wrote:
> Works fine on CentOS 5.5. On Snow Leopard, make check was returning this:
>
> libtool: link: g++ -g -O2 -o .libs/UnitTests UnitTests-UnitTestMain.o
> UnitTests-TMemoryBufferTest.o UnitTests-TBufferBaseTest.o -Wl,-bind_at_load
> ./.libs/libtestgencpp.a
> /Users/mlum/temp/0.4.x/thrift-0.4.0/lib/cpp/.libs/libthrift.dylib
> -lboost_unit_test_framework -lpthread
> ld: library not found for -lboost_unit_test_framework
> collect2: ld returned 1 exit status
> make[2]: *** [UnitTests] Error 1
> make[1]: *** [check-am] Error 2
> make: *** [check-recursive] Error 1
>
> I have boost-1.42.0 installed using MacPorts in /opt/local. Changing the
> Makefile.am to add $(BOOST_LDFLAGS) to UnitTests_LDADD causes this test to
> pass. All other tests passed.
>
> --- test/Makefile.am.orig 2010-08-12 23:29:21.000000000 -0700
> +++ test/Makefile.am 2010-08-12 23:34:28.000000000 -0700
> @@ -68,7 +68,7 @@
> TMemoryBufferTest.cpp \
> TBufferBaseTest.cpp
>
> -UnitTests_LDADD = libtestgencpp.la -lboost_unit_test_framework
> +UnitTests_LDADD = libtestgencpp.la $(BOOST_LDFLAGS)
> -lboost_unit_test_framework
>
> #
> # TFDTransportTest
>
> Otherwise, +1.
>
> On 8/12/2010 9:40 PM, Bryan Duxbury wrote:
>>
>> Hi all,
>>
>> As discussed, in all the time it took for us to finally release Thrift
>> 0.3,
>> we've accumulated enough changes for Thrift 0.4!
>>
>> I propose we accept
>>
>> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc0.tar.gz<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz>as
>> the official Thrift 0.4.0 release.
>>
>> I created this tarball by checking out URL:
>> https://svn.apache.org/repos/asf/incubator/thrift/branches/0.4.x and
>> running
>> "./bootstrap.sh&& ./configure&& make dist".
>>
>> The GPG signature for this tarball can be found at
>>
>> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc0.tar.gz.asc<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz.asc>.
>> It has an MD5 signature of c272591c1b3560fdef86104e2be214dc.
>>
>> Please download, verify the signatures, untar, and install and test the
>> libraries you are familiar with. We need your +1 votes to make the
>> release!
>> If you encounter any problems, please let me know immediately. This vote
>> will close 72 hours from now.
>>
>> This release consists of 45 tickets that cover many bugs and performance
>> improvements. Please refer to the CHANGES file for the full list.
>>
>> -Bryan
>>
>
Re: [VOTE] Thrift 0.4.0 RC0
Posted by Igor Ribeiro de Assis <ig...@gmail.com>.
+1 from me.
But I had the same issues with make check and BOOST_LDFLAGS, worked
after fix test/Makefile.am.
On Thu, Aug 12, 2010 at 11:57 PM, Michael Lum <mi...@openx.org> wrote:
> Works fine on CentOS 5.5. On Snow Leopard, make check was returning this:
>
> libtool: link: g++ -g -O2 -o .libs/UnitTests UnitTests-UnitTestMain.o
> UnitTests-TMemoryBufferTest.o UnitTests-TBufferBaseTest.o -Wl,-bind_at_load
> ./.libs/libtestgencpp.a
> /Users/mlum/temp/0.4.x/thrift-0.4.0/lib/cpp/.libs/libthrift.dylib
> -lboost_unit_test_framework -lpthread
> ld: library not found for -lboost_unit_test_framework
> collect2: ld returned 1 exit status
> make[2]: *** [UnitTests] Error 1
> make[1]: *** [check-am] Error 2
> make: *** [check-recursive] Error 1
>
> I have boost-1.42.0 installed using MacPorts in /opt/local. Changing the
> Makefile.am to add $(BOOST_LDFLAGS) to UnitTests_LDADD causes this test to
> pass. All other tests passed.
>
> --- test/Makefile.am.orig 2010-08-12 23:29:21.000000000 -0700
> +++ test/Makefile.am 2010-08-12 23:34:28.000000000 -0700
> @@ -68,7 +68,7 @@
> TMemoryBufferTest.cpp \
> TBufferBaseTest.cpp
>
> -UnitTests_LDADD = libtestgencpp.la -lboost_unit_test_framework
> +UnitTests_LDADD = libtestgencpp.la $(BOOST_LDFLAGS)
> -lboost_unit_test_framework
>
> #
> # TFDTransportTest
>
> Otherwise, +1.
>
> On 8/12/2010 9:40 PM, Bryan Duxbury wrote:
>>
>> Hi all,
>>
>> As discussed, in all the time it took for us to finally release Thrift
>> 0.3,
>> we've accumulated enough changes for Thrift 0.4!
>>
>> I propose we accept
>>
>> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc0.tar.gz<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz>as
>> the official Thrift 0.4.0 release.
>>
>> I created this tarball by checking out URL:
>> https://svn.apache.org/repos/asf/incubator/thrift/branches/0.4.x and
>> running
>> "./bootstrap.sh&& ./configure&& make dist".
>>
>> The GPG signature for this tarball can be found at
>>
>> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc0.tar.gz.asc<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz.asc>.
>> It has an MD5 signature of c272591c1b3560fdef86104e2be214dc.
>>
>> Please download, verify the signatures, untar, and install and test the
>> libraries you are familiar with. We need your +1 votes to make the
>> release!
>> If you encounter any problems, please let me know immediately. This vote
>> will close 72 hours from now.
>>
>> This release consists of 45 tickets that cover many bugs and performance
>> improvements. Please refer to the CHANGES file for the full list.
>>
>> -Bryan
>>
>
--
Igor Ribeiro de Assis
Re: [VOTE] Thrift 0.4.0 RC0
Posted by Michael Lum <mi...@openx.org>.
Works fine on CentOS 5.5. On Snow Leopard, make check was returning this:
libtool: link: g++ -g -O2 -o .libs/UnitTests UnitTests-UnitTestMain.o
UnitTests-TMemoryBufferTest.o UnitTests-TBufferBaseTest.o
-Wl,-bind_at_load ./.libs/libtestgencpp.a
/Users/mlum/temp/0.4.x/thrift-0.4.0/lib/cpp/.libs/libthrift.dylib
-lboost_unit_test_framework -lpthread
ld: library not found for -lboost_unit_test_framework
collect2: ld returned 1 exit status
make[2]: *** [UnitTests] Error 1
make[1]: *** [check-am] Error 2
make: *** [check-recursive] Error 1
I have boost-1.42.0 installed using MacPorts in /opt/local. Changing
the Makefile.am to add $(BOOST_LDFLAGS) to UnitTests_LDADD causes this
test to pass. All other tests passed.
--- test/Makefile.am.orig 2010-08-12 23:29:21.000000000 -0700
+++ test/Makefile.am 2010-08-12 23:34:28.000000000 -0700
@@ -68,7 +68,7 @@
TMemoryBufferTest.cpp \
TBufferBaseTest.cpp
-UnitTests_LDADD = libtestgencpp.la -lboost_unit_test_framework
+UnitTests_LDADD = libtestgencpp.la $(BOOST_LDFLAGS)
-lboost_unit_test_framework
#
# TFDTransportTest
Otherwise, +1.
On 8/12/2010 9:40 PM, Bryan Duxbury wrote:
> Hi all,
>
> As discussed, in all the time it took for us to finally release Thrift 0.3,
> we've accumulated enough changes for Thrift 0.4!
>
> I propose we accept
> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc0.tar.gz<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz>as
> the official Thrift 0.4.0 release.
>
> I created this tarball by checking out URL:
> https://svn.apache.org/repos/asf/incubator/thrift/branches/0.4.x and running
> "./bootstrap.sh&& ./configure&& make dist".
>
> The GPG signature for this tarball can be found at
> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc0.tar.gz.asc<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz.asc>.
> It has an MD5 signature of c272591c1b3560fdef86104e2be214dc.
>
> Please download, verify the signatures, untar, and install and test the
> libraries you are familiar with. We need your +1 votes to make the release!
> If you encounter any problems, please let me know immediately. This vote
> will close 72 hours from now.
>
> This release consists of 45 tickets that cover many bugs and performance
> improvements. Please refer to the CHANGES file for the full list.
>
> -Bryan
>
Re: [VOTE] Thrift 0.4.0 RC0
Posted by Doug Cutting <cu...@apache.org>.
+1 Checksum, signature, RAT output all look good.
Doug
On 08/12/2010 09:40 PM, Bryan Duxbury wrote:
> Hi all,
>
> As discussed, in all the time it took for us to finally release Thrift 0.3,
> we've accumulated enough changes for Thrift 0.4!
>
> I propose we accept
> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc0.tar.gz<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz>as
> the official Thrift 0.4.0 release.
>
> I created this tarball by checking out URL:
> https://svn.apache.org/repos/asf/incubator/thrift/branches/0.4.x and running
> "./bootstrap.sh&& ./configure&& make dist".
>
> The GPG signature for this tarball can be found at
> http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc0.tar.gz.asc<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz.asc>.
> It has an MD5 signature of c272591c1b3560fdef86104e2be214dc.
>
> Please download, verify the signatures, untar, and install and test the
> libraries you are familiar with. We need your +1 votes to make the release!
> If you encounter any problems, please let me know immediately. This vote
> will close 72 hours from now.
>
> This release consists of 45 tickets that cover many bugs and performance
> improvements. Please refer to the CHANGES file for the full list.
>
> -Bryan
>
Re: [VOTE] Thrift 0.4.0 RC0
Posted by Joe Schaefer <jo...@yahoo.com>.
I plan to take a look at this over the weekend, but
I'd again like to suggest that you add your apache.org
address to your pgp key and put your key in
/x1/www/www.apache.org/dist/incubator/thrift/KEYS
on people.apache.org. Both Todd's key and mine are
already there. You might want to cross-link to that
file on the thrift download page too (the url should
be obvious).
Re: [VOTE] Thrift 0.4.0 RC0
Posted by Joe Schaefer <jo...@yahoo.com>.
Upayavira is currently travelling and probably
won't have time to vote on the release, so the
sooner you pass this vote along to general@incubator
asking for votes from IPMC members, the better.
Re: [VOTE] Thrift 0.4.0 RC0
Posted by Bryan Duxbury <br...@rapleaf.com>.
This was fixed in the 0.3 branch but apparently not in trunk. I will fix
both trunk and 0.4 straightaway.
On Sat, Aug 14, 2010 at 10:10 AM, Joe Schaefer <jo...@yahoo.com>wrote:
> The NOTICE file still needs attention.
>
> It should read:
>
> ----------------------------
> Apache Thrift
> Copyright 2006-2010 The Apache Software Foundation.
>
> This product includes software developed at
> The Apache Software Foundation (http://www.apache.org/).
> -----------------------------
>
>
> The "et, al" is incorrect because only Apache has
> collective copyright over the codebase, which is why
> there's a statement in the NOTICE file for Apache
> in the first place. Also the year should include 2010.
>
> As I consider these minor issues not significant enough
> to prevent a release I intend to vote +1 once someone
> fixes the NOTICE file in trunk.
>
> Thanks.
>
>
> ----- Original Message ----
> > From: Bryan Duxbury <br...@rapleaf.com>
> > To: thrift-dev@incubator.apache.org
> > Sent: Fri, August 13, 2010 12:40:59 AM
> > Subject: [VOTE] Thrift 0.4.0 RC0
> >
> > Hi all,
> >
> > As discussed, in all the time it took for us to finally release Thrift
> 0.3,
> > we've accumulated enough changes for Thrift 0.4!
> >
> > I propose we accept
> >http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc0.tar.gz<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz>
> <http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz>as
> >s
> > the official Thrift 0.4.0 release.
> >
> > I created this tarball by checking out URL:
> > https://svn.apache.org/repos/asf/incubator/thrift/branches/0.4.x and
> running
> > "./bootstrap.sh && ./configure && make dist".
> >
> > The GPG signature for this tarball can be found at
> >http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc0.tar.gz.asc<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz.asc>
> <http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz.asc>.
> >.
> > It has an MD5 signature of c272591c1b3560fdef86104e2be214dc.
> >
> > Please download, verify the signatures, untar, and install and test the
> > libraries you are familiar with. We need your +1 votes to make the
> release!
> > If you encounter any problems, please let me know immediately. This vote
> > will close 72 hours from now.
> >
> > This release consists of 45 tickets that cover many bugs and performance
> > improvements. Please refer to the CHANGES file for the full list.
> >
> > -Bryan
> >
>
>
>
>
Re: [VOTE] Thrift 0.4.0 RC0
Posted by Joe Schaefer <jo...@yahoo.com>.
The NOTICE file still needs attention.
It should read:
----------------------------
Apache Thrift
Copyright 2006-2010 The Apache Software Foundation.
This product includes software developed at
The Apache Software Foundation (http://www.apache.org/).
-----------------------------
The "et, al" is incorrect because only Apache has
collective copyright over the codebase, which is why
there's a statement in the NOTICE file for Apache
in the first place. Also the year should include 2010.
As I consider these minor issues not significant enough
to prevent a release I intend to vote +1 once someone
fixes the NOTICE file in trunk.
Thanks.
----- Original Message ----
> From: Bryan Duxbury <br...@rapleaf.com>
> To: thrift-dev@incubator.apache.org
> Sent: Fri, August 13, 2010 12:40:59 AM
> Subject: [VOTE] Thrift 0.4.0 RC0
>
> Hi all,
>
> As discussed, in all the time it took for us to finally release Thrift 0.3,
> we've accumulated enough changes for Thrift 0.4!
>
> I propose we accept
>http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc0.tar.gz<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz>as
>s
> the official Thrift 0.4.0 release.
>
> I created this tarball by checking out URL:
> https://svn.apache.org/repos/asf/incubator/thrift/branches/0.4.x and running
> "./bootstrap.sh && ./configure && make dist".
>
> The GPG signature for this tarball can be found at
>http://people.apache.org/~bryanduxbury/thrift-0.4.0-rc0.tar.gz.asc<http://people.apache.org/%7Ebryanduxbury/thrift-0.4.0-rc0.tar.gz.asc>.
>.
> It has an MD5 signature of c272591c1b3560fdef86104e2be214dc.
>
> Please download, verify the signatures, untar, and install and test the
> libraries you are familiar with. We need your +1 votes to make the release!
> If you encounter any problems, please let me know immediately. This vote
> will close 72 hours from now.
>
> This release consists of 45 tickets that cover many bugs and performance
> improvements. Please refer to the CHANGES file for the full list.
>
> -Bryan
>