[jira] [Commented] (CXF-6423) PrettyLoggingFilter tests and improvements

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CXF-6423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14567360#comment-14567360 ] 

ASF GitHub Bot commented on CXF-6423:
-------------------------------------

Github user cschneider commented on the pull request:

    https://github.com/apache/cxf/pull/75#issuecomment-107528593
  
    I think ideally we should have two different switches. One for the pretty printing and one for reparing the xml. There is value to both options. It makes sense to provide well formed xml for tools that need it but it can also be important to truncate at exactly the correct place.


> PrettyLoggingFilter tests and improvements
> ------------------------------------------
>
>                 Key: CXF-6423
>                 URL: https://issues.apache.org/jira/browse/CXF-6423
>             Project: CXF
>          Issue Type: Improvement
>            Reporter: Thomas Skjølberg
>            Assignee: Christian Schneider
>            Priority: Minor
>
> Improvements for PrettyLoggingFilter in the cxf-rt-features-logging module: 
> 1. use a StringReader instead of getting bytes from a String and using an InputStream (capture encoding issues at an eariler stage)
> 2. add parser exception handling based on whether the payload is truncated or not; return original XML if deemed invalid
> 3. do not call XMLStreamWriter.close() before getting contents for truncated or invalid XML because some writers misbehave (are extra helpful) in a way unfit for logging. 
> 4.construct output StringWriter with a size based on the raw XML string size
> 5.additional test cases 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)