[GitHub] brodybits commented on issue #48: Rework use of ~ in build.json

[GitBox <gi...@apache.org>]

brodybits commented on issue #48: Rework use of ~ in build.json
URL: https://github.com/apache/cordova/issues/48#issuecomment-439737928
 
 
   @janpio please add <https://github.com/apache/cordova-docs/pull/909> to the list you made above.
   
   I think the use of "build.json" is misleading for a couple reasons:
   * I think you meant `package.json`
   * for each Cordova package I think we need to do a couple things:
     - add `untildify` package to `package.json`, using `npm` command
     - update the code use the `untildify` API instead of doing its own thing with `~` and `process.env.HOME`
   
   From a quick search I found a couple more places where this kind of a change should be made:
   * `cordova-lib`: <https://github.com/apache/cordova-lib/blob/master/src/cordova/util.js#L31>
   * `cordova-ios`: <https://github.com/apache/cordova-ios/blob/master/bin/templates/scripts/cordova/lib/check_reqs.js#L95>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org