You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/01/30 12:23:45 UTC
[GitHub] [incubator-nuttx] jerpelea opened a new pull request #2780: include: nuttx: update license headers
jerpelea opened a new pull request #2780:
URL: https://github.com/apache/incubator-nuttx/pull/2780
## Summary
Gregory Nutt sumited the SGA and we can replace the headers with Apache 2.0 license
## Impact
None
## Testing
None
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #2780: include: nuttx: update license headers
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #2780:
URL: https://github.com/apache/incubator-nuttx/pull/2780#issuecomment-770443020
> @btashton In my understanding Greg holds the copyright of the file which means that the other contributors contributed to the copyright holder.
> Am I wrong?
I guess this would indicate that you are correct, https://ben.balter.com/2015/06/03/copyright-notices-for-websites-and-open-source-projects/#the-copyright-holder so long as Greg is the one that actually holds the copyright. We do need to be careful in cases where the original work was not actually assigned to Greg as his SGA may not fully cover that work. A starting filter would be any work that has more than one person listed, in that case we will likely need to dig more into the history.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea edited a comment on pull request #2780: include: nuttx: update license headers
Posted by GitBox <gi...@apache.org>.
jerpelea edited a comment on pull request #2780:
URL: https://github.com/apache/incubator-nuttx/pull/2780#issuecomment-770636062
@btashton I separated the work in 2 parts so that we can merged parts of the initial commit
now we have only the files with Greg as author and copyright holder
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #2780: include: nuttx: update license headers
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #2780:
URL: https://github.com/apache/incubator-nuttx/pull/2780#issuecomment-770266189
Thank you @jerpelea ! Please squash the commits
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on pull request #2780: include: nuttx: update license headers
Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #2780:
URL: https://github.com/apache/incubator-nuttx/pull/2780#issuecomment-770361130
@btashton In my understanding Greg holds the copyright of the file which means that the other contributors contributed to the copyright holder.
Am I wrong?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on pull request #2780: include: nuttx: update license headers
Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #2780:
URL: https://github.com/apache/incubator-nuttx/pull/2780#issuecomment-770636062
@btashton I will separate the work in 2 parts so that we can merged parts of this commit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #2780: include: nuttx: update license headers
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #2780:
URL: https://github.com/apache/incubator-nuttx/pull/2780#issuecomment-770892742
Hi @jerpelea ok I will merge it. I was worried about the points raised by @btashton but since the Copyright were all from Greg I think there is not big issue here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea edited a comment on pull request #2780: include: nuttx: update license headers
Posted by GitBox <gi...@apache.org>.
jerpelea edited a comment on pull request #2780:
URL: https://github.com/apache/incubator-nuttx/pull/2780#issuecomment-770656911
@acassis can we merge this PR so that I can continue
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #2780: include: nuttx: update license headers
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #2780:
URL: https://github.com/apache/incubator-nuttx/pull/2780#issuecomment-770374358
> @acassis I would prefer to have them separate commits to allow us to better track the changes but if you need I can squash them
Yes, modification doing the same thing should be squashed in a single commit to avoid polluting the log history
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on pull request #2780: include: nuttx: update license headers
Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #2780:
URL: https://github.com/apache/incubator-nuttx/pull/2780#issuecomment-770389442
@acassis done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis merged pull request #2780: include: nuttx: update license headers
Posted by GitBox <gi...@apache.org>.
acassis merged pull request #2780:
URL: https://github.com/apache/incubator-nuttx/pull/2780
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on pull request #2780: include: nuttx: update license headers
Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #2780:
URL: https://github.com/apache/incubator-nuttx/pull/2780#issuecomment-770656911
@acassis can we merged this PR so that I can continue
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #2780: include: nuttx: update license headers
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #2780:
URL: https://github.com/apache/incubator-nuttx/pull/2780#issuecomment-770299317
Some of these files have changes from others besides Greg, Did you make sure those are ones we have a ICLAs from if they are not minor changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on pull request #2780: include: nuttx: update license headers
Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #2780:
URL: https://github.com/apache/incubator-nuttx/pull/2780#issuecomment-770361215
@acassis I would prefer to have them separate commits to allow us to better track the changes but if you need I can squash them
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on pull request #2780: include: nuttx: update license headers
Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #2780:
URL: https://github.com/apache/incubator-nuttx/pull/2780#issuecomment-770898574
perfect. I will continue to clean his files and then yours :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org