You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "xinyiZzz (via GitHub)" <gi...@apache.org> on 2023/05/06 13:29:15 UTC
[GitHub] [doris] xinyiZzz opened a new pull request, #19354: [fix](scan) fix scanner mem tracker
xinyiZzz opened a new pull request, #19354:
URL: https://github.com/apache/doris/pull/19354
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
* [ ] Does it affect the original behavior
* [ ] Has unit tests been added
* [ ] Has document been added or modified
* [ ] Does it need to update dependencies
* [ ] Is this PR support rollback (If NO, please explain WHY)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19354: [fix](scan) fix scanner mem tracker
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19354:
URL: https://github.com/apache/doris/pull/19354#issuecomment-1539771313
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xinyiZzz commented on pull request #19354: [fix](scan) fix scanner mem tracker
Posted by "xinyiZzz (via GitHub)" <gi...@apache.org>.
xinyiZzz commented on PR #19354:
URL: https://github.com/apache/doris/pull/19354#issuecomment-1537143026
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xinyiZzz commented on a diff in pull request #19354: [fix](scan) fix scanner mem tracker
Posted by "xinyiZzz (via GitHub)" <gi...@apache.org>.
xinyiZzz commented on code in PR #19354:
URL: https://github.com/apache/doris/pull/19354#discussion_r1187316133
##########
be/src/vec/exec/scan/scanner_scheduler.cpp:
##########
@@ -261,10 +261,8 @@ void ScannerScheduler::_schedule_scanners(ScannerContext* ctx) {
void ScannerScheduler::_scanner_scan(ScannerScheduler* scheduler, ScannerContext* ctx,
VScannerSPtr scanner) {
- auto tracker_config = [&] {
- SCOPED_ATTACH_TASK(scanner->runtime_state());
- Thread::set_self_name("_scanner_scan");
- };
+ SCOPED_ATTACH_TASK(scanner->runtime_state());
+ auto tracker_config = [&] { Thread::set_self_name("_scanner_scan"); };
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on a diff in pull request #19354: [fix](scan) fix scanner mem tracker
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on code in PR #19354:
URL: https://github.com/apache/doris/pull/19354#discussion_r1187077867
##########
be/src/vec/exec/scan/scanner_scheduler.cpp:
##########
@@ -261,10 +261,8 @@ void ScannerScheduler::_schedule_scanners(ScannerContext* ctx) {
void ScannerScheduler::_scanner_scan(ScannerScheduler* scheduler, ScannerContext* ctx,
VScannerSPtr scanner) {
- auto tracker_config = [&] {
- SCOPED_ATTACH_TASK(scanner->runtime_state());
- Thread::set_self_name("_scanner_scan");
- };
+ SCOPED_ATTACH_TASK(scanner->runtime_state());
+ auto tracker_config = [&] { Thread::set_self_name("_scanner_scan"); };
Review Comment:
This lambda expression is useless, remove it,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xinyiZzz commented on pull request #19354: [fix](scan) fix scanner mem tracker
Posted by "xinyiZzz (via GitHub)" <gi...@apache.org>.
xinyiZzz commented on PR #19354:
URL: https://github.com/apache/doris/pull/19354#issuecomment-1539766574
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on pull request #19354: [fix](scan) fix scanner mem tracker
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on PR #19354:
URL: https://github.com/apache/doris/pull/19354#issuecomment-1541179481
branch-1.2-lts is right, but master is wrong, so not need to pick to 1.2-lts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19354: [fix](scan) fix scanner mem tracker
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19354:
URL: https://github.com/apache/doris/pull/19354#issuecomment-1538185282
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #19354: [fix](scan) fix scanner mem tracker
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #19354:
URL: https://github.com/apache/doris/pull/19354
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19354: [fix](scan) fix scanner mem tracker
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19354:
URL: https://github.com/apache/doris/pull/19354#issuecomment-1537143531
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org