[jira] Commented: (WICKET-2103) SignInPanel.onSignInSucceeded call the correct method on IPageFactory

["Francois Fernandes (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12673855#action_12673855 ] 

Francois Fernandes commented on WICKET-2103:
--------------------------------------------

wow, that was fast! Thank you for fixing this! I'm really looking forward for the final 1.4 Release!

> SignInPanel.onSignInSucceeded call the correct method on IPageFactory
> ---------------------------------------------------------------------
>
>                 Key: WICKET-2103
>                 URL: https://issues.apache.org/jira/browse/WICKET-2103
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-auth-roles
>            Reporter: Francois Fernandes
>            Assignee: Juergen Donnerstag
>             Fix For: 1.4-RC3
>
>
> The onSignInSucceeded method is calling newPage(Class, PageParameters) with PageParameters = null. Instead of this, the call should be changed to use the newPage(Class) method instead. 
> setResponsePage(getApplication().getSessionSettings().getPageFactory().newPage(getApplication().getHomePage(), (PageParameters)null));
> should be changed to
> setResponsePage(getApplication().getSessionSettings().getPageFactory().newPage(getApplication().getHomePage()));
> This is releated to WICKET-2092.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.