You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tedyu <gi...@git.apache.org> on 2015/12/21 18:30:52 UTC
[GitHub] flink pull request: FLINK-3103 Remove synchronization in FsStateBa...
GitHub user tedyu opened a pull request:
https://github.com/apache/flink/pull/1474
FLINK-3103 Remove synchronization in FsStateBackend#FsCheckpointStateOutputStream#close()
Stephan made the following comment:
I would actually suggest to not use a lock in the close() methods either. In a single threaded use, there is really no need for these locks.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tedyu/flink master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1474.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1474
----
commit eb6dd48ee8a9a20889d7fcd994b8fc0d7df9ba1c
Author: tedyu <yu...@gmail.com>
Date: 2015-12-21T17:29:16Z
FLINK-3103 Remove synchronization in FsStateBackend#FsCheckpointStateOutputStream#close()
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3103] Remove synchronization in FsState...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1474#issuecomment-166934557
As some context: The class does not lock on all calls that can modify the state of the buffers (such as every `write()` call, for performance), so the locking removed in this PR becomes not effective anyways.
+1, will merge this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3103] Remove synchronization in FsState...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1474#issuecomment-167405260
Thank you for the fix!
This was merged, but not automatically closed. Could you close it manually?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3103] Remove synchronization in FsState...
Posted by tedyu <gi...@git.apache.org>.
Github user tedyu closed the pull request at:
https://github.com/apache/flink/pull/1474
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---