You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/28 00:22:52 UTC
[GitHub] [incubator-superset] john-bodley opened a new pull request #9665: [debug] Debugging caching issue
john-bodley opened a new pull request #9665:
URL: https://github.com/apache/incubator-superset/pull/9665
### CATEGORY
Choose one
- [x] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
Fixes https://github.com/apache/incubator-superset/issues/9664.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue: https://github.com/apache/incubator-superset/issues/9664
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
to: @villebro
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] john-bodley commented on pull request #9665: [debug] Debugging caching issue
Posted by GitBox <gi...@apache.org>.
john-bodley commented on pull request #9665:
URL: https://github.com/apache/incubator-superset/pull/9665#issuecomment-620304910
@villebro this a draft fix for https://github.com/apache/incubator-superset/issues/9664. I would love your thoughts on how best to address this problem. Note this solution works, however it seems somewhat egregious to be leveraging the Flask `g` global for this context.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] john-bodley commented on pull request #9665: [fix] Ensuring cache warmup respects request form data
Posted by GitBox <gi...@apache.org>.
john-bodley commented on pull request #9665:
URL: https://github.com/apache/incubator-superset/pull/9665#issuecomment-620398437
@villebro I wonder if it should be added to [`get_form_data`](https://github.com/apache/incubator-superset/blob/9447381549bf930ba850694f854854d77747f43e/superset/views/utils.py#L102)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9665: [fix] Ensuring cache warmup respects request form data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9665:
URL: https://github.com/apache/incubator-superset/pull/9665#issuecomment-620960217
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=h1) Report
> Merging [#9665](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f07ca7d8364122c1cd66845ccf66095d185bcdcc&el=desc) will **increase** coverage by `0.08%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9665 +/- ##
==========================================
+ Coverage 65.70% 65.78% +0.08%
==========================================
Files 581 581
Lines 30219 30283 +64
Branches 3071 3078 +7
==========================================
+ Hits 19856 19923 +67
+ Misses 10182 10178 -4
- Partials 181 182 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `58.75% <ø> (+<0.01%)` | :arrow_up: |
| #python | `70.71% <100.00%> (+0.11%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `84.69% <100.00%> (+10.69%)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.11% <100.00%> (-0.14%)` | :arrow_down: |
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `82.91% <100.00%> (+0.21%)` | :arrow_up: |
| [superset-frontend/src/components/ListView/utils.ts](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvdXRpbHMudHM=) | `82.95% <0.00%> (-2.05%)` | :arrow_down: |
| [superset/utils/pandas\_postprocessing.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nLnB5) | `88.32% <0.00%> (-1.98%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.49% <0.00%> (ø)` | |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `72.35% <0.00%> (ø)` | |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <0.00%> (ø)` | |
| ... and [8 more](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=footer). Last update [f07ca7d...4181017](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9665: [fix] Ensuring cache warmup respects request form data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9665:
URL: https://github.com/apache/incubator-superset/pull/9665#issuecomment-620960217
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=h1) Report
> Merging [#9665](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f07ca7d8364122c1cd66845ccf66095d185bcdcc&el=desc) will **decrease** coverage by `0.06%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9665 +/- ##
==========================================
- Coverage 65.70% 65.64% -0.07%
==========================================
Files 581 581
Lines 30219 30283 +64
Branches 3071 3078 +7
==========================================
+ Hits 19856 19878 +22
- Misses 10182 10223 +41
- Partials 181 182 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `58.75% <ø> (+<0.01%)` | :arrow_up: |
| #python | `70.46% <100.00%> (-0.14%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `84.69% <100.00%> (+10.69%)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.88% <100.00%> (-0.36%)` | :arrow_down: |
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `82.91% <100.00%> (+0.21%)` | :arrow_up: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `58.92% <0.00%> (-21.43%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `45.83% <0.00%> (-20.84%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `80.00% <0.00%> (-15.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `83.90% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `84.47% <0.00%> (-2.39%)` | :arrow_down: |
| [superset-frontend/src/components/ListView/utils.ts](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvdXRpbHMudHM=) | `82.95% <0.00%> (-2.05%)` | :arrow_down: |
| ... and [16 more](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=footer). Last update [f07ca7d...4181017](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on pull request #9665: [fix] Ensuring cache warmup respects request form data
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #9665:
URL: https://github.com/apache/incubator-superset/pull/9665#issuecomment-620421366
@john-bodley I didn't remember that method; You're right, it should probably go in there. I'm assuming `g` context should only be used if `form_data` is missing in both POST and url params?
Mental note: that method is really bloated/complex and doesn't have any unit tests, should probably be broken up at some point.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9665: [fix] Ensuring cache warmup respects request form data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9665:
URL: https://github.com/apache/incubator-superset/pull/9665#issuecomment-620960217
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=h1) Report
> Merging [#9665](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f07ca7d8364122c1cd66845ccf66095d185bcdcc&el=desc) will **increase** coverage by `4.89%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9665 +/- ##
==========================================
+ Coverage 65.70% 70.60% +4.89%
==========================================
Files 581 581
Lines 30219 30318 +99
Branches 3071 3096 +25
==========================================
+ Hits 19856 21406 +1550
+ Misses 10182 8801 -1381
+ Partials 181 111 -70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.66% <ø> (?)` | |
| #javascript | `58.79% <ø> (+0.04%)` | :arrow_up: |
| #python | `70.72% <100.00%> (+0.12%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `84.69% <100.00%> (+10.69%)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.11% <100.00%> (-0.14%)` | :arrow_down: |
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `82.91% <100.00%> (+0.21%)` | :arrow_up: |
| [superset-frontend/src/components/ListView/utils.ts](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvdXRpbHMudHM=) | `82.95% <0.00%> (-2.05%)` | :arrow_down: |
| [superset/utils/pandas\_postprocessing.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nLnB5) | `88.32% <0.00%> (-1.98%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.49% <0.00%> (ø)` | |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `72.35% <0.00%> (ø)` | |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <0.00%> (ø)` | |
| ... and [155 more](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=footer). Last update [f07ca7d...38f9c12](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] john-bodley commented on pull request #9665: [fix] Ensuring cache warmup respects request form data
Posted by GitBox <gi...@apache.org>.
john-bodley commented on pull request #9665:
URL: https://github.com/apache/incubator-superset/pull/9665#issuecomment-620689730
@villebro I agree regarding the bloated/complex nature. I might rename that method `get_form_data_and_slice` and have a `get_form_data` method which merely gets the form-data.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9665: [fix] Ensuring cache warmup respects request form data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9665:
URL: https://github.com/apache/incubator-superset/pull/9665#issuecomment-620960217
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=h1) Report
> Merging [#9665](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f07ca7d8364122c1cd66845ccf66095d185bcdcc&el=desc) will **increase** coverage by `4.85%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9665 +/- ##
==========================================
+ Coverage 65.70% 70.56% +4.85%
==========================================
Files 581 581
Lines 30219 30318 +99
Branches 3071 3096 +25
==========================================
+ Hits 19856 21394 +1538
+ Misses 10182 8813 -1369
+ Partials 181 111 -70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.66% <ø> (?)` | |
| #javascript | `58.79% <ø> (+0.04%)` | :arrow_up: |
| #python | `70.65% <100.00%> (+0.05%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `84.69% <100.00%> (+10.69%)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.88% <100.00%> (-0.36%)` | :arrow_down: |
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `82.91% <100.00%> (+0.21%)` | :arrow_up: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset-frontend/src/components/ListView/utils.ts](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvdXRpbHMudHM=) | `82.95% <0.00%> (-2.05%)` | :arrow_down: |
| [superset/utils/pandas\_postprocessing.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nLnB5) | `88.32% <0.00%> (-1.98%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.97% <0.00%> (-0.90%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.49% <0.00%> (ø)` | |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| ... and [157 more](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=footer). Last update [f07ca7d...38f9c12](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on pull request #9665: [fix] Ensuring cache warmup respects request form data
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9665:
URL: https://github.com/apache/incubator-superset/pull/9665#issuecomment-620960217
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=h1) Report
> Merging [#9665](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f07ca7d8364122c1cd66845ccf66095d185bcdcc&el=desc) will **increase** coverage by `4.88%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9665 +/- ##
==========================================
+ Coverage 65.70% 70.59% +4.88%
==========================================
Files 581 182 -399
Lines 30219 17815 -12404
Branches 3071 0 -3071
==========================================
- Hits 19856 12576 -7280
+ Misses 10182 5239 -4943
+ Partials 181 0 -181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #python | `70.59% <100.00%> (-0.01%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `84.84% <100.00%> (+10.84%)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.88% <100.00%> (-0.36%)` | :arrow_down: |
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `82.91% <100.00%> (+0.21%)` | :arrow_up: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/utils/pandas\_postprocessing.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nLnB5) | `88.32% <0.00%> (-1.98%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `86.62% <0.00%> (-1.17%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.97% <0.00%> (-0.90%)` | :arrow_down: |
| [superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `77.63% <0.00%> (-0.15%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.49% <0.00%> (ø)` | |
| ... and [403 more](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=footer). Last update [f07ca7d...2005ea1](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9665: [fix] Ensuring cache warmup respects request form data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9665:
URL: https://github.com/apache/incubator-superset/pull/9665#issuecomment-620960217
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=h1) Report
> Merging [#9665](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f07ca7d8364122c1cd66845ccf66095d185bcdcc&el=desc) will **increase** coverage by `0.08%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9665 +/- ##
==========================================
+ Coverage 65.70% 65.78% +0.08%
==========================================
Files 581 581
Lines 30219 30283 +64
Branches 3071 3078 +7
==========================================
+ Hits 19856 19923 +67
+ Misses 10182 10178 -4
- Partials 181 182 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `58.75% <ø> (+<0.01%)` | :arrow_up: |
| #python | `70.71% <100.00%> (+0.11%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `84.69% <100.00%> (+10.69%)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.11% <100.00%> (-0.14%)` | :arrow_down: |
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `82.91% <100.00%> (+0.21%)` | :arrow_up: |
| [superset-frontend/src/components/ListView/utils.ts](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvdXRpbHMudHM=) | `82.95% <0.00%> (-2.05%)` | :arrow_down: |
| [superset/utils/pandas\_postprocessing.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nLnB5) | `88.32% <0.00%> (-1.98%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.49% <0.00%> (ø)` | |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `72.35% <0.00%> (ø)` | |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <0.00%> (ø)` | |
| ... and [8 more](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=footer). Last update [f07ca7d...4181017](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9665: [fix] Ensuring cache warmup respects request form data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9665:
URL: https://github.com/apache/incubator-superset/pull/9665#issuecomment-620960217
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=h1) Report
> Merging [#9665](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f07ca7d8364122c1cd66845ccf66095d185bcdcc&el=desc) will **increase** coverage by `4.89%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9665 +/- ##
==========================================
+ Coverage 65.70% 70.60% +4.89%
==========================================
Files 581 581
Lines 30219 30318 +99
Branches 3071 3096 +25
==========================================
+ Hits 19856 21406 +1550
+ Misses 10182 8801 -1381
+ Partials 181 111 -70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.66% <ø> (?)` | |
| #javascript | `58.79% <ø> (+0.04%)` | :arrow_up: |
| #python | `70.72% <100.00%> (+0.12%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `84.69% <100.00%> (+10.69%)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.11% <100.00%> (-0.14%)` | :arrow_down: |
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `82.91% <100.00%> (+0.21%)` | :arrow_up: |
| [superset-frontend/src/components/ListView/utils.ts](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvdXRpbHMudHM=) | `82.95% <0.00%> (-2.05%)` | :arrow_down: |
| [superset/utils/pandas\_postprocessing.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nLnB5) | `88.32% <0.00%> (-1.98%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.49% <0.00%> (ø)` | |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `72.35% <0.00%> (ø)` | |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <0.00%> (ø)` | |
| ... and [155 more](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=footer). Last update [f07ca7d...38f9c12](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] john-bodley commented on a change in pull request #9665: [fix] Ensuring cache warmup respects request form data
Posted by GitBox <gi...@apache.org>.
john-bodley commented on a change in pull request #9665:
URL: https://github.com/apache/incubator-superset/pull/9665#discussion_r417493876
##########
File path: superset/views/utils.py
##########
@@ -99,23 +99,28 @@ def get_viz(
return viz_obj
-def get_form_data(slice_id=None, use_slice_data=False):
+def get_form_data(
+ slice_id: Optional[int] = None, use_slice_data: bool = False
+) -> Tuple[Dict[str, Any], Optional[Slice]]:
form_data = {}
- post_data = request.form.get("form_data")
+ request_form_data = request.form.get("form_data")
request_args_data = request.args.get("form_data")
- # Supporting POST
- if post_data:
- form_data.update(json.loads(post_data))
- # request params can overwrite post body
+ if request_form_data:
+ form_data.update(json.loads(request_form_data))
+ # request params can overwrite the body
if request_args_data:
form_data.update(json.loads(request_args_data))
+ # Fallback to using the Flask globals (used for cache warmup) if defined.
+ if not form_data and hasattr(g, "form_data"):
+ form_data = getattr(g, "form_data")
+
url_id = request.args.get("r")
if url_id:
saved_url = db.session.query(models.Url).filter_by(id=url_id).first()
if saved_url:
url_str = parse.unquote_plus(
- saved_url.url.split("?")[1][10:], encoding="utf-8", errors=None
+ saved_url.url.split("?")[1][10:], encoding="utf-8"
Review comment:
@villebro `unquote_plus` was raising a typing issue as it expected `errors` to be of type `str`. Per [here](https://github.com/python/cpython/blob/master/Lib/urllib/parse.py#L653) it seems if `errors is None` it gets set to `"replace"` which is the default, thus there's no need to specify it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9665: [fix] Ensuring cache warmup respects request form data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9665:
URL: https://github.com/apache/incubator-superset/pull/9665#issuecomment-620960217
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=h1) Report
> Merging [#9665](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f07ca7d8364122c1cd66845ccf66095d185bcdcc&el=desc) will **decrease** coverage by `6.95%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9665 +/- ##
==========================================
- Coverage 65.70% 58.75% -6.96%
==========================================
Files 581 399 -182
Lines 30219 12469 -17750
Branches 3071 3078 +7
==========================================
- Hits 19856 7326 -12530
+ Misses 10182 4961 -5221
- Partials 181 182 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `58.75% <ø> (+<0.01%)` | :arrow_up: |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/ListView/utils.ts](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvdXRpbHMudHM=) | `82.95% <0.00%> (-2.05%)` | :arrow_down: |
| [superset-frontend/src/welcome/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3dlbGNvbWUvQXBwLmpzeA==) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/components/Menu/Menu.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9NZW51LmpzeA==) | `87.50% <0.00%> (ø)` | |
| [superset/db\_engine\_specs/db2.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RiMi5weQ==) | | |
| [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | | |
| [superset/dashboards/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9kZWxldGUucHk=) | | |
| [superset/models/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3RhZ3MucHk=) | | |
| [superset/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvZXhjZXB0aW9ucy5weQ==) | | |
| [superset/models/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NjaGVkdWxlcy5weQ==) | | |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | | |
| ... and [174 more](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=footer). Last update [f07ca7d...4181017](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9665: [fix] Ensuring cache warmup respects request form data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9665:
URL: https://github.com/apache/incubator-superset/pull/9665#issuecomment-620960217
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=h1) Report
> Merging [#9665](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f07ca7d8364122c1cd66845ccf66095d185bcdcc&el=desc) will **increase** coverage by `0.05%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9665 +/- ##
==========================================
+ Coverage 65.70% 65.75% +0.05%
==========================================
Files 581 581
Lines 30219 30318 +99
Branches 3071 3096 +25
==========================================
+ Hits 19856 19937 +81
- Misses 10182 10200 +18
Partials 181 181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `58.79% <ø> (+0.04%)` | :arrow_up: |
| #python | `70.65% <100.00%> (+0.05%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `84.69% <100.00%> (+10.69%)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.88% <100.00%> (-0.36%)` | :arrow_down: |
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `82.91% <100.00%> (+0.21%)` | :arrow_up: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [...explore/components/controls/AdhocFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9BZGhvY0ZpbHRlckNvbnRyb2wuanN4) | `60.78% <0.00%> (-4.70%)` | :arrow_down: |
| [superset-frontend/src/components/ListView/utils.ts](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvdXRpbHMudHM=) | `82.95% <0.00%> (-2.05%)` | :arrow_down: |
| [superset/utils/pandas\_postprocessing.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nLnB5) | `88.32% <0.00%> (-1.98%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.97% <0.00%> (-0.90%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.49% <0.00%> (ø)` | |
| ... and [17 more](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=footer). Last update [f07ca7d...38f9c12](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9665: [fix] Ensuring cache warmup respects request form data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9665:
URL: https://github.com/apache/incubator-superset/pull/9665#issuecomment-620960217
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=h1) Report
> Merging [#9665](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f07ca7d8364122c1cd66845ccf66095d185bcdcc&el=desc) will **increase** coverage by `0.05%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9665 +/- ##
==========================================
+ Coverage 65.70% 65.75% +0.05%
==========================================
Files 581 581
Lines 30219 30318 +99
Branches 3071 3096 +25
==========================================
+ Hits 19856 19937 +81
- Misses 10182 10200 +18
Partials 181 181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `58.79% <ø> (+0.04%)` | :arrow_up: |
| #python | `70.65% <100.00%> (+0.05%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `84.69% <100.00%> (+10.69%)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.88% <100.00%> (-0.36%)` | :arrow_down: |
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `82.91% <100.00%> (+0.21%)` | :arrow_up: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [...explore/components/controls/AdhocFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9BZGhvY0ZpbHRlckNvbnRyb2wuanN4) | `60.78% <0.00%> (-4.70%)` | :arrow_down: |
| [superset-frontend/src/components/ListView/utils.ts](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvdXRpbHMudHM=) | `82.95% <0.00%> (-2.05%)` | :arrow_down: |
| [superset/utils/pandas\_postprocessing.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nLnB5) | `88.32% <0.00%> (-1.98%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.97% <0.00%> (-0.90%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.49% <0.00%> (ø)` | |
| ... and [17 more](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=footer). Last update [f07ca7d...38f9c12](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9665: [fix] Ensuring cache warmup respects request form data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9665:
URL: https://github.com/apache/incubator-superset/pull/9665#issuecomment-620960217
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=h1) Report
> Merging [#9665](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f07ca7d8364122c1cd66845ccf66095d185bcdcc&el=desc) will **decrease** coverage by `0.03%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9665 +/- ##
==========================================
- Coverage 65.70% 65.66% -0.04%
==========================================
Files 581 581
Lines 30219 30318 +99
Branches 3071 3096 +25
==========================================
+ Hits 19856 19909 +53
- Misses 10182 10228 +46
Partials 181 181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `58.79% <ø> (+0.04%)` | :arrow_up: |
| #python | `70.49% <100.00%> (-0.10%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `84.69% <100.00%> (+10.69%)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.88% <100.00%> (-0.36%)` | :arrow_down: |
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `82.91% <100.00%> (+0.21%)` | :arrow_up: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `58.92% <0.00%> (-21.43%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `45.83% <0.00%> (-20.84%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [...explore/components/controls/AdhocFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9BZGhvY0ZpbHRlckNvbnRyb2wuanN4) | `60.78% <0.00%> (-4.70%)` | :arrow_down: |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `83.90% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `84.47% <0.00%> (-2.39%)` | :arrow_down: |
| [superset-frontend/src/components/ListView/utils.ts](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvdXRpbHMudHM=) | `82.95% <0.00%> (-2.05%)` | :arrow_down: |
| ... and [22 more](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=footer). Last update [f07ca7d...38f9c12](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] john-bodley commented on a change in pull request #9665: [fix] Ensuring cache warmup respects request form data
Posted by GitBox <gi...@apache.org>.
john-bodley commented on a change in pull request #9665:
URL: https://github.com/apache/incubator-superset/pull/9665#discussion_r417032478
##########
File path: superset/views/utils.py
##########
@@ -101,15 +101,18 @@ def get_viz(
def get_form_data(slice_id=None, use_slice_data=False):
form_data = {}
- post_data = request.form.get("form_data")
Review comment:
@villebro I was spinning my wheels for quite some time trying to get `test_request_context()` to work and then realize that this isn't explicitly related to the POST method and not is the body of the request a JSON object, i.e., the `form_data` field is actually further encoded as a JSON object.
The form-data is messy and we probably should strive to standardize this at some stage. For now I've renamed `post_data` as `request_form_data` which is more accurate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] john-bodley commented on pull request #9665: [fix] Ensuring cache warmup respects request form data
Posted by GitBox <gi...@apache.org>.
john-bodley commented on pull request #9665:
URL: https://github.com/apache/incubator-superset/pull/9665#issuecomment-620955657
@villebro I've updated the PR to use the somewhat scary `get_form_data` method. Though the method is complex I do prefer having this all housed in one place as it minimizes potential regressions (which is kind of how we ended up here).
I've added some basic unit tests to `get_from_data` as well as addition unit tests to the Jinja macros.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] john-bodley commented on a change in pull request #9665: [fix] Ensuring cache warmup respects request form data
Posted by GitBox <gi...@apache.org>.
john-bodley commented on a change in pull request #9665:
URL: https://github.com/apache/incubator-superset/pull/9665#discussion_r417493876
##########
File path: superset/views/utils.py
##########
@@ -99,23 +99,28 @@ def get_viz(
return viz_obj
-def get_form_data(slice_id=None, use_slice_data=False):
+def get_form_data(
+ slice_id: Optional[int] = None, use_slice_data: bool = False
+) -> Tuple[Dict[str, Any], Optional[Slice]]:
form_data = {}
- post_data = request.form.get("form_data")
+ request_form_data = request.form.get("form_data")
request_args_data = request.args.get("form_data")
- # Supporting POST
- if post_data:
- form_data.update(json.loads(post_data))
- # request params can overwrite post body
+ if request_form_data:
+ form_data.update(json.loads(request_form_data))
+ # request params can overwrite the body
if request_args_data:
form_data.update(json.loads(request_args_data))
+ # Fallback to using the Flask globals (used for cache warmup) if defined.
+ if not form_data and hasattr(g, "form_data"):
+ form_data = getattr(g, "form_data")
+
url_id = request.args.get("r")
if url_id:
saved_url = db.session.query(models.Url).filter_by(id=url_id).first()
if saved_url:
url_str = parse.unquote_plus(
- saved_url.url.split("?")[1][10:], encoding="utf-8", errors=None
+ saved_url.url.split("?")[1][10:], encoding="utf-8"
Review comment:
@villebro `unquote_plus` was raising a typing issue as it expected `errors` to be of type `str`. Per [here](https://github.com/python/cpython/blob/master/Lib/urllib/parse.py#L653) it seems if `errors is None` it gets set to `replace` which is the default, thus there's no need to specify it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9665: [fix] Ensuring cache warmup respects request form data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9665:
URL: https://github.com/apache/incubator-superset/pull/9665#issuecomment-620960217
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=h1) Report
> Merging [#9665](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f07ca7d8364122c1cd66845ccf66095d185bcdcc&el=desc) will **increase** coverage by `0.06%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9665 +/- ##
==========================================
+ Coverage 65.70% 65.76% +0.06%
==========================================
Files 581 581
Lines 30219 30283 +64
Branches 3071 3078 +7
==========================================
+ Hits 19856 19917 +61
- Misses 10182 10184 +2
- Partials 181 182 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `58.75% <ø> (+<0.01%)` | :arrow_up: |
| #python | `70.68% <100.00%> (+0.08%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `84.69% <100.00%> (+10.69%)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.11% <100.00%> (-0.14%)` | :arrow_down: |
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `82.91% <100.00%> (+0.21%)` | :arrow_up: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `80.00% <0.00%> (-15.00%)` | :arrow_down: |
| [superset-frontend/src/components/ListView/utils.ts](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvdXRpbHMudHM=) | `82.95% <0.00%> (-2.05%)` | :arrow_down: |
| [superset/utils/pandas\_postprocessing.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nLnB5) | `88.32% <0.00%> (-1.98%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.49% <0.00%> (ø)` | |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `72.35% <0.00%> (ø)` | |
| ... and [9 more](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=footer). Last update [f07ca7d...4181017](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9665: [fix] Ensuring cache warmup respects request form data
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9665:
URL: https://github.com/apache/incubator-superset/pull/9665#issuecomment-620960217
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=h1) Report
> Merging [#9665](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f07ca7d8364122c1cd66845ccf66095d185bcdcc&el=desc) will **decrease** coverage by `6.91%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9665 +/- ##
==========================================
- Coverage 65.70% 58.79% -6.92%
==========================================
Files 581 399 -182
Lines 30219 12507 -17712
Branches 3071 3096 +25
==========================================
- Hits 19856 7353 -12503
+ Misses 10182 4973 -5209
Partials 181 181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `58.79% <ø> (+0.04%)` | :arrow_up: |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...explore/components/controls/AdhocFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9BZGhvY0ZpbHRlckNvbnRyb2wuanN4) | `60.78% <0.00%> (-4.70%)` | :arrow_down: |
| [superset-frontend/src/components/ListView/utils.ts](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvdXRpbHMudHM=) | `82.95% <0.00%> (-2.05%)` | :arrow_down: |
| [superset-frontend/src/welcome/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3dlbGNvbWUvQXBwLmpzeA==) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/explore/constants.js](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29uc3RhbnRzLmpz) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/components/Menu/Menu.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9NZW51LmpzeA==) | `87.50% <0.00%> (ø)` | |
| [...ntend/src/explore/components/AdhocFilterOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlck9wdGlvbi5qc3g=) | `57.69% <0.00%> (ø)` | |
| [.../src/explore/components/AdhocFilterEditPopover.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyLmpzeA==) | `57.44% <0.00%> (ø)` | |
| [superset/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvZXhjZXB0aW9ucy5weQ==) | | |
| [superset/views/database/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZmlsdGVycy5weQ==) | | |
| [superset/datasets/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvc2NoZW1hcy5weQ==) | | |
| ... and [180 more](https://codecov.io/gh/apache/incubator-superset/pull/9665/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=footer). Last update [f07ca7d...38f9c12](https://codecov.io/gh/apache/incubator-superset/pull/9665?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on pull request #9665: [fix] Ensuring cache warmup respects request form data
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #9665:
URL: https://github.com/apache/incubator-superset/pull/9665#issuecomment-620377827
@john-bodley I agree that it's not optimal to be passing around `form_data` in many different contexts, but in the short term this is probably the best solution. To make this more robust, perhaps we should introduce a util that has this logic in one central place? There we could also add any necessary documentation to explain why this is necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] john-bodley removed a comment on pull request #9665: [fix] Ensuring cache warmup respects request form data
Posted by GitBox <gi...@apache.org>.
john-bodley removed a comment on pull request #9665:
URL: https://github.com/apache/incubator-superset/pull/9665#issuecomment-620689730
@villebro I agree regarding the bloated/complex nature. I might rename that method `get_form_data_and_slice` and have a `get_form_data` method which merely gets the form-data.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org