[GitHub] [airflow] nuclearpinguin commented on a change in pull request #7371: [AIRFLOW-6737] Enable kubernetes diagnostics for all kubernetes tests

[GitBox <gi...@apache.org>]

nuclearpinguin commented on a change in pull request #7371: [AIRFLOW-6737] Enable kubernetes diagnostics for all kubernetes tests
URL: https://github.com/apache/airflow/pull/7371#discussion_r375356701
 
 

 ##########
 File path: tests/runtime/kubernetes/test_kubernetes_executor.py
 ##########
 @@ -66,6 +64,10 @@ def setUp(self):
     def tearDown(self):
         self.session.close()
 
+    @classmethod
+    def tearDownClass(cls) -> None:
+        dump_kubernetes_logs()
 
 Review comment:
   Wouldn't it be better to use `tearDown`? Then we will achieve more information (and more noise). 
   Edit: maybe we can use this feature? https://docs.pytest.org/en/latest/example/simple.html#post-process-test-reports-failures

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services