You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tubemq.apache.org by GitBox <gi...@apache.org> on 2020/12/09 11:48:56 UTC
[GitHub] [incubator-tubemq] gosonzhang opened a new pull request #346: [TUBEMQ-446]Small bugs fix that do not affect the main logics
gosonzhang opened a new pull request #346:
URL: https://github.com/apache/incubator-tubemq/pull/346
Found some small bugs
1. AddressUtils.getIPV4LocalAddress() should first check whether localIPAddress has been set, and use it directly under the premise that it has been set to reduce unnecessary get operations;
2. The fetchCount parameter in MessageConsumerExample may be negative, so the executorService object should not use fetchCount as the initial value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tubemq] codecov-io edited a comment on pull request #346: [TUBEMQ-446]Small bugs fix that do not affect the main logics
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #346:
URL: https://github.com/apache/incubator-tubemq/pull/346#issuecomment-741912756
# [Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/346?src=pr&el=h1) Report
> Merging [#346](https://codecov.io/gh/apache/incubator-tubemq/pull/346?src=pr&el=desc) (03d1cb0) into [master](https://codecov.io/gh/apache/incubator-tubemq/commit/43d2e7b9f92b350aca0764df11d1724b35425873?el=desc) (43d2e7b) will **decrease** coverage by `0.00%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-tubemq/pull/346?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #346 +/- ##
===========================================
- Coverage 7.73% 7.73% -0.01%
Complexity 464 464
===========================================
Files 258 258
Lines 27891 27892 +1
Branches 4579 4579
===========================================
Hits 2157 2157
- Misses 25268 25269 +1
Partials 466 466
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-tubemq/pull/346?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...org/apache/tubemq/corebase/utils/AddressUtils.java](https://codecov.io/gh/apache/incubator-tubemq/pull/346/diff?src=pr&el=tree#diff-dHViZW1xLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1YmVtcS9jb3JlYmFzZS91dGlscy9BZGRyZXNzVXRpbHMuamF2YQ==) | `10.71% <0.00%> (-0.16%)` | `5.00 <2.00> (ø)` | |
| [...rg/apache/tubemq/server/tools/cli/CliConsumer.java](https://codecov.io/gh/apache/incubator-tubemq/pull/346/diff?src=pr&el=tree#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci90b29scy9jbGkvQ2xpQ29uc3VtZXIuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../tubemq/corebase/policies/FlowCtrlRuleHandler.java](https://codecov.io/gh/apache/incubator-tubemq/pull/346/diff?src=pr&el=tree#diff-dHViZW1xLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1YmVtcS9jb3JlYmFzZS9wb2xpY2llcy9GbG93Q3RybFJ1bGVIYW5kbGVyLmphdmE=) | `42.52% <0.00%> (ø)` | `34.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/346?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/346?src=pr&el=footer). Last update [43d2e7b...03d1cb0](https://codecov.io/gh/apache/incubator-tubemq/pull/346?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tubemq] gosonzhang merged pull request #346: [TUBEMQ-446]Small bugs fix that do not affect the main logics
Posted by GitBox <gi...@apache.org>.
gosonzhang merged pull request #346:
URL: https://github.com/apache/incubator-tubemq/pull/346
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tubemq] codecov-io commented on pull request #346: [TUBEMQ-446]Small bugs fix that do not affect the main logics
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #346:
URL: https://github.com/apache/incubator-tubemq/pull/346#issuecomment-741912756
# [Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/346?src=pr&el=h1) Report
> Merging [#346](https://codecov.io/gh/apache/incubator-tubemq/pull/346?src=pr&el=desc) (31eff41) into [master](https://codecov.io/gh/apache/incubator-tubemq/commit/43d2e7b9f92b350aca0764df11d1724b35425873?el=desc) (43d2e7b) will **decrease** coverage by `0.00%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-tubemq/pull/346?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #346 +/- ##
===========================================
- Coverage 7.73% 7.73% -0.01%
Complexity 464 464
===========================================
Files 258 258
Lines 27891 27892 +1
Branches 4579 4579
===========================================
Hits 2157 2157
- Misses 25268 25269 +1
Partials 466 466
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-tubemq/pull/346?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...org/apache/tubemq/corebase/utils/AddressUtils.java](https://codecov.io/gh/apache/incubator-tubemq/pull/346/diff?src=pr&el=tree#diff-dHViZW1xLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1YmVtcS9jb3JlYmFzZS91dGlscy9BZGRyZXNzVXRpbHMuamF2YQ==) | `10.71% <0.00%> (-0.16%)` | `5.00 <2.00> (ø)` | |
| [...rg/apache/tubemq/server/tools/cli/CliConsumer.java](https://codecov.io/gh/apache/incubator-tubemq/pull/346/diff?src=pr&el=tree#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci90b29scy9jbGkvQ2xpQ29uc3VtZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [.../tubemq/corebase/policies/FlowCtrlRuleHandler.java](https://codecov.io/gh/apache/incubator-tubemq/pull/346/diff?src=pr&el=tree#diff-dHViZW1xLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1YmVtcS9jb3JlYmFzZS9wb2xpY2llcy9GbG93Q3RybFJ1bGVIYW5kbGVyLmphdmE=) | `42.52% <0.00%> (ø)` | `34.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/346?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/346?src=pr&el=footer). Last update [43d2e7b...03d1cb0](https://codecov.io/gh/apache/incubator-tubemq/pull/346?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org