[jira] [Comment Edited] (SUREFIRE-1546) JUnit 5 runner does not honor JUnit 5 display names

["Tibor Digana (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SUREFIRE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816403#comment-16816403 ] 

Tibor Digana edited comment on SUREFIRE-1546 at 4/12/19 4:11 PM:
-----------------------------------------------------------------

[~Srdo]
We are aware of this. I want to make you sure that we do not want to break backwards compatibility in version 3.0.0-M4 (broken in M6).
Therefore a complex configuration is required and every user may change this behavior on the level of:

1. POM configuration
2. Java implementation like a plugin to Surefire plugin (Open Closed Design Principle) done by user - see the XML attribute {{implementation}}

Here is an example of stateless XML reporter


{code:xml}
<plugin>
    <artifactId>maven-surefire-plugin</artifactId>
    <version>3.0.0-SNAPSHOT</version>
    <configuration>
        <statelessReporter implementation="org.apache.maven.plugin.surefire.extensions.DefaultStatelessReporter">
            <disableXmlReport>true</disableXmlReport>
            <useFileName>DEFAULT</useFileName>
            <useTestCaseClassName>PHRASED</useTestCaseClassName>
            <useTestCaseMethodName>PHRASED</useTestCaseMethodName>
        </statelessReporter>
    </configuration>
</plugin>
{code}

and there are next two reporters. For more information see https://github.com/apache/maven-surefire/pull/226#issuecomment-480264926
The aim of version {{3.0.0}} is to have such of these extensions which open possibility for the user to change the behavior of this plugin without asking us development team. This brings a certain freedom for everyone.
We do not want to break behavior in versions but we have to break only few config parameters that will be moved to a block like the above, and one will be removed, and filtering of classes would not be like{{ \*\*/\*\*/\*Some\*Test.java}} but it will follow fully classified class names e.g. {{\*\*.\*\*.\*Some\*Test}}. More extensions will be added.


was (Author: tibor17):
[~Srdo]
We are aware of this. I want to make you sure that we do not want to break backwards compatibility in version 3.0.0-M4 (broken in M6).
Therefore a complex configuration is required and every user may change this behavior on the level of:

1. POM configuration
2. Java implementation like a plugin to Surefire plugin (Open Closed Design Principle) done by user - see the XML attribute {{implementation}}

Here is an example of stateless XML reporter


{code:xml}
<plugin>
    <artifactId>maven-surefire-plugin</artifactId>
    <version>3.0.0-SNAPSHOT</version>
    <configuration>
        <statelessReporter implementation="org.apache.maven.plugin.surefire.extensions.DefaultStatelessReporter">
            <disableXmlReport>true</disableXmlReport>
            <useFileName>DEFAULT</useFileName>
            <useTestCaseClassName>PHRASED</useTestCaseClassName>
            <useTestCaseMethodName>PHRASED</useTestCaseMethodName>
        </statelessReporter>
    </configuration>
</plugin>
{code}

and there are next two reporters. For more information see https://github.com/apache/maven-surefire/pull/226#issuecomment-480264926
The aim of version {{3.0.0}} is to have such of these extensions which open possibility for the user to change the behavior of this plugin without asking us development team. This brings a certain freedom for everyone.
We do not want to break behavior in versions but we have to break only few config parameters that will be moved to a block like the above, and one will be removed, and filtering of classes would not be like **/**/*Some*Test.java but it will follow fully classified class names e.g. **.**.*Some*Test. More extensions will be added.

> JUnit 5 runner does not honor JUnit 5 display names
> ---------------------------------------------------
>
>                 Key: SUREFIRE-1546
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1546
>             Project: Maven Surefire
>          Issue Type: Bug
>          Components: JUnit 5.x support
>    Affects Versions: 2.22.0
>            Reporter: Romain Manni-Bucau
>            Assignee: Tibor Digana
>            Priority: Major
>              Labels: junit5
>             Fix For: 3.0.0-M4
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> JUnit 5 runner should respect the test @DisplayName instead of displaying the classname if any is defined. Seems last release doesn't support that feature of JUnit 5 making the console output and reports not the expected ones.
>  
> Origin: https://github.com/junit-team/junit5/issues/990



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)