[GitHub] [pulsar] lifepuzzlefun commented on a diff in pull request #19930: [fix][client] Fix DeadLetterProducer creation callback blocking client io thread.

["lifepuzzlefun (via GitHub)" <gi...@apache.org>]

lifepuzzlefun commented on code in PR #19930:
URL: https://github.com/apache/pulsar/pull/19930#discussion_r1154080507


##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java:
##########
@@ -649,7 +649,7 @@ protected CompletableFuture<Void> doReconsumeLater(Message<?> message, AckType a
                 if (reconsumeTimes > this.deadLetterPolicy.getMaxRedeliverCount()
                         && StringUtils.isNotBlank(deadLetterPolicy.getDeadLetterTopic())) {
                     initDeadLetterProducerIfNeeded();
-                    deadLetterProducer.thenAccept(dlqProducer -> {
+                    deadLetterProducer.thenAcceptAsync(dlqProducer -> {

Review Comment:
   changed to internalPinnedExecutor



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org