You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Leemoonsoo <gi...@git.apache.org> on 2017/03/20 03:34:10 UTC

[GitHub] zeppelin pull request #2162: [ZEPPELIN-2286] Some test matrix on Travis ofte...

GitHub user Leemoonsoo opened a pull request:

    https://github.com/apache/zeppelin/pull/2162

    [ZEPPELIN-2286] Some test matrix on Travis often exceeds time limits (50min)

    ### What is this PR for?
    This PR optimize CI test matrix while keeping the same test coverage. 
    
    from
    1. RAT (1~2min)
    2. All modules with -Pbuild-distr flag, spark 2.1 and scala 2.11 (40~50min)
    3. All modules with -Pbuild-distr flag, spark 2.0 and scala 2.11 (40~50min)
    4. spark 1.6 and scala 2.10 (7~9min)
    5. spark 1.6 and scala 2.11 (7~8min)
    7. Selenium (20~23min)
    8. python2 (6~7min)
    9. python3 (6 ~7min)
    Total. 128 ~156min
    
    to
    1. RAT  (1~2min)
    2. Core modules without interpreters (14~15min)
    3. All interpreters except for spark, livy (9~11min)
    4. Spark 2.1 and scala 2.11, livy (7~9min)
    5. Spark 2.0 and scala 2.11 (7~8min)
    6. Spark 1.6 and scala 2.10 (7~8min)
    7. Spark 1.6 and scala 2.11 (7~8min)
    8. Selenium (20~23min)
    9. python2 (6~7min)
    10. python3 (6 ~7min)
    Total. (84 ~98min)
    
    
    
    ### What type of PR is it?
    Improvement
    
    ### Todos
    * [x] - Optimize CI test matrix
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-2286
    
    ### How should this be tested?
    CI green
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Leemoonsoo/zeppelin split_ci_metrics

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2162.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2162
    
----
commit eef5008464d87de98a2b31e4c8d4dcfd5b178de8
Author: Lee moon soo <mo...@apache.org>
Date:   2017-03-19T17:16:59Z

    Move out spark and livy test to separate test metrics

commit 609153bd784460cb87c7ac6fcb1d513210852aba
Author: Lee moon soo <mo...@apache.org>
Date:   2017-03-19T17:21:22Z

    Prevent download spark distribution when unnecessary

commit cb44e707d61fddd54e067c07658e29d423249f5f
Author: Lee moon soo <mo...@apache.org>
Date:   2017-03-19T18:04:31Z

    Define scala.binary.version

commit 4f2ef765963259ac123a150cdd1399aec91b7927
Author: Lee moon soo <mo...@apache.org>
Date:   2017-03-19T18:46:48Z

    set fork count 1

commit e6f59958263c846a7c95bfc33cc42a1942d34d63
Author: Lee moon soo <mo...@apache.org>
Date:   2017-03-19T19:20:07Z

    try set scala.version

commit 944711d65be7242ea6deeaeec07dce9709ebc867
Author: Lee moon soo <mo...@apache.org>
Date:   2017-03-19T19:28:06Z

    configure surefire plugin for zeppelin-server

commit efc044edcc168039ca2bcb2de1afba752a018c89
Author: Lee moon soo <mo...@apache.org>
Date:   2017-03-19T20:23:16Z

    assume spark interpreter may not exists in certain test metrics

commit 29f6629e4e4e96295afd0012e58ef05d637b3334
Author: Lee moon soo <mo...@apache.org>
Date:   2017-03-19T20:46:27Z

    include root pom in -pl

commit a31162d89404eaa98c50f3a234f86ddc9c6fc549
Author: Lee moon soo <mo...@apache.org>
Date:   2017-03-19T21:16:14Z

    Revert "assume spark interpreter may not exists in certain test metrics"
    
    This reverts commit efc044edcc168039ca2bcb2de1afba752a018c89.

commit f9b6da5d02a1748f215b0fc66268d2989086eb79
Author: Lee moon soo <mo...@apache.org>
Date:   2017-03-19T21:28:24Z

    exclude interpreters does not reqruied by zeppelin-server integration test

commit 20c3155be7b1add66fb6451c8b311e4043504fa8
Author: Lee moon soo <mo...@apache.org>
Date:   2017-03-19T21:33:44Z

    try differnt way set global env

commit e1f28e644b0d8a9441a86eaea52aeba118f620a3
Author: Lee moon soo <mo...@apache.org>
Date:   2017-03-19T21:38:09Z

    try differnt way pass params

commit 114cea6e6cec7b45166d074659b70c39e8da35f3
Author: Lee moon soo <mo...@apache.org>
Date:   2017-03-19T22:07:00Z

    add test profile that test interpretes

commit 3c2f55fbd27dff50079a6db47e703b17a7b3eb90
Author: Lee moon soo <mo...@apache.org>
Date:   2017-03-19T22:09:57Z

    fix travis.yml

commit 293d0e19add9011954cda29ee6ba6782d71c67fd
Author: Lee moon soo <mo...@apache.org>
Date:   2017-03-19T22:12:47Z

    add missing env

commit 9fdc8817f051ca6171e59d246e9eb0f03966cbf8
Author: Lee moon soo <mo...@apache.org>
Date:   2017-03-19T22:18:50Z

    fix option

commit 9db2c7139cf832c566e46a9309c7e579a925ffd8
Author: Lee moon soo <mo...@apache.org>
Date:   2017-03-19T22:35:56Z

    fix profiles

commit da5706d6a416e997c68bd71f78f6f05861233ee5
Author: Lee moon soo <mo...@apache.org>
Date:   2017-03-19T23:18:37Z

    exclude spark test from core module test

commit b02adc828110f4dfeda2abb4deda832898d84c59
Author: Lee moon soo <mo...@apache.org>
Date:   2017-03-19T23:55:53Z

    other way to exclude spark from core module test

commit 5179f88d1e870ccab0e903fd3b921c5706e451c7
Author: Lee moon soo <mo...@apache.org>
Date:   2017-03-20T01:14:50Z

    set livy 0.3 explicitly

commit 8af7f38f75fe1d15600a6878025d2d464a4af61c
Author: Lee moon soo <mo...@apache.org>
Date:   2017-03-20T01:20:51Z

    try exclude test in different way

commit f11b4f12dc3a4c572c1054cc4fcc98648d4d7f00
Author: Lee moon soo <mo...@apache.org>
Date:   2017-03-20T01:39:05Z

    add -DfailIfNoTests=false

commit 410899ad548015b7ef9589ce47a6eecde1c3310f
Author: Lee moon soo <mo...@apache.org>
Date:   2017-03-20T02:58:19Z

    remove explicit LIVY_VER

commit 61acecf4d216bba37d5224e028512027de689759
Author: Lee moon soo <mo...@apache.org>
Date:   2017-03-20T03:04:07Z

    Livy 0.2 test does not work

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2162: [HOTFIX] [ZEPPELIN-2286] Fix CI and split some test ma...

Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:

    https://github.com/apache/zeppelin/pull/2162
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2162: [HOTFIX] [ZEPPELIN-2286] Fix CI and split some ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2162


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2162: [HOTFIX] [ZEPPELIN-2286] Fix CI and split some test ma...

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2162
  
    I rebased to current master and CI becomes green!
    Merge this PR to master and branch-0.7 as a hotfix while it significantly reduce chance of failing 2nd and 3rd test matrix by timeout.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2162: [HOTFIX] [ZEPPELIN-2286] Fix CI and split some test ma...

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2162
  
    @sravan-s Test failure `NotebookTest.testAngularObjectRemovalOnInterpreterRestart:699` is already addressed in the commit  https://github.com/apache/zeppelin/commit/00e6aed0c7bc514bc270703b188b841b6835defd#diff-470a9a96b665c7eb7a4d8f2888c3a2ba.
    Also created an issue for future followup https://issues.apache.org/jira/browse/ZEPPELIN-2284.
    
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2162: [HOTFIX] [ZEPPELIN-2286] Fix CI and split some test ma...

Posted by sravan-s <gi...@git.apache.org>.
Github user sravan-s commented on the issue:

    https://github.com/apache/zeppelin/pull/2162
  
    Hi,
    Recently, I have been facing two issues in the CI
    First one is CI getting timed out, which is getting addressed here
    The other one is: 
    `  NotebookTest.testAngularObjectRemovalOnInterpreterRestart:699 expected null, but was:<AngularObject{noteId='2CB425J2J', paragraphId='null', object=object1, name='o1'}>
    `
    from job-3 in the test matrix. Is it getting addressed in this pull request? It is mentioned in the comments of #2154 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---