You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/02 03:08:01 UTC

[GitHub] [flink] czy006 commented on a diff in pull request #21012: [FLINK-29543] Jar Run Rest Handler Support Flink Configuration

czy006 commented on code in PR #21012:
URL: https://github.com/apache/flink/pull/21012#discussion_r1011107976


##########
flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/handlers/JarHandlerParameterTest.java:
##########
@@ -69,6 +71,11 @@ enum ProgramArgsParType {
     static final String[] PROG_ARGS = new String[] {"--host", "localhost", "--port", "1234"};
     static final int PARALLELISM = 4;
 
+    static final Map<String, String> FLINK_CONFIGURATION =
+            ImmutableMap.of(
+                    CoreOptions.DEFAULT_PARALLELISM.key(), "2",

Review Comment:
   Sure, I think unit tests should cover all requested values, including values like: 
   
   - DEFAULT_PARALLELISM
   - RESTORE_MODE
   - SAVEPOINT_IGNORE_UNCLAIMED_STATE
   - SAVEPOINT_PATH
   
   what do you think?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org