You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2014/10/01 01:31:08 UTC

Review Request 26205: Cleaned up Master::addFramework.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26205/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Repository: mesos-git


Description
-------

Similarly to https://reviews.apache.org/r/26204, addFramework only adds the Framework struct into the Master's state. It is the responsibility of the caller to tell the framework it is registered.

This allows us the flexibily to fix MESOS-786 without re-factoring.


Diffs
-----

  src/master/master.cpp a60308f912a1ed81ecd51c677461a8f591d9eb8e 

Diff: https://reviews.apache.org/r/26205/diff/


Testing
-------

make check


Thanks,

Ben Mahler

Re: Review Request 26205: Cleaned up Master::addFramework.

Posted by Vinod Kone <vi...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26205/#review55149
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On Sept. 30, 2014, 11:31 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26205/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2014, 11:31 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Similarly to https://reviews.apache.org/r/26204, addFramework only adds the Framework struct into the Master's state. It is the responsibility of the caller to tell the framework it is registered.
> 
> This allows us the flexibily to fix MESOS-786 without re-factoring.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp a60308f912a1ed81ecd51c677461a8f591d9eb8e 
> 
> Diff: https://reviews.apache.org/r/26205/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>