[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27643: [SPARK-30886][SQL] Deprecate LTRIM, RTRIM, and two-parameter TRIM functions

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #27643: [SPARK-30886][SQL] Deprecate LTRIM, RTRIM, and two-parameter TRIM functions
URL: https://github.com/apache/spark/pull/27643#discussion_r388402537
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
 ##########
 @@ -1839,13 +1842,25 @@ class Analyzer(
                   }
                   AggregateExpression(agg, Complete, isDistinct, filter)
                 // This function is not an aggregate function, just return the resolved one.
-                case other =>
-                  if (isDistinct || filter.isDefined) {
-                    failAnalysis("DISTINCT or FILTER specified, " +
-                      s"but ${other.prettyName} is not an aggregate function")
-                  } else {
-                    other
+                case other if (isDistinct || filter.isDefined) =>
+                  failAnalysis("DISTINCT or FILTER specified, " +
+                    s"but ${other.prettyName} is not an aggregate function")
+                case e @ (_: StringTrimLeft | _: StringTrimRight) =>
 
 Review comment:
   Ur, did you change your mind? This was due to your comment.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org