svn commit: r1401573 - /ofbiz/trunk/specialpurpose/example/servicedef/secas.xml

[ad...@apache.org]

Author: adrianc
Date: Wed Oct 24 07:46:39 2012
New Revision: 1401573

URL: http://svn.apache.org/viewvc?rev=1401573&view=rev
Log:
Improved the FIXME comment in my last commit.

Modified:
    ofbiz/trunk/specialpurpose/example/servicedef/secas.xml

Modified: ofbiz/trunk/specialpurpose/example/servicedef/secas.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/example/servicedef/secas.xml?rev=1401573&r1=1401572&r2=1401573&view=diff
==============================================================================
--- ofbiz/trunk/specialpurpose/example/servicedef/secas.xml (original)
+++ ofbiz/trunk/specialpurpose/example/servicedef/secas.xml Wed Oct 24 07:46:39 2012
@@ -24,8 +24,7 @@ under the License.
         <action service="createExampleStatus" mode="sync"/>
     </eca>
     <!-- FIXME: This ECA assumes the updateExample service was called with a statusId parameter.
-         The ECAs in this file demonstrate a bad design pattern. The action services should be
-         invoked within the called service, not invoked by ECAs. -->
+         The condition should be improved to check for statusId being not empty. -->
     <!--
     <eca service="updateExample" event="return">
         <condition-field field-name="statusId" operator="not-equals" to-field-name="oldStatusId"/>