[jira] [Comment Edited] (THRIFT-2784) Eliminate compiler warnings in generated C++ code

["Jens Geyer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14172334#comment-14172334 ] 

Jens Geyer edited comment on THRIFT-2784 at 10/15/14 1:01 PM:
--------------------------------------------------------------

That enum is an edge case. The IDL allows it syntactically, but some environments have problems with empty enus. I agree with removal, but we should keep that in mind and probably fix it later (read. disallow empty enums)


was (Author: jensg):
That enum is an edge case. The IDL allows it syntactically, but some envorinments have problems with it. I agree with removel, but we should keep that in mind and probably fix it later (read. disallow empty enums)

> Eliminate compiler warnings in generated C++ code
> -------------------------------------------------
>
>                 Key: THRIFT-2784
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2784
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C++ - Compiler
>    Affects Versions: 0.9.1
>            Reporter: John Campbell
>            Assignee: Roger Meier
>            Priority: Minor
>         Attachments: thrift-2784-eliminate_generated_cpp_warnings.patch
>
>
> Generated C++ classes generate compiler warnings when the using code is compiled with -Wall -Wextra -pedantic.
> Specifically, there are two types of warnings in the generated code:
> 1. Exceptions don't call parent constructor
> 2. Unused warnings
> (there may be others in the generated code, however no others have been found at this time)
> Ideally, the generated C++ code should not have these errors.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)