You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Grant Ingersoll (JIRA)" <ji...@apache.org> on 2008/08/13 16:56:44 UTC

[jira] Created: (SOLR-696) NamedListCodec doesn't properly write Iterable items

NamedListCodec doesn't properly write Iterable items
----------------------------------------------------

                 Key: SOLR-696
                 URL: https://issues.apache.org/jira/browse/SOLR-696
             Project: Solr
          Issue Type: Bug
    Affects Versions: 1.3
            Reporter: Grant Ingersoll
            Assignee: Grant Ingersoll
             Fix For: 1.3


The NamedListCodec doesn't properly write Iterable items on line 224.  All the other instanceof checks return true, while that one falls through and returns false.

Exception is:
 Caused by: java.lang.ClassCastException: java.util.ArrayList
     [java]     at org.apache.solr.common.util.NamedListCodec.readNamedList(NamedListCodec.java:108)
     [java]     at org.apache.solr.common.util.NamedListCodec.readVal(NamedListCodec.java:155)
     [java]     at org.apache.solr.common.util.NamedListCodec.readOrderedMap(NamedListCodec.java:98)
     [java]     at org.apache.solr.common.util.NamedListCodec.readVal(NamedListCodec.java:154)
     [java]     at org.apache.solr.common.util.NamedListCodec.readOrderedMap(NamedListCodec.java:98)
     [java]     at org.apache.solr.common.util.NamedListCodec.readVal(NamedListCodec.java:154)
     [java]     at org.apache.solr.common.util.NamedListCodec.unmarshal(NamedListCodec.java:89)
     [java]     at org.apache.solr.client.solrj.impl.BinaryResponseParser.processResponse(BinaryResponseParser.java:39)
     [java]     at org.apache.solr.client.solrj.impl.CommonsHttpSolrServer.request(CommonsHttpSolrServer.java:385)

Test and patch shortly


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-696) NamedListCodec doesn't properly write Iterable items

Posted by "Grant Ingersoll (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622237#action_12622237 ] 

Grant Ingersoll commented on SOLR-696:
--------------------------------------

Just for a little backfill, this came about using the SpellcheckComponent with the BinaryResponseParser used in SolrJ.

> NamedListCodec doesn't properly write Iterable items
> ----------------------------------------------------
>
>                 Key: SOLR-696
>                 URL: https://issues.apache.org/jira/browse/SOLR-696
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 1.3
>            Reporter: Grant Ingersoll
>            Assignee: Grant Ingersoll
>             Fix For: 1.3
>
>
> The NamedListCodec doesn't properly write Iterable items on line 224.  All the other instanceof checks return true, while that one falls through and returns false.
> Exception is:
>  Caused by: java.lang.ClassCastException: java.util.ArrayList
>      [java]     at org.apache.solr.common.util.NamedListCodec.readNamedList(NamedListCodec.java:108)
>      [java]     at org.apache.solr.common.util.NamedListCodec.readVal(NamedListCodec.java:155)
>      [java]     at org.apache.solr.common.util.NamedListCodec.readOrderedMap(NamedListCodec.java:98)
>      [java]     at org.apache.solr.common.util.NamedListCodec.readVal(NamedListCodec.java:154)
>      [java]     at org.apache.solr.common.util.NamedListCodec.readOrderedMap(NamedListCodec.java:98)
>      [java]     at org.apache.solr.common.util.NamedListCodec.readVal(NamedListCodec.java:154)
>      [java]     at org.apache.solr.common.util.NamedListCodec.unmarshal(NamedListCodec.java:89)
>      [java]     at org.apache.solr.client.solrj.impl.BinaryResponseParser.processResponse(BinaryResponseParser.java:39)
>      [java]     at org.apache.solr.client.solrj.impl.CommonsHttpSolrServer.request(CommonsHttpSolrServer.java:385)
> Test and patch shortly

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SOLR-696) NamedListCodec doesn't properly write Iterable items

Posted by "Grant Ingersoll (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Grant Ingersoll resolved SOLR-696.
----------------------------------

    Resolution: Fixed

Committed.

> NamedListCodec doesn't properly write Iterable items
> ----------------------------------------------------
>
>                 Key: SOLR-696
>                 URL: https://issues.apache.org/jira/browse/SOLR-696
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 1.3
>            Reporter: Grant Ingersoll
>            Assignee: Grant Ingersoll
>             Fix For: 1.3
>
>         Attachments: SOLR-696.patch
>
>
> The NamedListCodec doesn't properly write Iterable items on line 224.  All the other instanceof checks return true, while that one falls through and returns false.
> Exception is:
>  Caused by: java.lang.ClassCastException: java.util.ArrayList
>      [java]     at org.apache.solr.common.util.NamedListCodec.readNamedList(NamedListCodec.java:108)
>      [java]     at org.apache.solr.common.util.NamedListCodec.readVal(NamedListCodec.java:155)
>      [java]     at org.apache.solr.common.util.NamedListCodec.readOrderedMap(NamedListCodec.java:98)
>      [java]     at org.apache.solr.common.util.NamedListCodec.readVal(NamedListCodec.java:154)
>      [java]     at org.apache.solr.common.util.NamedListCodec.readOrderedMap(NamedListCodec.java:98)
>      [java]     at org.apache.solr.common.util.NamedListCodec.readVal(NamedListCodec.java:154)
>      [java]     at org.apache.solr.common.util.NamedListCodec.unmarshal(NamedListCodec.java:89)
>      [java]     at org.apache.solr.client.solrj.impl.BinaryResponseParser.processResponse(BinaryResponseParser.java:39)
>      [java]     at org.apache.solr.client.solrj.impl.CommonsHttpSolrServer.request(CommonsHttpSolrServer.java:385)
> Test and patch shortly

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Work started: (SOLR-696) NamedListCodec doesn't properly write Iterable items

Posted by "Grant Ingersoll (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Work on SOLR-696 started by Grant Ingersoll.

> NamedListCodec doesn't properly write Iterable items
> ----------------------------------------------------
>
>                 Key: SOLR-696
>                 URL: https://issues.apache.org/jira/browse/SOLR-696
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 1.3
>            Reporter: Grant Ingersoll
>            Assignee: Grant Ingersoll
>             Fix For: 1.3
>
>         Attachments: SOLR-696.patch
>
>
> The NamedListCodec doesn't properly write Iterable items on line 224.  All the other instanceof checks return true, while that one falls through and returns false.
> Exception is:
>  Caused by: java.lang.ClassCastException: java.util.ArrayList
>      [java]     at org.apache.solr.common.util.NamedListCodec.readNamedList(NamedListCodec.java:108)
>      [java]     at org.apache.solr.common.util.NamedListCodec.readVal(NamedListCodec.java:155)
>      [java]     at org.apache.solr.common.util.NamedListCodec.readOrderedMap(NamedListCodec.java:98)
>      [java]     at org.apache.solr.common.util.NamedListCodec.readVal(NamedListCodec.java:154)
>      [java]     at org.apache.solr.common.util.NamedListCodec.readOrderedMap(NamedListCodec.java:98)
>      [java]     at org.apache.solr.common.util.NamedListCodec.readVal(NamedListCodec.java:154)
>      [java]     at org.apache.solr.common.util.NamedListCodec.unmarshal(NamedListCodec.java:89)
>      [java]     at org.apache.solr.client.solrj.impl.BinaryResponseParser.processResponse(BinaryResponseParser.java:39)
>      [java]     at org.apache.solr.client.solrj.impl.CommonsHttpSolrServer.request(CommonsHttpSolrServer.java:385)
> Test and patch shortly

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-696) NamedListCodec doesn't properly write Iterable items

Posted by "Grant Ingersoll (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Grant Ingersoll updated SOLR-696:
---------------------------------

    Attachment: SOLR-696.patch

Adds return true in the Iterable clause and a test case.

> NamedListCodec doesn't properly write Iterable items
> ----------------------------------------------------
>
>                 Key: SOLR-696
>                 URL: https://issues.apache.org/jira/browse/SOLR-696
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 1.3
>            Reporter: Grant Ingersoll
>            Assignee: Grant Ingersoll
>             Fix For: 1.3
>
>         Attachments: SOLR-696.patch
>
>
> The NamedListCodec doesn't properly write Iterable items on line 224.  All the other instanceof checks return true, while that one falls through and returns false.
> Exception is:
>  Caused by: java.lang.ClassCastException: java.util.ArrayList
>      [java]     at org.apache.solr.common.util.NamedListCodec.readNamedList(NamedListCodec.java:108)
>      [java]     at org.apache.solr.common.util.NamedListCodec.readVal(NamedListCodec.java:155)
>      [java]     at org.apache.solr.common.util.NamedListCodec.readOrderedMap(NamedListCodec.java:98)
>      [java]     at org.apache.solr.common.util.NamedListCodec.readVal(NamedListCodec.java:154)
>      [java]     at org.apache.solr.common.util.NamedListCodec.readOrderedMap(NamedListCodec.java:98)
>      [java]     at org.apache.solr.common.util.NamedListCodec.readVal(NamedListCodec.java:154)
>      [java]     at org.apache.solr.common.util.NamedListCodec.unmarshal(NamedListCodec.java:89)
>      [java]     at org.apache.solr.client.solrj.impl.BinaryResponseParser.processResponse(BinaryResponseParser.java:39)
>      [java]     at org.apache.solr.client.solrj.impl.CommonsHttpSolrServer.request(CommonsHttpSolrServer.java:385)
> Test and patch shortly

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.