You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@beehive.apache.org by "Zach Smith (JIRA)" <de...@beehive.apache.org> on 2005/08/23 20:35:11 UTC

[jira] Closed: (BEEHIVE-135) Version checking codegen cleanup

     [ http://issues.apache.org/jira/browse/BEEHIVE-135?page=all ]
     
Zach Smith closed BEEHIVE-135:
------------------------------


verified that enforceVersionRequired macro only called on controls with @VersionRequired set.

> Version checking codegen cleanup
> --------------------------------
>
>          Key: BEEHIVE-135
>          URL: http://issues.apache.org/jira/browse/BEEHIVE-135
>      Project: Beehive
>         Type: Bug
>   Components: Controls
>     Versions: V1Alpha
>     Reporter: Kyle Marvin
>     Assignee: Kyle Marvin
>     Priority: Minor
>      Fix For: v1m1

>
> The code generated static initialization code that does version checking for ControlBeans could be made better in a couple of ways:
> - the code generated by the enforceVersionRequired macro should be selectively generated.   There is no reason to generate class load time version checking if there is no @VersionRequired annotation on the associated ControlExtension.
> - the ControlInterface to version check against can be (and should) be determined at codegen time and not runtime.   The call to ControlBean.getMostDerivedInterface can be replaced by directly injecting the (versioned) ControlInterface class name.  This is a) simpler, and b) safer, because having the class you are version checking against be dynamic doesn't really make sense.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira