You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "rhalm (via GitHub)" <gi...@apache.org> on 2026/07/29 18:42:12 UTC
[PR] HDDS-14876. Make snapshot diff progress more granular [ozone]
rhalm opened a new pull request, #10901:
URL: https://github.com/apache/ozone/pull/10901
## What changes were proposed in this pull request?
Improves snapshot diff progress granularity by letting clients track which stage a diff job is in and adding more informative logs. Main changes:
- Exposes substatus and progress percentage (when available) to clients in snapshot diff responses, and fixes minor bugs causing incorrect values:
- Wires `subStatus` and `progressPercent` through the proto layer and CLI output (with a minor formatting fix)
- Adds a new substatus for the FSO path resolution stage (`PATH_RESOLUTION_FSO`)
- Fixes progress percentage carrying over between stages by resetting progress to 0 at the start
- Fixes a bug where the substatus would remain stuck on `SST_FILE_DELTA_*` instead of switching to `OBJECT_ID_MAP_GEN_*` during object ID map generation (which now uses `OBJECT_ID_MAP_GEN_OBS` for OBS and FSO file table, `OBJECT_ID_MAP_GEN_FSO` for FSO directory table)
- Improves logging for snapshot diff processing:
- Adds one summary log per stage with item count and elapsed time
- Adds a warn log when DAG-based delta computation returns no result and falls back to full diff
**Before / After**
Example CLI output when polling an in-progress snapshot diff before this change:
```bash
$ ozone sh snapshot diff --get-report /vol/bucket snap1 snap2
Snapshot diff job is IN_PROGRESS. Please retry after 60000 ms.
$ ozone sh snapshot diff --get-report --json /vol/bucket snap1 snap2
{
"snapshotDiffReport" : {
...
},
"jobStatus" : "IN_PROGRESS",
"waitTimeInMs" : 60000
}
```
And after:
```bash
$ ozone sh snapshot diff --get-report /vol/bucket snap1 snap2
Snapshot diff job is IN_PROGRESS. Please retry after 60000 ms.
SubStatus : OBJECT_ID_MAP_GEN_FSO
Keys Processed Estimated Percentage : 25.0
$ ozone sh snapshot diff --get-report --json /vol/bucket snap1 snap2
{
"snapshotDiffReport" : {
...
},
"jobStatus" : "IN_PROGRESS",
"waitTimeInMs" : 60000,
"subStatus" : "OBJECT_ID_MAP_GEN_FSO",
"progressPercent" : 25.0
}
```
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14876
## How was this patch tested?
- Updated and added unit tests
- Manually verified the changes on a local deployment
- CI pass: https://github.com/rhalm/ozone/actions/runs/30462314731
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14876. Make snapshot diff progress more granular [ozone]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #10901:
URL: https://github.com/apache/ozone/pull/10901#discussion_r3677200839
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerRequestHandler.java:
##########
@@ -1482,6 +1482,10 @@ private SnapshotDiffResponse snapshotDiff(
builder.setSnapshotDiffReport(
response.getSnapshotDiffReport().toProtobuf());
}
+ if (response.getSubStatus() != null) {
+ builder.setSubStatus(response.getSubStatus().toProtoBuf());
+ builder.setProgressPercent(response.getProgressPercent());
+ }
Review Comment:
progressPercent is currently serialized whenever subStatus is set, even for sub-statuses that don’t support progress (e.g., PATH_RESOLUTION_FSO / DIFF_REPORT_GEN). To keep API semantics clear (“when available”), only set progressPercent when subStatus.hasProgress().
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/protocolPB/OzoneManagerProtocolClientSideTranslatorPB.java:
##########
@@ -1468,12 +1468,17 @@ private SnapshotDiffResponse snapshotDiffInternal(String volumeName,
OzoneManagerProtocolProtos.SnapshotDiffResponse diffResponse =
omResponse.getSnapshotDiffResponse();
- return new SnapshotDiffResponse(SnapshotDiffReportOzone.fromProtobuf(
- diffResponse.getSnapshotDiffReport()),
+ SnapshotDiffResponse result = new SnapshotDiffResponse(
+ SnapshotDiffReportOzone.fromProtobuf(diffResponse.getSnapshotDiffReport()),
JobStatus.fromProtobuf(diffResponse.getJobStatus()),
diffResponse.getWaitTimeInMs(),
diffResponse.getReason(),
reportOnly);
+ if (diffResponse.hasSubStatus()) {
+ result.setSubStatus(SnapshotDiffResponse.SubStatus.fromProtoBuf(diffResponse.getSubStatus()));
+ result.setProgressPercent(diffResponse.getProgressPercent());
+ }
Review Comment:
Client-side translator reads diffResponse.getProgressPercent() without checking hasProgressPercent(). If the server omits progressPercent (or an older server is contacted), this loses the “unset vs 0.0” distinction and can mislead consumers. Guard the read with hasProgressPercent().
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java:
##########
@@ -1244,10 +1257,14 @@ void addToObjectIdMap(Table<String, ? extends WithParentObjectId> fsTable,
PersistentMap<byte[], Boolean> objectIdToIsDirMap,
Optional<Set<Long>> oldParentIds,
Optional<Set<Long>> newParentIds,
- TablePrefixInfo tablePrefixes, String jobKey) throws IOException, RocksDBException {
+ TablePrefixInfo tablePrefixes, String jobKey,
+ String jobId) throws IOException, RocksDBException {
if (deltaFiles.isEmpty()) {
return;
}
+ long objectIdMapStart = Time.monotonicNow();
+ updateProgress(jobKey, 0.0);
+ AtomicLong keysProcessed = new AtomicLong(0);
Review Comment:
Progress reset is skipped when deltaFiles is empty because updateProgress(jobKey, 0.0) happens after the early return. This can leave a previous stage’s progressPercent visible for subsequent stages, which contradicts the intended “reset at start” behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14876. Make snapshot diff progress more granular [ozone]
Posted by "rhalm (via GitHub)" <gi...@apache.org>.
rhalm commented on code in PR #10901:
URL: https://github.com/apache/ozone/pull/10901#discussion_r3691590146
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java:
##########
@@ -1221,17 +1235,22 @@ private void getDeltaFilesAndDiffKeysToObjectIdToKeyMap(
final PersistentMap<byte[], byte[]> newObjIdToKeyMap,
final PersistentMap<byte[], Boolean> objectIdToIsDirMap,
final Optional<Set<Long>> oldParentIds, final Optional<Set<Long>> newParentIds,
- final DeltaFileComputer deltaFileComputer, final String jobKey) throws IOException, RocksDBException {
+ final DeltaFileComputer deltaFileComputer, final String jobKey,
+ final String jobId) throws IOException, RocksDBException {
+ long deltaFilesStart = Time.monotonicNow();
Set<String> tablesToLookUp = Collections.singleton(fsTable.getName());
Collection<Pair<Path, SstFileInfo>> deltaFiles = deltaFileComputer.getDeltaFiles(fsInfo, tsInfo,
tablesToLookUp);
if (LOG.isDebugEnabled()) {
- LOG.debug("Computed Delta SST File Set, Total count = {} ", deltaFiles.size());
+ LOG.debug("Computed Delta SST File Set for table '{}', file count: {}, elapsed: {}ms, jobId: {}",
+ fsTable.getName(), deltaFiles.size(), Time.monotonicNow() - deltaFilesStart, jobId);
}
+ recordActivity(jobKey,
+ fsTable.getName().equals(DIRECTORY_TABLE) ? OBJECT_ID_MAP_GEN_FSO : OBJECT_ID_MAP_GEN_OBS);
Review Comment:
Thanks for the review. Split into `OBJECT_ID_MAP_GEN_FSO_FILE` and `OBJECT_ID_MAP_GEN_FSO_DIR` as suggested. I kept `OBJECT_ID_MAP_GEN_FSO` as deprecated purely for an upgrade edge case where an older build may have persisted this value to RocksDB as JSON, and since the codec's JSON fallback path deserializes enums by name, removing it could cause a failure. Very unlikely scenario, but better to be safe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14876. Make snapshot diff progress more granular [ozone]
Posted by "rhalm (via GitHub)" <gi...@apache.org>.
rhalm commented on code in PR #10901:
URL: https://github.com/apache/ozone/pull/10901#discussion_r3705424980
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java:
##########
@@ -1312,6 +1337,11 @@ void addToObjectIdMap(Table<String, ? extends WithParentObjectId> fsTable,
}
}
}
+ updateProgress(jobKey, 1.0);
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14876. Make snapshot diff progress more granular [ozone]
Posted by "SaketaChalamchala (via GitHub)" <gi...@apache.org>.
SaketaChalamchala commented on code in PR #10901:
URL: https://github.com/apache/ozone/pull/10901#discussion_r3686187103
##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########
@@ -2256,13 +2256,15 @@ message SnapshotDiffResponse {
OBJECT_ID_MAP_GEN_OBS = 3;
OBJECT_ID_MAP_GEN_FSO = 4;
DIFF_REPORT_GEN = 5;
+ PATH_RESOLUTION_FSO = 6;
Review Comment:
You may need to add this in `hadoop-ozone/interface-client/src/main/resources/proto.lock` as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14876. Make snapshot diff progress more granular [ozone]
Posted by "SaketaChalamchala (via GitHub)" <gi...@apache.org>.
SaketaChalamchala commented on code in PR #10901:
URL: https://github.com/apache/ozone/pull/10901#discussion_r3754225832
##########
hadoop-ozone/common/src/test/java/org/apache/hadoop/ozone/snapshot/TestSnapshotDiffResponse.java:
##########
@@ -57,20 +61,48 @@ void testReportOnlyFailedMessageIncludesReason() {
assertTrue(message.contains("resubmit the job without using the --get-report option"));
}
- @Test
- void testReportOnlyInProgressIncludesSubStatusAndProgress() {
+ @ParameterizedTest
+ @EnumSource(value = SubStatus.class, names = {"OBJECT_ID_MAP_GEN_OBS", "OBJECT_ID_MAP_GEN_FSO",
+ "OBJECT_ID_MAP_GEN_FSO_FILE", "OBJECT_ID_MAP_GEN_FSO_DIR"})
+ void testInProgressWithMapGenSubStatusIncludesProgress(SubStatus subStatus) {
SnapshotDiffResponse response = new SnapshotDiffResponse(createReport(),
JobStatus.IN_PROGRESS, 1000L, true);
- response.setSubStatus(SubStatus.OBJECT_ID_MAP_GEN_OBS);
+ response.setSubStatus(subStatus);
response.setProgressPercent(55.5);
String message = response.toString();
assertTrue(message.contains("IN_PROGRESS"));
- assertTrue(message.contains("OBJECT_ID_MAP_GEN_OBS"));
+ assertTrue(message.contains(subStatus.name()));
assertTrue(message.contains("Keys Processed Estimated Percentage"));
assertTrue(message.contains("55.5"));
}
+ @ParameterizedTest
+ @EnumSource(value = SubStatus.class,
+ names = {"OBJECT_ID_MAP_GEN_OBS", "OBJECT_ID_MAP_GEN_FSO", "OBJECT_ID_MAP_GEN_FSO_FILE",
+ "OBJECT_ID_MAP_GEN_FSO_DIR"},
+ mode = Mode.EXCLUDE)
+ void testInProgressWithNonMapGenSubStatusRendersSubStatusButNotProgress(SubStatus subStatus) {
Review Comment:
nit: Could you keep the test names short and maybe add comments for the description. Just so it is easier to read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14876. Make snapshot diff progress more granular [ozone]
Posted by "SaketaChalamchala (via GitHub)" <gi...@apache.org>.
SaketaChalamchala commented on code in PR #10901:
URL: https://github.com/apache/ozone/pull/10901#discussion_r3754225832
##########
hadoop-ozone/common/src/test/java/org/apache/hadoop/ozone/snapshot/TestSnapshotDiffResponse.java:
##########
@@ -57,20 +61,48 @@ void testReportOnlyFailedMessageIncludesReason() {
assertTrue(message.contains("resubmit the job without using the --get-report option"));
}
- @Test
- void testReportOnlyInProgressIncludesSubStatusAndProgress() {
+ @ParameterizedTest
+ @EnumSource(value = SubStatus.class, names = {"OBJECT_ID_MAP_GEN_OBS", "OBJECT_ID_MAP_GEN_FSO",
+ "OBJECT_ID_MAP_GEN_FSO_FILE", "OBJECT_ID_MAP_GEN_FSO_DIR"})
+ void testInProgressWithMapGenSubStatusIncludesProgress(SubStatus subStatus) {
SnapshotDiffResponse response = new SnapshotDiffResponse(createReport(),
JobStatus.IN_PROGRESS, 1000L, true);
- response.setSubStatus(SubStatus.OBJECT_ID_MAP_GEN_OBS);
+ response.setSubStatus(subStatus);
response.setProgressPercent(55.5);
String message = response.toString();
assertTrue(message.contains("IN_PROGRESS"));
- assertTrue(message.contains("OBJECT_ID_MAP_GEN_OBS"));
+ assertTrue(message.contains(subStatus.name()));
assertTrue(message.contains("Keys Processed Estimated Percentage"));
assertTrue(message.contains("55.5"));
}
+ @ParameterizedTest
+ @EnumSource(value = SubStatus.class,
+ names = {"OBJECT_ID_MAP_GEN_OBS", "OBJECT_ID_MAP_GEN_FSO", "OBJECT_ID_MAP_GEN_FSO_FILE",
+ "OBJECT_ID_MAP_GEN_FSO_DIR"},
+ mode = Mode.EXCLUDE)
+ void testInProgressWithNonMapGenSubStatusRendersSubStatusButNotProgress(SubStatus subStatus) {
Review Comment:
nit: Could you keep the test names short and maybe add comments for the description. Just so it is easier to read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14876. Make snapshot diff progress more granular [ozone]
Posted by "sadanand48 (via GitHub)" <gi...@apache.org>.
sadanand48 commented on code in PR #10901:
URL: https://github.com/apache/ozone/pull/10901#discussion_r3680710472
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java:
##########
@@ -1221,17 +1231,20 @@ private void getDeltaFilesAndDiffKeysToObjectIdToKeyMap(
final PersistentMap<byte[], byte[]> newObjIdToKeyMap,
final PersistentMap<byte[], Boolean> objectIdToIsDirMap,
final Optional<Set<Long>> oldParentIds, final Optional<Set<Long>> newParentIds,
- final DeltaFileComputer deltaFileComputer, final String jobKey) throws IOException, RocksDBException {
+ final DeltaFileComputer deltaFileComputer, final String jobKey,
+ final String jobId) throws IOException, RocksDBException {
+ long deltaFilesStart = Time.monotonicNow();
Set<String> tablesToLookUp = Collections.singleton(fsTable.getName());
Collection<Pair<Path, SstFileInfo>> deltaFiles = deltaFileComputer.getDeltaFiles(fsInfo, tsInfo,
tablesToLookUp);
- if (LOG.isDebugEnabled()) {
- LOG.debug("Computed Delta SST File Set, Total count = {} ", deltaFiles.size());
- }
+ LOG.info("Computed Delta SST File Set for table '{}', file count: {}, elapsed: {}ms, jobId: {}",
Review Comment:
It looks like for each successful snapshot diff call, it will generate around 6-7 info log statements. I think the per stage ones could be at the debug level itself
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14876. Make snapshot diff progress more granular [ozone]
Posted by "SaketaChalamchala (via GitHub)" <gi...@apache.org>.
SaketaChalamchala commented on code in PR #10901:
URL: https://github.com/apache/ozone/pull/10901#discussion_r3686084346
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java:
##########
Review Comment:
nit: `double[]` was introduced in [HDDS-8007](https://issues.apache.org/jira/browse/HDDS-8007) when this logic lived inside a forEach lambda. it is no longer necessary.
```suggestion
double checkpoint = stepIncreasePct;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14876. Make snapshot diff progress more granular [ozone]
Posted by "sadanand48 (via GitHub)" <gi...@apache.org>.
sadanand48 commented on code in PR #10901:
URL: https://github.com/apache/ozone/pull/10901#discussion_r3680658221
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerRequestHandler.java:
##########
@@ -1482,6 +1482,10 @@ private SnapshotDiffResponse snapshotDiff(
builder.setSnapshotDiffReport(
response.getSnapshotDiffReport().toProtobuf());
}
+ if (response.getSubStatus() != null) {
+ builder.setSubStatus(response.getSubStatus().toProtoBuf());
+ builder.setProgressPercent(response.getProgressPercent());
+ }
Review Comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14876. Make snapshot diff progress more granular [ozone]
Posted by "rhalm (via GitHub)" <gi...@apache.org>.
rhalm commented on code in PR #10901:
URL: https://github.com/apache/ozone/pull/10901#discussion_r3691600518
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java:
##########
Review Comment:
Done
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java:
##########
@@ -1312,6 +1334,10 @@ void addToObjectIdMap(Table<String, ? extends WithParentObjectId> fsTable,
}
}
}
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14876. Make snapshot diff progress more granular [ozone]
Posted by "rhalm (via GitHub)" <gi...@apache.org>.
rhalm commented on code in PR #10901:
URL: https://github.com/apache/ozone/pull/10901#discussion_r3691651791
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java:
##########
@@ -1112,27 +1114,27 @@ void generateSnapshotDiffReport(final String jobKey,
// repetition while constantly checking if the job is cancelled.
Callable<Void>[] methodCalls = new Callable[]{
() -> {
- recordActivity(jobKey, OBJECT_ID_MAP_GEN_OBS);
getDeltaFilesAndDiffKeysToObjectIdToKeyMap(fsKeyTable, tsKeyTable,
fsInfo, tsInfo, performNonNativeDiff, tablePrefixes,
objectIdToKeyNameMapForFromSnapshot,
objectIdToKeyNameMapForToSnapshot, objectIdToIsDirMap,
- oldParentIds, newParentIds, deltaFileComputer, jobKey);
+ oldParentIds, newParentIds, deltaFileComputer, jobKey, jobId);
return null;
},
() -> {
if (bucketLayout.isFileSystemOptimized()) {
- recordActivity(jobKey, OBJECT_ID_MAP_GEN_FSO);
getDeltaFilesAndDiffKeysToObjectIdToKeyMap(fsDirTable, tsDirTable,
fsInfo, tsInfo, performNonNativeDiff, tablePrefixes,
objectIdToKeyNameMapForFromSnapshot,
objectIdToKeyNameMapForToSnapshot, objectIdToIsDirMap,
- oldParentIds, newParentIds, deltaFileComputer, jobKey);
+ oldParentIds, newParentIds, deltaFileComputer, jobKey, jobId);
}
return null;
},
() -> {
if (bucketLayout.isFileSystemOptimized()) {
+ recordActivity(jobKey, PATH_RESOLUTION_FSO);
Review Comment:
Good idea, opened [HDDS-16058](https://issues.apache.org/jira/browse/HDDS-16058) as a follow-up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14876. Make snapshot diff progress more granular [ozone]
Posted by "rhalm (via GitHub)" <gi...@apache.org>.
rhalm commented on code in PR #10901:
URL: https://github.com/apache/ozone/pull/10901#discussion_r3705422594
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java:
##########
@@ -1312,6 +1334,10 @@ void addToObjectIdMap(Table<String, ? extends WithParentObjectId> fsTable,
}
}
}
Review Comment:
Thanks, that is nicer, updated it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14876. Make snapshot diff progress more granular [ozone]
Posted by "SaketaChalamchala (via GitHub)" <gi...@apache.org>.
SaketaChalamchala commented on code in PR #10901:
URL: https://github.com/apache/ozone/pull/10901#discussion_r3754225832
##########
hadoop-ozone/common/src/test/java/org/apache/hadoop/ozone/snapshot/TestSnapshotDiffResponse.java:
##########
@@ -57,20 +61,48 @@ void testReportOnlyFailedMessageIncludesReason() {
assertTrue(message.contains("resubmit the job without using the --get-report option"));
}
- @Test
- void testReportOnlyInProgressIncludesSubStatusAndProgress() {
+ @ParameterizedTest
+ @EnumSource(value = SubStatus.class, names = {"OBJECT_ID_MAP_GEN_OBS", "OBJECT_ID_MAP_GEN_FSO",
+ "OBJECT_ID_MAP_GEN_FSO_FILE", "OBJECT_ID_MAP_GEN_FSO_DIR"})
+ void testInProgressWithMapGenSubStatusIncludesProgress(SubStatus subStatus) {
SnapshotDiffResponse response = new SnapshotDiffResponse(createReport(),
JobStatus.IN_PROGRESS, 1000L, true);
- response.setSubStatus(SubStatus.OBJECT_ID_MAP_GEN_OBS);
+ response.setSubStatus(subStatus);
response.setProgressPercent(55.5);
String message = response.toString();
assertTrue(message.contains("IN_PROGRESS"));
- assertTrue(message.contains("OBJECT_ID_MAP_GEN_OBS"));
+ assertTrue(message.contains(subStatus.name()));
assertTrue(message.contains("Keys Processed Estimated Percentage"));
assertTrue(message.contains("55.5"));
}
+ @ParameterizedTest
+ @EnumSource(value = SubStatus.class,
+ names = {"OBJECT_ID_MAP_GEN_OBS", "OBJECT_ID_MAP_GEN_FSO", "OBJECT_ID_MAP_GEN_FSO_FILE",
+ "OBJECT_ID_MAP_GEN_FSO_DIR"},
+ mode = Mode.EXCLUDE)
+ void testInProgressWithNonMapGenSubStatusRendersSubStatusButNotProgress(SubStatus subStatus) {
Review Comment:
Test says testing for "non"-MapGen sub status but the test only checks for MapGen sub stages.
Could you also keep the test names short and maybe add comments for the description. Just so it is easier to read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14876. Make snapshot diff progress more granular [ozone]
Posted by "SaketaChalamchala (via GitHub)" <gi...@apache.org>.
SaketaChalamchala commented on code in PR #10901:
URL: https://github.com/apache/ozone/pull/10901#discussion_r3685951118
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java:
##########
@@ -1221,17 +1235,22 @@ private void getDeltaFilesAndDiffKeysToObjectIdToKeyMap(
final PersistentMap<byte[], byte[]> newObjIdToKeyMap,
final PersistentMap<byte[], Boolean> objectIdToIsDirMap,
final Optional<Set<Long>> oldParentIds, final Optional<Set<Long>> newParentIds,
- final DeltaFileComputer deltaFileComputer, final String jobKey) throws IOException, RocksDBException {
+ final DeltaFileComputer deltaFileComputer, final String jobKey,
+ final String jobId) throws IOException, RocksDBException {
+ long deltaFilesStart = Time.monotonicNow();
Set<String> tablesToLookUp = Collections.singleton(fsTable.getName());
Collection<Pair<Path, SstFileInfo>> deltaFiles = deltaFileComputer.getDeltaFiles(fsInfo, tsInfo,
tablesToLookUp);
if (LOG.isDebugEnabled()) {
- LOG.debug("Computed Delta SST File Set, Total count = {} ", deltaFiles.size());
+ LOG.debug("Computed Delta SST File Set for table '{}', file count: {}, elapsed: {}ms, jobId: {}",
+ fsTable.getName(), deltaFiles.size(), Time.monotonicNow() - deltaFilesStart, jobId);
}
+ recordActivity(jobKey,
+ fsTable.getName().equals(DIRECTORY_TABLE) ? OBJECT_ID_MAP_GEN_FSO : OBJECT_ID_MAP_GEN_OBS);
Review Comment:
Thanks for the path @rhalm. The sub status here would be `OBJECT_ID_MAP_GEN_OBS` for `fileTable` which is confusing. This was also an existing bug.
Could we split `OBJECT_ID_MAP_GEN_FSO` to maybe `OBJECT_ID_MAP_GEN_FSO_FILE` for `fileTable` and `OBJECT_ID_MAP_GEN_FSO_DIR` for `directoryTable`?
`keyTable` objectID gen stage can continue to use `OBJECT_ID_MAP_GEN_OBS`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14876. Make snapshot diff progress more granular [ozone]
Posted by "smengcl (via GitHub)" <gi...@apache.org>.
smengcl commented on code in PR #10901:
URL: https://github.com/apache/ozone/pull/10901#discussion_r3693791142
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java:
##########
@@ -1312,6 +1334,10 @@ void addToObjectIdMap(Table<String, ? extends WithParentObjectId> fsTable,
}
}
}
Review Comment:
One edge case appears to remain: when `deltaFiles.isEmpty()`, the method returns after resetting progress to `0.0`, so it never reaches the terminal `1.0` update or emits a stage summary. An empty stage could go directly to 100% and log that it was skipped:
```diff
- updateProgress(jobKey, 0.0);
if (deltaFiles.isEmpty()) {
+ updateProgress(jobKey, 1.0);
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("Skipped object ID map generation for table '{}' because there are no delta files, jobId: {}",
+ fsTable.getName(), jobId);
+ }
return;
}
+ updateProgress(jobKey, 0.0);
```
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java:
##########
@@ -1312,6 +1337,11 @@ void addToObjectIdMap(Table<String, ? extends WithParentObjectId> fsTable,
}
}
}
+ updateProgress(jobKey, 1.0);
Review Comment:
Could we keep the debug log in the same 0-100 unit as the persisted and RPC value? `updateProgress(1.0)` stores `100.0`, but the helper logs the raw `1.0` with a `%` suffix. The final update therefore logs `1.0%`, and a 10% checkpoint logs `0.1%`. This appears to be a one-line behavioral fix:
```diff
- LOG.debug("Completed processing {}% of keys for snapshot diff job {}", pct, jobKey);
+ LOG.debug("Completed processing {}% of keys for snapshot diff job {}",
+ snapshotDiffJob.getKeysProcessedPct(), jobKey);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14876. Make snapshot diff progress more granular [ozone]
Posted by "SaketaChalamchala (via GitHub)" <gi...@apache.org>.
SaketaChalamchala commented on code in PR #10901:
URL: https://github.com/apache/ozone/pull/10901#discussion_r3686167547
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java:
##########
@@ -1112,27 +1114,27 @@ void generateSnapshotDiffReport(final String jobKey,
// repetition while constantly checking if the job is cancelled.
Callable<Void>[] methodCalls = new Callable[]{
() -> {
- recordActivity(jobKey, OBJECT_ID_MAP_GEN_OBS);
getDeltaFilesAndDiffKeysToObjectIdToKeyMap(fsKeyTable, tsKeyTable,
fsInfo, tsInfo, performNonNativeDiff, tablePrefixes,
objectIdToKeyNameMapForFromSnapshot,
objectIdToKeyNameMapForToSnapshot, objectIdToIsDirMap,
- oldParentIds, newParentIds, deltaFileComputer, jobKey);
+ oldParentIds, newParentIds, deltaFileComputer, jobKey, jobId);
return null;
},
() -> {
if (bucketLayout.isFileSystemOptimized()) {
- recordActivity(jobKey, OBJECT_ID_MAP_GEN_FSO);
getDeltaFilesAndDiffKeysToObjectIdToKeyMap(fsDirTable, tsDirTable,
fsInfo, tsInfo, performNonNativeDiff, tablePrefixes,
objectIdToKeyNameMapForFromSnapshot,
objectIdToKeyNameMapForToSnapshot, objectIdToIsDirMap,
- oldParentIds, newParentIds, deltaFileComputer, jobKey);
+ oldParentIds, newParentIds, deltaFileComputer, jobKey, jobId);
}
return null;
},
() -> {
if (bucketLayout.isFileSystemOptimized()) {
+ recordActivity(jobKey, PATH_RESOLUTION_FSO);
Review Comment:
Progress for `PATH_RESOLUTION_FSO` and `DIFF_REPORT_GEN` is currently not logged and is not visible to the client. Can you explore how we can capture the progress of these stages as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14876. Make snapshot diff progress more granular [ozone]
Posted by "SaketaChalamchala (via GitHub)" <gi...@apache.org>.
SaketaChalamchala commented on code in PR #10901:
URL: https://github.com/apache/ozone/pull/10901#discussion_r3686167547
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java:
##########
@@ -1112,27 +1114,27 @@ void generateSnapshotDiffReport(final String jobKey,
// repetition while constantly checking if the job is cancelled.
Callable<Void>[] methodCalls = new Callable[]{
() -> {
- recordActivity(jobKey, OBJECT_ID_MAP_GEN_OBS);
getDeltaFilesAndDiffKeysToObjectIdToKeyMap(fsKeyTable, tsKeyTable,
fsInfo, tsInfo, performNonNativeDiff, tablePrefixes,
objectIdToKeyNameMapForFromSnapshot,
objectIdToKeyNameMapForToSnapshot, objectIdToIsDirMap,
- oldParentIds, newParentIds, deltaFileComputer, jobKey);
+ oldParentIds, newParentIds, deltaFileComputer, jobKey, jobId);
return null;
},
() -> {
if (bucketLayout.isFileSystemOptimized()) {
- recordActivity(jobKey, OBJECT_ID_MAP_GEN_FSO);
getDeltaFilesAndDiffKeysToObjectIdToKeyMap(fsDirTable, tsDirTable,
fsInfo, tsInfo, performNonNativeDiff, tablePrefixes,
objectIdToKeyNameMapForFromSnapshot,
objectIdToKeyNameMapForToSnapshot, objectIdToIsDirMap,
- oldParentIds, newParentIds, deltaFileComputer, jobKey);
+ oldParentIds, newParentIds, deltaFileComputer, jobKey, jobId);
}
return null;
},
() -> {
if (bucketLayout.isFileSystemOptimized()) {
+ recordActivity(jobKey, PATH_RESOLUTION_FSO);
Review Comment:
Progress capture for `PATH_RESOLUTION_FSO` and `DIFF_REPORT_GEN` stages is not consistent with the ObjectID generation stages. Could you also explore how we can capture the progress of these stages as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14876. Make snapshot diff progress more granular [ozone]
Posted by "rhalm (via GitHub)" <gi...@apache.org>.
rhalm commented on code in PR #10901:
URL: https://github.com/apache/ozone/pull/10901#discussion_r3691603218
##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########
@@ -2256,13 +2256,15 @@ message SnapshotDiffResponse {
OBJECT_ID_MAP_GEN_OBS = 3;
OBJECT_ID_MAP_GEN_FSO = 4;
DIFF_REPORT_GEN = 5;
+ PATH_RESOLUTION_FSO = 6;
Review Comment:
Good catch, done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14876. Make snapshot diff progress more granular [ozone]
Posted by "SaketaChalamchala (via GitHub)" <gi...@apache.org>.
SaketaChalamchala commented on code in PR #10901:
URL: https://github.com/apache/ozone/pull/10901#discussion_r3686167547
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java:
##########
@@ -1112,27 +1114,27 @@ void generateSnapshotDiffReport(final String jobKey,
// repetition while constantly checking if the job is cancelled.
Callable<Void>[] methodCalls = new Callable[]{
() -> {
- recordActivity(jobKey, OBJECT_ID_MAP_GEN_OBS);
getDeltaFilesAndDiffKeysToObjectIdToKeyMap(fsKeyTable, tsKeyTable,
fsInfo, tsInfo, performNonNativeDiff, tablePrefixes,
objectIdToKeyNameMapForFromSnapshot,
objectIdToKeyNameMapForToSnapshot, objectIdToIsDirMap,
- oldParentIds, newParentIds, deltaFileComputer, jobKey);
+ oldParentIds, newParentIds, deltaFileComputer, jobKey, jobId);
return null;
},
() -> {
if (bucketLayout.isFileSystemOptimized()) {
- recordActivity(jobKey, OBJECT_ID_MAP_GEN_FSO);
getDeltaFilesAndDiffKeysToObjectIdToKeyMap(fsDirTable, tsDirTable,
fsInfo, tsInfo, performNonNativeDiff, tablePrefixes,
objectIdToKeyNameMapForFromSnapshot,
objectIdToKeyNameMapForToSnapshot, objectIdToIsDirMap,
- oldParentIds, newParentIds, deltaFileComputer, jobKey);
+ oldParentIds, newParentIds, deltaFileComputer, jobKey, jobId);
}
return null;
},
() -> {
if (bucketLayout.isFileSystemOptimized()) {
+ recordActivity(jobKey, PATH_RESOLUTION_FSO);
Review Comment:
Progress for `PATH_RESOLUTION_FSO` and `DIFF_REPORT_GEN` is currently not logged. Can you explore how we can capture the progress of these stages as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14876. Make snapshot diff progress more granular [ozone]
Posted by "sadanand48 (via GitHub)" <gi...@apache.org>.
sadanand48 commented on code in PR #10901:
URL: https://github.com/apache/ozone/pull/10901#discussion_r3680659306
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/protocolPB/OzoneManagerProtocolClientSideTranslatorPB.java:
##########
@@ -1468,12 +1468,17 @@ private SnapshotDiffResponse snapshotDiffInternal(String volumeName,
OzoneManagerProtocolProtos.SnapshotDiffResponse diffResponse =
omResponse.getSnapshotDiffResponse();
- return new SnapshotDiffResponse(SnapshotDiffReportOzone.fromProtobuf(
- diffResponse.getSnapshotDiffReport()),
+ SnapshotDiffResponse result = new SnapshotDiffResponse(
+ SnapshotDiffReportOzone.fromProtobuf(diffResponse.getSnapshotDiffReport()),
JobStatus.fromProtobuf(diffResponse.getJobStatus()),
diffResponse.getWaitTimeInMs(),
diffResponse.getReason(),
reportOnly);
+ if (diffResponse.hasSubStatus()) {
+ result.setSubStatus(SnapshotDiffResponse.SubStatus.fromProtoBuf(diffResponse.getSubStatus()));
+ result.setProgressPercent(diffResponse.getProgressPercent());
+ }
Review Comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14876. Make snapshot diff progress more granular [ozone]
Posted by "rhalm (via GitHub)" <gi...@apache.org>.
rhalm commented on code in PR #10901:
URL: https://github.com/apache/ozone/pull/10901#discussion_r3683261627
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java:
##########
@@ -1221,17 +1231,20 @@ private void getDeltaFilesAndDiffKeysToObjectIdToKeyMap(
final PersistentMap<byte[], byte[]> newObjIdToKeyMap,
final PersistentMap<byte[], Boolean> objectIdToIsDirMap,
final Optional<Set<Long>> oldParentIds, final Optional<Set<Long>> newParentIds,
- final DeltaFileComputer deltaFileComputer, final String jobKey) throws IOException, RocksDBException {
+ final DeltaFileComputer deltaFileComputer, final String jobKey,
+ final String jobId) throws IOException, RocksDBException {
+ long deltaFilesStart = Time.monotonicNow();
Set<String> tablesToLookUp = Collections.singleton(fsTable.getName());
Collection<Pair<Path, SstFileInfo>> deltaFiles = deltaFileComputer.getDeltaFiles(fsInfo, tsInfo,
tablesToLookUp);
- if (LOG.isDebugEnabled()) {
- LOG.debug("Computed Delta SST File Set, Total count = {} ", deltaFiles.size());
- }
+ LOG.info("Computed Delta SST File Set for table '{}', file count: {}, elapsed: {}ms, jobId: {}",
Review Comment:
Thank you for the review. Good idea, I moved the per stage logs to debug level, and kept the preexisting info logs as-is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14876. Make snapshot diff progress more granular [ozone]
Posted by "SaketaChalamchala (via GitHub)" <gi...@apache.org>.
SaketaChalamchala commented on code in PR #10901:
URL: https://github.com/apache/ozone/pull/10901#discussion_r3686145814
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java:
##########
@@ -1312,6 +1334,10 @@ void addToObjectIdMap(Table<String, ? extends WithParentObjectId> fsTable,
}
}
}
Review Comment:
In most cases `Total keysProcessed < totalEstimatedKeysToProcess`. So, the progress may never reach 100% inside the loop. You can set it after the loop to indicate that the stage has finished.
```suggestion
}
updateProgress(jobKey, 1.0)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14876. Make snapshot diff progress more granular [ozone]
Posted by "smengcl (via GitHub)" <gi...@apache.org>.
smengcl commented on PR #10901:
URL: https://github.com/apache/ozone/pull/10901#issuecomment-5259219924
Thanks @rhalm for the patch. Thanks @sadanand48 @SaketaChalamchala for the reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-14876. Make snapshot diff progress more granular [ozone]
Posted by "smengcl (via GitHub)" <gi...@apache.org>.
smengcl merged PR #10901:
URL: https://github.com/apache/ozone/pull/10901
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org