[GitHub] [arrow] wjones127 commented on a diff in pull request #13541: ARROW-15016: [R] `show_exec_plan` for an `arrow_dplyr_query`

[GitBox <gi...@apache.org>]

wjones127 commented on code in PR #13541:
URL: https://github.com/apache/arrow/pull/13541#discussion_r919083216


##########
r/R/dplyr.R:
##########
@@ -219,6 +219,31 @@ tail.arrow_dplyr_query <- function(x, n = 6L, ...) {
   x
 }
 
+#' Show the details of an Arrow ExecPlan
+#'
+#' This is a function which gives more details about the `ExecPlan` of an

Review Comment:
   I feel like it might be helpful to spell the full name out at least once for clarity.
   
   ```suggestion
   #' This is a function which gives more details about the Execution Plan of an
   ```



##########
r/R/dplyr.R:
##########
@@ -219,6 +219,31 @@ tail.arrow_dplyr_query <- function(x, n = 6L, ...) {
   x
 }
 
+#' Show the details of an Arrow ExecPlan
+#'
+#' This is a function which gives more details about the `ExecPlan` of an
+#' `arrow_dplyr_query` object. It is similar to `dplyr::show_query()`.

Review Comment:
   > It is similar to `dplyr::show_query()`.
   
   IMO, it feels more similar to `dplyr::explain()` to me, since we are essentially showing the logical plan of the query.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org