You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/08/03 17:53:06 UTC

[GitHub] [fineract] atharwa-24 opened a new pull request #1233: Added Version Badge & Badge Logo

atharwa-24 opened a new pull request #1233:
URL: https://github.com/apache/fineract/pull/1233


   ## Description
   Describe the changes made and why they were made. Ignore if these details are present on the associated Jira ticket
   
   ## Checklist
   Please make sure these boxes are checked before submitting your pull request - thanks!
   
   - [ ] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
   
   - [ ] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
   
   - [ ] API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm has been updated with details of any API changes.
   
   - [ ] Integration tests have been created/updated for verifying the changes made.
   
   - [ ] All Integrations tests are passing with the new commits.
   
   - [ ] Submission is not a "code dump".  (Large changes can be made "in repository" via a branch.  Ask on the list.)
   
   Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] atharwa-24 closed pull request #1233: Added Version Badge & Badge Logo

Posted by GitBox <gi...@apache.org>.
atharwa-24 closed pull request #1233:
URL: https://github.com/apache/fineract/pull/1233


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] atharwa-24 commented on pull request #1233: Added Version Badge & Badge Logo

Posted by GitBox <gi...@apache.org>.
atharwa-24 commented on pull request #1233:
URL: https://github.com/apache/fineract/pull/1233#issuecomment-668232414


   Oh got it. Thanks😄


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] vorburger commented on pull request #1233: Added Version Badge & Badge Logo

Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1233:
URL: https://github.com/apache/fineract/pull/1233#issuecomment-668438103


   Would you like to close this PR? Or perhaps add any other useful badges
   instead?
   
   >
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] atharwa-24 edited a comment on pull request #1233: Added Version Badge & Badge Logo

Posted by GitBox <gi...@apache.org>.
atharwa-24 edited a comment on pull request #1233:
URL: https://github.com/apache/fineract/pull/1233#issuecomment-668232414


   Oh got it. Thanks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] atharwa-24 commented on pull request #1233: Added Version Badge & Badge Logo

Posted by GitBox <gi...@apache.org>.
atharwa-24 commented on pull request #1233:
URL: https://github.com/apache/fineract/pull/1233#issuecomment-668455517


   ok
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org