You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/06/09 03:01:10 UTC
[GitHub] [flink] pengmide opened a new pull request, #19918: [FLINK-27935][python][docs]] Add Pyflink example of create temporary view document
pengmide opened a new pull request, #19918:
URL: https://github.com/apache/flink/pull/19918
## What is the purpose of the change
Add Pyflink example of create temporary view document.
## Brief change log
- Add Pyflink example of create temporary view document
## Verifying this change
- This Change without andy test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dianfu commented on a diff in pull request #19918: [FLINK-27935][python][docs] Add Pyflink example of create temporary view document
Posted by GitBox <gi...@apache.org>.
dianfu commented on code in PR #19918:
URL: https://github.com/apache/flink/pull/19918#discussion_r893076443
##########
docs/content/docs/dev/table/common.md:
##########
@@ -411,6 +411,28 @@ tableEnv.createTemporaryView("`example.View`", table)
tableEnv.createTemporaryView("other_catalog.other_database.exampleView", table)
```
{{< /tab >}}
+{{< tab "Python" >}}
Review Comment:
Should also update the Chinese page which is located under directory `docs.zh`
##########
docs/content/docs/dev/table/common.md:
##########
@@ -411,6 +411,28 @@ tableEnv.createTemporaryView("`example.View`", table)
tableEnv.createTemporaryView("other_catalog.other_database.exampleView", table)
```
{{< /tab >}}
+{{< tab "Python" >}}
Review Comment:
Could we also add Python example for the following example: https://nightlies.apache.org/flink/flink-docs-release-1.15/docs/dev/table/common/#connector-tables
##########
docs/content/docs/dev/table/common.md:
##########
@@ -411,6 +411,28 @@ tableEnv.createTemporaryView("`example.View`", table)
tableEnv.createTemporaryView("other_catalog.other_database.exampleView", table)
```
{{< /tab >}}
+{{< tab "Python" >}}
+```python
+# get a TableEnvironment
+t_env = StreamTableEnvironment.create(...)
Review Comment:
```suggestion
t_env = TableEnvironment.create(...)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #19918: [FLINK-27935][python][docs]] Add Pyflink example of create temporary view document
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19918:
URL: https://github.com/apache/flink/pull/19918#issuecomment-1150617407
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2a43401a6a37a8a5b19bb898d4d74055f3283902",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2a43401a6a37a8a5b19bb898d4d74055f3283902",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2a43401a6a37a8a5b19bb898d4d74055f3283902 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dianfu closed pull request #19918: [FLINK-27935][python][docs] Add Pyflink example of create temporary view document
Posted by GitBox <gi...@apache.org>.
dianfu closed pull request #19918: [FLINK-27935][python][docs] Add Pyflink example of create temporary view document
URL: https://github.com/apache/flink/pull/19918
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pengmide commented on pull request #19918: [FLINK-27935][python][docs] Add Pyflink example of create temporary view document
Posted by GitBox <gi...@apache.org>.
pengmide commented on PR #19918:
URL: https://github.com/apache/flink/pull/19918#issuecomment-1151902566
@dianfu I've fixed the problem, PTAL~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org