You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "tdiesler (via GitHub)" <gi...@apache.org> on 2024/08/01 10:12:51 UTC
[PR] [CAMEL-21039] Align quarkus generated k8s resources with other runtimes [camel]
tdiesler opened a new pull request, #14997:
URL: https://github.com/apache/camel/pull/14997
https://issues.apache.org/jira/browse/CAMEL-21039
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CAMEL-21039] Align quarkus generated k8s resources with other runtimes [camel]
Posted by "tdiesler (via GitHub)" <gi...@apache.org>.
tdiesler commented on PR #14997:
URL: https://github.com/apache/camel/pull/14997#issuecomment-2268675145
Currently, we make a copy of the respective *-pom.tmpl for each runtime. i.e. you will find `*-kubernetes-pom.tmpl` for each runtime. Then, it is up to JKube to package the executable jar for use in the Docker container, build the image and finally generate the k8s manifest.
Hence, when you do `camel kubernetes export`, you'll get an executable jar, which you can run as documented [here](https://github.com/tdiesler/camel-cloud-examples/tree/main/main/timer-log). It is however not the same as you would get from plain `camel export`.
The idea was to implement `camel kubernetes export`, with as little as possible changes to the plain export/run.
PS: Indeed, the `package as runner jar` step was delete by mistake.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CAMEL-21039] Align quarkus generated k8s resources with other runtimes [camel]
Posted by "tdiesler (via GitHub)" <gi...@apache.org>.
tdiesler closed pull request #14997: [CAMEL-21039] Align quarkus generated k8s resources with other runtimes
URL: https://github.com/apache/camel/pull/14997
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CAMEL-21039] Align quarkus generated k8s resources with other runtimes [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on code in PR #14997:
URL: https://github.com/apache/camel/pull/14997#discussion_r1703665167
##########
dsl/camel-jbang/camel-jbang-core/src/main/resources/templates/main-kubernetes-pom.tmpl:
##########
@@ -94,39 +94,10 @@
</execution>
</executions>
</plugin>
- <!-- package as runner jar -->
Review Comment:
Why is this removed? the camel-main as runtime should be a standard runtime that camel jbang can run and export. I just want to ensure that this still works and that its isolated from SB or Quarkus and that its 100% standalone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org