You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/09/15 22:01:24 UTC
[GitHub] [camel] bedlaj opened a new pull request #4234: CAMEL-13923: Fixed visible escape characters in docs and option splitting
bedlaj opened a new pull request #4234:
URL: https://github.com/apache/camel/pull/4234
- Removed dollar sign escaping - dollar escaping seems unnecessary for both adoc and hugo website
- Fixed curly bracket escaping - only opening bracket is needed to escape, the other `\` was previously visible.
- FIxed `ftp` url escaping - previously single `ftp` word was matched as URL and visible `\` was prepended
- Changed splitting character for long option names from whitespace to `{zwsp}` - this is addressing issue with search described by @bvahdat in https://github.com/apache/camel/pull/4233#issuecomment-692788706 but without breaking layout of table.
I have tested results with Github adoc viewer and local build of website.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] bedlaj merged pull request #4234: CAMEL-13923: Fixed visible escape characters in docs and option splitting
Posted by GitBox <gi...@apache.org>.
bedlaj merged pull request #4234:
URL: https://github.com/apache/camel/pull/4234
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #4234: CAMEL-13923: Fixed visible escape characters in docs and option splitting
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #4234:
URL: https://github.com/apache/camel/pull/4234#issuecomment-693221057
Sorry @bedlaj
I was fixing the website issue and I created conflicts here, can you please rebase and resolve conflicts if any? Thank you
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] bedlaj commented on pull request #4234: CAMEL-13923: Fixed visible escape characters in docs and option splitting
Posted by GitBox <gi...@apache.org>.
bedlaj commented on pull request #4234:
URL: https://github.com/apache/camel/pull/4234#issuecomment-693281555
Squashed and rebased with two conflicts on simple language adoc files - resolved using "Accept theirs" strategy.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on pull request #4234: CAMEL-13923: Fixed visible escape characters in docs and option splitting
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #4234:
URL: https://github.com/apache/camel/pull/4234#issuecomment-693305450
You can merge it @bedlaj Thanks a lot!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org