[GitHub] [incubator-celeborn] pan3793 commented on a diff in pull request #1719: [CELEBORN-798] Add heartbeat from client to LifecycleManager to clean…

["pan3793 (via GitHub)" <gi...@apache.org>]

pan3793 commented on code in PR #1719:
URL: https://github.com/apache/incubator-celeborn/pull/1719#discussion_r1265062842


##########
client/src/main/java/org/apache/celeborn/client/ShuffleClientImpl.java:
##########
@@ -193,6 +193,24 @@ public ShuffleClientImpl(String appUniqueId, CelebornConf conf, UserIdentifier u
             "celeborn-shuffle-split", pushSplitPartitionThreads, 60);
     reviveManager = new ReviveManager(this, conf);
 
+    if (!isDriver) {
+      heartbeater =
+          ThreadUtils.newDaemonSingleThreadScheduledExecutor("lifecycleManager-heartbeater");
+      heartbeater.scheduleAtFixedRate(
+          () -> {
+            PbHeartbeatFromClientResponse resp =
+                lifecycleManagerRef.askSync(
+                    HeartbeatFromClient$.MODULE$.apply(reducePartitionMap.keySet()),
+                    ClassTag$.MODULE$.apply(PbHeartbeatFromClientResponse.class));
+            List<Integer> unkownShuffleIds = resp.getUnkownShuffleIdList();
+            for (int i = 0; i < unkownShuffleIds.size(); i++) {
+              unregisterShuffle(unkownShuffleIds.get(i), false);
+            }
+          },
+          60,

Review Comment:
   configurable?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org