You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/08/10 19:16:00 UTC
[GitHub] [hadoop-ozone] avijayanhwx opened a new pull request #1313: Revert HDDS-3798 & HDDS-3960.
avijayanhwx opened a new pull request #1313:
URL: https://github.com/apache/hadoop-ozone/pull/1313
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] avijayanhwx merged pull request #1313: Revert HDDS-3989 & HDDS-3960 from 0.6.0.
Posted by GitBox <gi...@apache.org>.
avijayanhwx merged pull request #1313:
URL: https://github.com/apache/hadoop-ozone/pull/1313
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] github-actions[bot] commented on pull request #1313: Revert HDDS-3798 & HDDS-3960 from 0.6.0.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #1313:
URL: https://github.com/apache/hadoop-ozone/pull/1313#issuecomment-671627642
To re-run CI checks, please follow these steps with the source branch checked out:
```
git commit --allow-empty -m 'trigger new CI check'
git push
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] avijayanhwx commented on pull request #1313: Revert HDDS-3798 & HDDS-3960 from 0.6.0.
Posted by GitBox <gi...@apache.org>.
avijayanhwx commented on pull request #1313:
URL: https://github.com/apache/hadoop-ozone/pull/1313#issuecomment-672899704
> Hi @avijayanhwx , I'm OK with the revert. Just need to confirm with you that, the reverted commits are [HDDS-3989](https://issues.apache.org/jira/browse/HDDS-3989) and [HDDS-3960](https://issues.apache.org/jira/browse/HDDS-3960), not the [HDDS-3798](https://issues.apache.org/jira/browse/HDDS-3798), or the [HDDS-3978](https://issues.apache.org/jira/browse/HDDS-3978), right?
Yes, that is correct. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] avijayanhwx commented on pull request #1313: Revert HDDS-3798 & HDDS-3960 from 0.6.0.
Posted by GitBox <gi...@apache.org>.
avijayanhwx commented on pull request #1313:
URL: https://github.com/apache/hadoop-ozone/pull/1313#issuecomment-671627256
/retest
> So, these changes need to be brought in with a corresponding MLV (Metadata Layout Version) change?
In HDDS-3978, to show more information on Recon, a few “static” fields like version and setup time were added to the core DatanodeDetails proto that is used for every heartbeat. In a subsequent JIRA (HDDS-4039), these fields are being moved to DN Register proto instead of heartbeat proto. If the changes in HDDS-3978 are shipped with 0.6.0 (GA), we could never remove them due to backward compatibility. If we revert HDDS-3978 instead, then the subsequent JIRA does not need to worry about backward compatibility. cc @runitao .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] avijayanhwx commented on pull request #1313: Revert HDDS-3798 & HDDS-3960 from 0.6.0.
Posted by GitBox <gi...@apache.org>.
avijayanhwx commented on pull request #1313:
URL: https://github.com/apache/hadoop-ozone/pull/1313#issuecomment-671627559
/retest
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] avijayanhwx edited a comment on pull request #1313: Revert HDDS-3798 & HDDS-3960 from 0.6.0.
Posted by GitBox <gi...@apache.org>.
avijayanhwx edited a comment on pull request #1313:
URL: https://github.com/apache/hadoop-ozone/pull/1313#issuecomment-671627256
> So, these changes need to be brought in with a corresponding MLV (Metadata Layout Version) change?
In HDDS-3978, to show more information on Recon, a few “static” fields like version and setup time were added to the core DatanodeDetails proto that is used for every heartbeat. In a subsequent JIRA (HDDS-4039), these fields are being moved to DN Register proto instead of heartbeat proto. If the changes in HDDS-3978 are shipped with 0.6.0 (GA), we could never remove them due to backward compatibility. If we revert HDDS-3978 instead, then the subsequent JIRA does not need to worry about backward compatibility. cc @runitao .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] runitao commented on pull request #1313: Revert HDDS-3798 & HDDS-3960 from 0.6.0.
Posted by GitBox <gi...@apache.org>.
runitao commented on pull request #1313:
URL: https://github.com/apache/hadoop-ozone/pull/1313#issuecomment-672644759
+1 LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] swagle commented on pull request #1313: Revert HDDS-3798 & HDDS-3960 from 0.6.0.
Posted by GitBox <gi...@apache.org>.
swagle commented on pull request #1313:
URL: https://github.com/apache/hadoop-ozone/pull/1313#issuecomment-671544792
So, these changes need to be brought in with a corresponding MLV (Metadata Layout Version) change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] avijayanhwx edited a comment on pull request #1313: Revert HDDS-3989 & HDDS-3960 from 0.6.0.
Posted by GitBox <gi...@apache.org>.
avijayanhwx edited a comment on pull request #1313:
URL: https://github.com/apache/hadoop-ozone/pull/1313#issuecomment-671627256
> So, these changes need to be brought in with a corresponding MLV (Metadata Layout Version) change?
In HDDS-3989, to show more information on Recon, a few “static” fields like version and setup time were added to the core DatanodeDetails proto that is used for every heartbeat. In a subsequent JIRA (HDDS-4039), these fields are being moved to DN Register proto instead of heartbeat proto. If the changes in HDDS-3989 are shipped with 0.6.0 (GA), we could never remove them due to backward compatibility. If we revert HDDS-3989 instead, then the subsequent JIRA does not need to worry about backward compatibility. cc @runitao .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] ChenSammi commented on pull request #1313: Revert HDDS-3798 & HDDS-3960 from 0.6.0.
Posted by GitBox <gi...@apache.org>.
ChenSammi commented on pull request #1313:
URL: https://github.com/apache/hadoop-ozone/pull/1313#issuecomment-672828578
Hi @avijayanhwx , I'm OK with the revert. Just need to confirm with you that, the reverted commits are HDDS-3989 and HDDS-3960, not the HDDS-3798, or the HDDS-3978, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org