[GitHub] [arrow-datafusion] jaylmiller commented on a diff in pull request #5242: Arrow Row Format in SortExec #5230

["jaylmiller (via GitHub)" <gi...@apache.org>]

jaylmiller commented on code in PR #5242:
URL: https://github.com/apache/arrow-datafusion/pull/5242#discussion_r1103812300


##########
datafusion/core/src/physical_plan/sorts/sort.rs:
##########
@@ -38,13 +38,14 @@ use crate::physical_plan::{
     RecordBatchStream, SendableRecordBatchStream, Statistics,
 };
 use crate::prelude::SessionConfig;
-use arrow::array::{make_array, Array, ArrayRef, MutableArrayData};
+use arrow::array::{make_array, Array, ArrayRef, MutableArrayData, UInt32Array};
 pub use arrow::compute::SortOptions;
 use arrow::compute::{concat, lexsort_to_indices, take, SortColumn, TakeOptions};
 use arrow::datatypes::SchemaRef;
 use arrow::error::ArrowError;
 use arrow::ipc::reader::FileReader;
 use arrow::record_batch::RecordBatch;
+use arrow::row::{OwnedRow, Row, RowConverter, SortField};

Review Comment:
   That sound's good. I will just revert this 2nd commit then. Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org