You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/07/01 09:42:21 UTC

[GitHub] [flink] dawidwys commented on a change in pull request #8929: [FLINK-13028][table] Move expression resolver to flink-table-api-java

dawidwys commented on a change in pull request #8929: [FLINK-13028][table] Move expression resolver to flink-table-api-java
URL: https://github.com/apache/flink/pull/8929#discussion_r298953719
 
 

 ##########
 File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/expressions/resolver/ExpressionResolver.java
 ##########
 @@ -97,15 +89,13 @@
 			ResolverRules.EXPAND_COLUMN_FUNCTIONS,
 			ResolverRules.OVER_WINDOWS,
 			ResolverRules.FIELD_RESOLVE,
-			ResolverRules.FLATTEN_CALL,
 			ResolverRules.QUALIFY_BUILT_IN_FUNCTIONS,
-			ResolverRules.RESOLVE_CALL_BY_ARGUMENTS);
+			ResolverRules.RESOLVE_CALL_BY_ARGUMENTS,
+			ResolverRules.FLATTEN_CALL);
 
 Review comment:
   I am not sure if it is correct to call the `FLATTEN_CALL` after `RESOLVE_CALL_BY_ARGUMENTS`. The `FLATTEN_CALL` may change the arguments list of other calls.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services