You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "Caideyipi (via GitHub)" <gi...@apache.org> on 2026/07/24 04:45:58 UTC

[PR] [Query] Retry schema queries after transient internal write failures [iotdb]

Caideyipi opened a new pull request, #18296:
URL: https://github.com/apache/iotdb/pull/18296

   ## Description
   
   ### Problem
   
   A table-model SELECT may execute an internal TableNodeLocationAddNode write before reading a SchemaRegion. When that write exhausts the Ratis-level retry during a transient leader step-down, the retryable write failure was returned directly to the client as a statement execution error.
   
   ### Fix
   
   - Reuse the existing write retry policy for this internal schema-query write.
   - Convert retryable internal write failures to DISPATCH_ERROR and set readNeedRetry, allowing the query scheduler to retry the query.
   - Preserve non-retryable failures and their original status.
   
   ### Test
   
   mvn -pl iotdb-core/datanode -am clean -Dtest=TableSchemaQueryWriteVisitorTest test
   
   This PR has:
   - [x] been self-reviewed.
   - [x] added comments explaining the intent of the retry conversion.
   - [x] added unit tests covering retryable and non-retryable internal write failures.
   
   ##### Key changed/added classes
   
   - TableSchemaQueryWriteVisitor
   - TableSchemaQueryWriteVisitorTest


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [Query] Retry schema queries after transient internal write failures [iotdb]

Posted by "jt2594838 (via GitHub)" <gi...@apache.org>.
jt2594838 merged PR #18296:
URL: https://github.com/apache/iotdb/pull/18296


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org