[jira] [Commented] (LUCENE-7385) SpanScorer's assert message strings should reference spans.toString()

["Adrien Grand (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-7385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15381999#comment-15381999 ] 

Adrien Grand commented on LUCENE-7385:
--------------------------------------

Using Spans.toString sounds more correct to me indeed.

> SpanScorer's assert message strings should reference spans.toString()
> ---------------------------------------------------------------------
>
>                 Key: LUCENE-7385
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7385
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/search
>            Reporter: David Smiley
>            Priority: Minor
>
> SpanScorer.setFreqCurrentDoc has a bunch of assert statements, and they refer to {{this.toString()}}.  I'm pretty confident the intention was for this to actually be {{spans.toString()}}, not "this" which is a SpanScorer that doesn't even have a custom toString.  It was probably correct once but after some refactoring of Spans got messed up, probably in LUCENE-6919 (Lucene 5.5).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org