You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/14 11:01:14 UTC
[GitHub] [spark] itholic opened a new pull request, #38657: [SPARK-41139][SQL] Improve error class: `PYTHON_UDF_IN_ON_CLAUSE`
itholic opened a new pull request, #38657:
URL: https://github.com/apache/spark/pull/38657
### What changes were proposed in this pull request?
This PR proposes to improve the error message and test for `PYTHON_UDF_IN_ON_CLAUSE`
### Why are the changes needed?
The current error message is not clear enough to let user understand the solve the problem.
We can provide more information to improve the usability.
Also, we should test the error class with `checkError` for better testability.
### Does this PR introduce _any_ user-facing change?
The error message is improved with additional detailed information.
From
```
Python UDF in the ON clause of a <joinType> JOIN.
```
To
```
Python UDF in the ON clause of a <joinType> JOIN. In case of an INNNER JOIN consider rewriting to a CROSS JOIN with a WHERE clause.
```
### How was this patch tested?
Manually tested for fixed test case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #38657: [SPARK-41139][SQL] Improve error class: `PYTHON_UDF_IN_ON_CLAUSE`
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #38657: [SPARK-41139][SQL] Improve error class: `PYTHON_UDF_IN_ON_CLAUSE`
URL: https://github.com/apache/spark/pull/38657
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #38657: [SPARK-41139][SQL] Improve error class: `PYTHON_UDF_IN_ON_CLAUSE`
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #38657:
URL: https://github.com/apache/spark/pull/38657#issuecomment-1317272185
+1, LGTM. Merging to master.
Thank you, @itholic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on pull request #38657: [SPARK-41139][SQL] Improve error class: `PYTHON_UDF_IN_ON_CLAUSE`
Posted by GitBox <gi...@apache.org>.
itholic commented on PR #38657:
URL: https://github.com/apache/spark/pull/38657#issuecomment-1313489138
cc @srielau @MaxGekk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org