You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/02/17 02:54:45 UTC

[GitHub] [incubator-kyuubi] iodone opened a new issue #1920: [FEATURE] planOnlyStatement adds real execution of Use Database Statement like Set and ReSet Commond

iodone opened a new issue #1920:
URL: https://github.com/apache/incubator-kyuubi/issues/1920


   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   
   
   ### Search before asking
   
   - [X] I have searched in the [issues](https://github.com/apache/incubator-kyuubi/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### Describe the feature
   
   When using planOnly mode to parse some SQL statements in kyuubi, there are usually multiple SQL statements containing `USE Database` that are context sensitive. If the `USE` statement is also just plan parsed and not really executed, the next SQL references a table name under the current database, it will throw a Table Not Found Exception when analyzing and optimizing the plan. 
   
   We can skip the Plan parsing of `UseStatement` and actually execute it like `SetCommand`
   
   ### Motivation
   
   _No response_
   
   ### Describe the solution
   
   _No response_
   
   ### Additional context
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] iodone edited a comment on issue #1920: [FEATURE] PlanOnlyStatement adds real execution of Use Database Statement like Set and ReSet Command

Posted by GitBox <gi...@apache.org>.
iodone edited a comment on issue #1920:
URL: https://github.com/apache/incubator-kyuubi/issues/1920#issuecomment-1046383849


   
   @wForget , It should have the same problem, including `cache table` statement is the same, I'm not sure if I need to fix these two. In the real application scenario, `UseStatement` is the most common. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] wForget commented on issue #1920: [FEATURE] planOnlyStatement adds real execution of Use Database Statement like Set and ReSet Commond

Posted by GitBox <gi...@apache.org>.
wForget commented on issue #1920:
URL: https://github.com/apache/incubator-kyuubi/issues/1920#issuecomment-1044218893


   Does `create temporary view` also have the same problem?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] yaooqinn closed issue #1920: [FEATURE] Skipping use/cacheTable/createView command in PlanOnlyStatement like Set and ReSet Command

Posted by GitBox <gi...@apache.org>.
yaooqinn closed issue #1920:
URL: https://github.com/apache/incubator-kyuubi/issues/1920


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] SteNicholas commented on issue #1920: [FEATURE] PlanOnlyStatement adds real execution of Use Database Statement like Set and ReSet Command

Posted by GitBox <gi...@apache.org>.
SteNicholas commented on issue #1920:
URL: https://github.com/apache/incubator-kyuubi/issues/1920#issuecomment-1046388041


   @iodone, IMO, the `create temporary view` and `cache table` statement could also be fixed in this issue. You could update the title and description of the issue for fix these statements. 
   cc @wForget 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] iodone commented on issue #1920: [FEATURE] PlanOnlyStatement adds real execution of Use Database Statement like Set and ReSet Command

Posted by GitBox <gi...@apache.org>.
iodone commented on issue #1920:
URL: https://github.com/apache/incubator-kyuubi/issues/1920#issuecomment-1046383849


   > wForget
   
   It should have the same problem, including `cache table` statement is the same, I'm not sure if I need to fix these two. In the real application scenario, `UseStatement` is the most common. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] SteNicholas edited a comment on issue #1920: [FEATURE] planOnlyStatement adds real execution of Use Database Statement like Set and ReSet Commond

Posted by GitBox <gi...@apache.org>.
SteNicholas edited a comment on issue #1920:
URL: https://github.com/apache/incubator-kyuubi/issues/1920#issuecomment-1046372176


   @iodone, the title of the issue has the typo: Commond -> Command, planOnlyStatement -> `PlanOnlyStatement`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] SteNicholas commented on issue #1920: [FEATURE] planOnlyStatement adds real execution of Use Database Statement like Set and ReSet Commond

Posted by GitBox <gi...@apache.org>.
SteNicholas commented on issue #1920:
URL: https://github.com/apache/incubator-kyuubi/issues/1920#issuecomment-1046372176


   @iodone, the title of the issue has the typo: Commond -> Command.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] yaooqinn commented on issue #1920: [FEATURE] PlanOnlyStatement adds real execution of Use Database Statement like Set and ReSet Command

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on issue #1920:
URL: https://github.com/apache/incubator-kyuubi/issues/1920#issuecomment-1046736582


   we can create a new issue and make it more generic after this one.
   
   i.e, we can add a conf named `kyuubi.operation.plan.only.skip` for skipping `set/reset/use` and other custom commands/plans


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org