You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org> on 2012/03/02 20:07:58 UTC

[jira] [Commented] (OOZIE-684) A race condition may happen under stress while executing an interrupt command

    [ https://issues.apache.org/jira/browse/OOZIE-684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221168#comment-13221168 ] 

jiraposter@reviews.apache.org commented on OOZIE-684:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4035/#review5572
-----------------------------------------------------------



http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/command/XCommand.java
<https://reviews.apache.org/r/4035/#comment12064>

    Wouldn't be simpler to use an AtomicBoolean for used?
    
    if (used.compare(true, true)) {
    ....
    }



http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/command/XCommand.java
<https://reviews.apache.org/r/4035/#comment12065>

    shouldn't be 
    
    if (this.getInterrupMode()) {
    ...
    }



http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/command/XCommand.java
<https://reviews.apache.org/r/4035/#comment12067>

    also, the getInterruptMode() method should be isInterruptMode()


- Alejandro


On 2012-02-28 18:25:19, Mohamed Battisha wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4035/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-02-28 18:25:19)
bq.  
bq.  
bq.  Review request for oozie.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  While executing an interrupt driven commands it may be executed from the map on one thread and executed from the queue at a different thread 
bq.  This will cause the following exception to be thrown: 
bq.  java.lang.IllegalStateException: CoordChangeXCommand already used. 
bq.  
bq.  - Avoiding throwing exception in case of interrupts and synchronizing the changes in [used] 
bq.  - Avoiding executing interrupt in case of commands that doesn't need locks
bq.  - Changing the debug message for execute interrupt to explicitly mentioning it is an interrupt command
bq.  
bq.  
bq.  This addresses bug OOZIE-684.
bq.      https://issues.apache.org/jira/browse/OOZIE-684
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1293381 
bq.  
bq.  Diff: https://reviews.apache.org/r/4035/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Mohamed
bq.  
bq.


                
> A race condition may happen under stress while executing an interrupt command
> -----------------------------------------------------------------------------
>
>                 Key: OOZIE-684
>                 URL: https://issues.apache.org/jira/browse/OOZIE-684
>             Project: Oozie
>          Issue Type: Bug
>            Reporter: Mohamed Battisha
>              Labels: performance
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> While executing an interrupt driven commands it may be executed from the map on one thread and executed from the queue at a different thread
> This will cause the following exception to be thrown:
> java.lang.IllegalStateException: CoordChangeXCommand already used.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira