You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/12/27 10:35:50 UTC

[GitHub] [rocketmq] Oliverwqcwrw commented on a diff in pull request #5769: [ISSUE #5766] fix possible msg NPE

Oliverwqcwrw commented on code in PR #5769:
URL: https://github.com/apache/rocketmq/pull/5769#discussion_r1057594259


##########
client/src/main/java/org/apache/rocketmq/client/impl/consumer/ProcessQueue.java:
##########
@@ -102,6 +98,10 @@ public void cleanExpiredMsg(DefaultMQPushConsumer pushConsumer) {
                 log.error("getExpiredMsg exception", e);
             }
 
+            if (msg == null) {
+                break;

Review Comment:
   The rest of msgTreeMap's messages can't be processed after the loop terminates,
   
   Is it OK to skip processing message that are currently empty?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org