[GitHub] [hive] pvary commented on a diff in pull request #3298: HIVE-26237: Check if replication cause metastore connection leakage

[GitBox <gi...@apache.org>]

pvary commented on code in PR #3298:
URL: https://github.com/apache/hive/pull/3298#discussion_r875767443


##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java:
##########
@@ -500,6 +500,10 @@ public static Hive getThreadLocal() {
     return hiveDB.get();
   }
 
+  public static Hive getCurrHiveDb(Hive hiveDb, HiveConf c) throws HiveException {

Review Comment:
   Do we really want to have a new method for this?
   
   What if we modify the `get`, or the `getThreadLocal` to provide an always open `Hive`? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org