You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@linkis.apache.org by "GuoPhilipse (via GitHub)" <gi...@apache.org> on 2023/05/19 16:45:37 UTC
[GitHub] [linkis-website] GuoPhilipse opened a new pull request, #704: update 1.4.0 feature docs
GuoPhilipse opened a new pull request, #704:
URL: https://github.com/apache/linkis-website/pull/704
fix #703
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org
[GitHub] [linkis-website] aiceflower commented on pull request #704: update 1.4.0 feature docs
Posted by "aiceflower (via GitHub)" <gi...@apache.org>.
aiceflower commented on PR #704:
URL: https://github.com/apache/linkis-website/pull/704#issuecomment-1579790902
LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org
[GitHub] [linkis-website] netlify[bot] commented on pull request #704: update 1.4.0 feature docs
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #704:
URL: https://github.com/apache/linkis-website/pull/704#issuecomment-1554878969
### <span aria-hidden="true">👷</span> Deploy Preview for *apache-linkis-website* processing.
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 3261b5b698b4bdeb7acc40dd68e392146a480ce9 |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/sites/apache-linkis-website/deploys/6467a7b13f78650008b8deff |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org
[GitHub] [linkis-website] casionone merged pull request #704: update 1.4.0 feature docs
Posted by "casionone (via GitHub)" <gi...@apache.org>.
casionone merged PR #704:
URL: https://github.com/apache/linkis-website/pull/704
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org
[GitHub] [linkis-website] aiceflower commented on a diff in pull request #704: update 1.4.0 feature docs
Posted by "aiceflower (via GitHub)" <gi...@apache.org>.
aiceflower commented on code in PR #704:
URL: https://github.com/apache/linkis-website/pull/704#discussion_r1206196798
##########
i18n/zh-CN/docusaurus-plugin-content-docs/current/feature/remove-underlying-engine-depdency.md:
##########
@@ -0,0 +1,16 @@
+---
+title: EngineConn模块定义依赖引擎版本
+sidebar_position: 0.2
+---
+
+## 1. 需求背景
+引擎的版本定义默认在 `EngineConn`中，一旦相关版本变更，需要修改多处，我们可以把相关的版本定义统一放到顶层pom文件中
+
+## 2. 使用说明
+编译指定引擎模块时，需要在项目根目录编译，并使用`-pl`来编译具体的引擎模块，比如：
+```
+mvn install package -pl linkis-engineconn-plugins/spark
+
+```
Review Comment:
Can you give an example of how to change the engine version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org
[GitHub] [linkis-website] GuoPhilipse commented on a diff in pull request #704: update 1.4.0 feature docs
Posted by "GuoPhilipse (via GitHub)" <gi...@apache.org>.
GuoPhilipse commented on code in PR #704:
URL: https://github.com/apache/linkis-website/pull/704#discussion_r1207893875
##########
i18n/zh-CN/docusaurus-plugin-content-docs/current/feature/remove-underlying-engine-depdency.md:
##########
@@ -0,0 +1,16 @@
+---
+title: EngineConn模块定义依赖引擎版本
+sidebar_position: 0.2
+---
+
+## 1. 需求背景
+引擎的版本定义默认在 `EngineConn`中，一旦相关版本变更，需要修改多处，我们可以把相关的版本定义统一放到顶层pom文件中
+
+## 2. 使用说明
+编译指定引擎模块时，需要在项目根目录编译，并使用`-pl`来编译具体的引擎模块，比如：
+```
+mvn install package -pl linkis-engineconn-plugins/spark
+
+```
Review Comment:
sure ,later will add the example
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org