[GitHub] [incubator-inlong] imvan commented on a change in pull request #2713: [INLONG-2384][SDK] Sort-sdk support Tube consumer of PB compression cache message protocol

[GitBox <gi...@apache.org>]

imvan commented on a change in pull request #2713:
URL: https://github.com/apache/incubator-inlong/pull/2713#discussion_r814765165



##########
File path: inlong-sdk/sort-sdk/src/main/java/org/apache/inlong/sdk/sort/impl/tube/InLongTubeFetcherImpl.java
##########
@@ -90,15 +89,15 @@ public boolean init(Object object) {
     @Override
     public void ack(String msgOffset) throws Exception {
         if (!StringUtils.isEmpty(msgOffset)) {
-            try {
-                if (messageConsumer == null) {
-                    context.getStatManager().getStatistics(context.getConfig().getSortTaskId(),
-                            inLongTopic.getInLongCluster().getClusterId(), inLongTopic.getTopic())
-                            .addAckFailTimes(1L);
-                    LOG.error("consumer == null");
-                    return;
-                }
+            if (messageConsumer == null) {
+                context.getStatManager().getStatistics(context.getConfig().getSortTaskId(),

Review comment:
       need new line when call getStatistics()




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org