[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2192: IGNITE-17765 Sql. Introduce cache for parsed statements

["korlov42 (via GitHub)" <gi...@apache.org>]

korlov42 commented on code in PR #2192:
URL: https://github.com/apache/ignite-3/pull/2192#discussion_r1229311140


##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/CacheKey.java:
##########
@@ -74,25 +66,24 @@ public boolean equals(Object o) {
 
         CacheKey cacheKey = (CacheKey) o;
 
-        if (!schemaName.equals(cacheKey.schemaName)) {
+        if (catalogVersion != cacheKey.catalogVersion){
             return false;
         }
         if (!query.equals(cacheKey.query)) {
             return false;
         }
-        if (!Objects.equals(contextKey, cacheKey.contextKey)) {
+        if (!query.equals(cacheKey.query)) {

Review Comment:
   you've checked `query` already



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org