You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "jcrouvi (JIRA)" <ji...@codehaus.org> on 2008/11/21 12:55:41 UTC
[jira] Created: (MRELEASE-389) Properties releaseVersion and
developmentVersion are not read correctly during release:prepare
(eventually release:perform)
Properties releaseVersion and developmentVersion are not read correctly during release:prepare (eventually release:perform)
---------------------------------------------------------------------------------------------------------------------------
Key: MRELEASE-389
URL: http://jira.codehaus.org/browse/MRELEASE-389
Project: Maven 2.x Release Plugin
Issue Type: Bug
Affects Versions: 2.0-beta-8
Environment: Maven version: 2.0.9
Java version: 1.6.0_07
OS name: "windows xp" version: "5.1" arch: "x86" Family: "windows"
scm=CVS
Reporter: jcrouvi
Calling
mvn --batch-mode release:prepare release:perform -Dtag=TEST_RELEASE-3_0_0 -DreleaseVersion=3.0.0 -DdevelopmentVersion=3.0.1-SNAPSHOT
doesn't produce the expected results:
* -DdevelopmentVersion=3.0.1-SNAPSHOT
** the value is not set correctly in the file pom.xml:
*** Expected: <version>3.0.1-SNAPSHOT</version>
*** But was: <version>2.0.5-SNAPSHOT</version>
* -DreleaseVersion=3.0.0
** the artifacts are not created correctly:
*** Expected artifact: ipi-multimodule-b-3.0.0.jar
*** But was: ipi-multimodule-b-2.0.4.jar
** the value is not set correctly in the file pom.xml (comment in CVS: [maven-release-plugin] prepare release TEST_RELEASE-3_0_0):
*** Expected: <version>3.0.0</version>
*** But was: <version>2.0.4</version>
* -Dtag=TEST_RELEASE-3_0_0
** the value is set correctly in the file pom.xml
** the tagging of the CVS module is also correct.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MRELEASE-389) Properties releaseVersion and
developmentVersion are not read correctly during release:prepare
(eventually release:perform)
Posted by "jcrouvi (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRELEASE-389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
jcrouvi updated MRELEASE-389:
-----------------------------
Attachment: jcrouvi_20081204_test.log
Test
> Properties releaseVersion and developmentVersion are not read correctly during release:prepare (eventually release:perform)
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: MRELEASE-389
> URL: http://jira.codehaus.org/browse/MRELEASE-389
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Affects Versions: 2.0-beta-8
> Environment: Maven version: 2.0.9
> Java version: 1.6.0_07
> OS name: "windows xp" version: "5.1" arch: "x86" Family: "windows"
> scm=CVS
> Reporter: jcrouvi
> Fix For: 2.0-beta-9
>
> Attachments: jcrouvi_20081204_test.log, Patch-MRELEASE-389.txt
>
>
> Calling
> mvn --batch-mode release:prepare release:perform -Dtag=TEST_RELEASE-3_0_0 -DreleaseVersion=3.0.0 -DdevelopmentVersion=3.0.1-SNAPSHOT
> doesn't produce the expected results:
> * -DdevelopmentVersion=3.0.1-SNAPSHOT
> ** the value is not set correctly in the file pom.xml:
> *** Expected: <version>3.0.1-SNAPSHOT</version>
> *** But was: <version>2.0.5-SNAPSHOT</version>
> * -DreleaseVersion=3.0.0
> ** the artifacts are not created correctly:
> *** Expected artifact: ipi-multimodule-b-3.0.0.jar
> *** But was: ipi-multimodule-b-2.0.4.jar
> ** the value is not set correctly in the file pom.xml (comment in CVS: [maven-release-plugin] prepare release TEST_RELEASE-3_0_0):
> *** Expected: <version>3.0.0</version>
> *** But was: <version>2.0.4</version>
> * -Dtag=TEST_RELEASE-3_0_0
> ** the value is set correctly in the file pom.xml
> ** the tagging of the CVS module is also correct.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MRELEASE-389) Properties releaseVersion and
developmentVersion are not read correctly during release:prepare
(eventually release:perform)
Posted by "Paul Gier (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRELEASE-389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=156757#action_156757 ]
Paul Gier commented on MRELEASE-389:
------------------------------------
{quote}
However, looking at the source, I do not understand where the command-line properties are pushed towards a ReleaseDescriptor object besides the method ReleaseUtils.copyPropertiesToReleaseDescriptor(Properties).
{quote}
Ringo,
You should be able to set the version plugin parameters through the command line using those properties (releaseVersion and developmentVersion). The plugin parameters are configured to pick up the command line properties like this.
{code}
/**
* @parameter expression="${releaseVersion}"
*/
private String releaseVersion;
{code}
The copy properties part is only used to pick up properties that can't be set through the plugin parameters. For example the module specific versions in a multi module release.
But if it's not working for you with 2.0-beta-8 or the beta-9 snapshot then there must be something else going wrong. And if you can help me track it down, I can try to fix it.
> Properties releaseVersion and developmentVersion are not read correctly during release:prepare (eventually release:perform)
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: MRELEASE-389
> URL: http://jira.codehaus.org/browse/MRELEASE-389
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Affects Versions: 2.0-beta-8
> Environment: Maven version: 2.0.9
> Java version: 1.6.0_07
> OS name: "windows xp" version: "5.1" arch: "x86" Family: "windows"
> scm=CVS
> Reporter: jcrouvi
> Fix For: 2.0-beta-9
>
> Attachments: jcrouvi_20081204_test.log, Patch-MRELEASE-389.txt
>
>
> Calling
> mvn --batch-mode release:prepare release:perform -Dtag=TEST_RELEASE-3_0_0 -DreleaseVersion=3.0.0 -DdevelopmentVersion=3.0.1-SNAPSHOT
> doesn't produce the expected results:
> * -DdevelopmentVersion=3.0.1-SNAPSHOT
> ** the value is not set correctly in the file pom.xml:
> *** Expected: <version>3.0.1-SNAPSHOT</version>
> *** But was: <version>2.0.5-SNAPSHOT</version>
> * -DreleaseVersion=3.0.0
> ** the artifacts are not created correctly:
> *** Expected artifact: ipi-multimodule-b-3.0.0.jar
> *** But was: ipi-multimodule-b-2.0.4.jar
> ** the value is not set correctly in the file pom.xml (comment in CVS: [maven-release-plugin] prepare release TEST_RELEASE-3_0_0):
> *** Expected: <version>3.0.0</version>
> *** But was: <version>2.0.4</version>
> * -Dtag=TEST_RELEASE-3_0_0
> ** the value is set correctly in the file pom.xml
> ** the tagging of the CVS module is also correct.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MRELEASE-389) Properties releaseVersion and
developmentVersion are not read correctly during release:prepare
(eventually release:perform)
Posted by "Ringo De Smet (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRELEASE-389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ringo De Smet updated MRELEASE-389:
-----------------------------------
Attachment: Patch-MRELEASE-389.txt
Patch-MRELEASE-389.txt contains a patch for this issue against the following file:
maven-release-manager/src/main/java/org/apache/maven/shared/release/util/ReleaseUtil.java
This patch has been tested manually using a private version of maven-release-manager and maven-release-plugin.
Can this be taken along for maven-release-plugin 2.0.9 release?
Ringo
> Properties releaseVersion and developmentVersion are not read correctly during release:prepare (eventually release:perform)
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: MRELEASE-389
> URL: http://jira.codehaus.org/browse/MRELEASE-389
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Affects Versions: 2.0-beta-8
> Environment: Maven version: 2.0.9
> Java version: 1.6.0_07
> OS name: "windows xp" version: "5.1" arch: "x86" Family: "windows"
> scm=CVS
> Reporter: jcrouvi
> Attachments: Patch-MRELEASE-389.txt
>
>
> Calling
> mvn --batch-mode release:prepare release:perform -Dtag=TEST_RELEASE-3_0_0 -DreleaseVersion=3.0.0 -DdevelopmentVersion=3.0.1-SNAPSHOT
> doesn't produce the expected results:
> * -DdevelopmentVersion=3.0.1-SNAPSHOT
> ** the value is not set correctly in the file pom.xml:
> *** Expected: <version>3.0.1-SNAPSHOT</version>
> *** But was: <version>2.0.5-SNAPSHOT</version>
> * -DreleaseVersion=3.0.0
> ** the artifacts are not created correctly:
> *** Expected artifact: ipi-multimodule-b-3.0.0.jar
> *** But was: ipi-multimodule-b-2.0.4.jar
> ** the value is not set correctly in the file pom.xml (comment in CVS: [maven-release-plugin] prepare release TEST_RELEASE-3_0_0):
> *** Expected: <version>3.0.0</version>
> *** But was: <version>2.0.4</version>
> * -Dtag=TEST_RELEASE-3_0_0
> ** the value is set correctly in the file pom.xml
> ** the tagging of the CVS module is also correct.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MRELEASE-389) Properties releaseVersion and
developmentVersion are not read correctly during release:prepare
(eventually release:perform)
Posted by "Ringo De Smet (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRELEASE-389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=166245#action_166245 ]
Ringo De Smet commented on MRELEASE-389:
----------------------------------------
I think I found the reason why it didn't work for me: the releaseVersion and developmentVersion properties only seem to be picked up from the command line properties if you use the batch-mode argument. Correct? If so, this wasn't completely clear from the documentation.
However, if I just run mvn release:prepare, the release plugin doesn't prompt me for the release and development versions. It just calculates the next version from the current goes on with preparing a release. Anyone knows what the cause could be?
> Properties releaseVersion and developmentVersion are not read correctly during release:prepare (eventually release:perform)
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: MRELEASE-389
> URL: http://jira.codehaus.org/browse/MRELEASE-389
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Components: prepare
> Affects Versions: 2.0-beta-8
> Environment: Maven version: 2.0.9
> Java version: 1.6.0_07
> OS name: "windows xp" version: "5.1" arch: "x86" Family: "windows"
> scm=CVS
> Reporter: jcrouvi
> Fix For: 2.0-beta-9
>
> Attachments: jcrouvi_20081204_test.log, Patch-MRELEASE-389.txt
>
>
> Calling
> mvn --batch-mode release:prepare release:perform -Dtag=TEST_RELEASE-3_0_0 -DreleaseVersion=3.0.0 -DdevelopmentVersion=3.0.1-SNAPSHOT
> doesn't produce the expected results:
> * -DdevelopmentVersion=3.0.1-SNAPSHOT
> ** the value is not set correctly in the file pom.xml:
> *** Expected: <version>3.0.1-SNAPSHOT</version>
> *** But was: <version>2.0.5-SNAPSHOT</version>
> * -DreleaseVersion=3.0.0
> ** the artifacts are not created correctly:
> *** Expected artifact: ipi-multimodule-b-3.0.0.jar
> *** But was: ipi-multimodule-b-2.0.4.jar
> ** the value is not set correctly in the file pom.xml (comment in CVS: [maven-release-plugin] prepare release TEST_RELEASE-3_0_0):
> *** Expected: <version>3.0.0</version>
> *** But was: <version>2.0.4</version>
> * -Dtag=TEST_RELEASE-3_0_0
> ** the value is set correctly in the file pom.xml
> ** the tagging of the CVS module is also correct.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MRELEASE-389) Properties releaseVersion and
developmentVersion are not read correctly during release:prepare
(eventually release:perform)
Posted by "Paul Gier (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRELEASE-389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Gier updated MRELEASE-389:
-------------------------------
Patch Submitted: [Yes]
> Properties releaseVersion and developmentVersion are not read correctly during release:prepare (eventually release:perform)
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: MRELEASE-389
> URL: http://jira.codehaus.org/browse/MRELEASE-389
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Affects Versions: 2.0-beta-8
> Environment: Maven version: 2.0.9
> Java version: 1.6.0_07
> OS name: "windows xp" version: "5.1" arch: "x86" Family: "windows"
> scm=CVS
> Reporter: jcrouvi
> Fix For: 2.0-beta-9
>
> Attachments: Patch-MRELEASE-389.txt
>
>
> Calling
> mvn --batch-mode release:prepare release:perform -Dtag=TEST_RELEASE-3_0_0 -DreleaseVersion=3.0.0 -DdevelopmentVersion=3.0.1-SNAPSHOT
> doesn't produce the expected results:
> * -DdevelopmentVersion=3.0.1-SNAPSHOT
> ** the value is not set correctly in the file pom.xml:
> *** Expected: <version>3.0.1-SNAPSHOT</version>
> *** But was: <version>2.0.5-SNAPSHOT</version>
> * -DreleaseVersion=3.0.0
> ** the artifacts are not created correctly:
> *** Expected artifact: ipi-multimodule-b-3.0.0.jar
> *** But was: ipi-multimodule-b-2.0.4.jar
> ** the value is not set correctly in the file pom.xml (comment in CVS: [maven-release-plugin] prepare release TEST_RELEASE-3_0_0):
> *** Expected: <version>3.0.0</version>
> *** But was: <version>2.0.4</version>
> * -Dtag=TEST_RELEASE-3_0_0
> ** the value is set correctly in the file pom.xml
> ** the tagging of the CVS module is also correct.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (MRELEASE-389) Properties
releaseVersion and developmentVersion are not read correctly during
release:prepare (eventually release:perform)
Posted by "Ringo De Smet (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRELEASE-389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=156467#action_156467 ]
Ringo De Smet edited comment on MRELEASE-389 at 12/3/08 8:32 AM:
-----------------------------------------------------------------
Patch-MRELEASE-389.txt contains a patch for this issue against the following file:
maven-release-manager/src/main/java/org/apache/maven/shared/release/util/ReleaseUtil.java
This patch has been tested manually using a private version of maven-release-manager and maven-release-plugin.
Can this be taken along for maven-release-plugin 2.0-beta-9 release?
Ringo
was (Author: ringods):
Patch-MRELEASE-389.txt contains a patch for this issue against the following file:
maven-release-manager/src/main/java/org/apache/maven/shared/release/util/ReleaseUtil.java
This patch has been tested manually using a private version of maven-release-manager and maven-release-plugin.
Can this be taken along for maven-release-plugin 2.0.9 release?
Ringo
> Properties releaseVersion and developmentVersion are not read correctly during release:prepare (eventually release:perform)
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: MRELEASE-389
> URL: http://jira.codehaus.org/browse/MRELEASE-389
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Affects Versions: 2.0-beta-8
> Environment: Maven version: 2.0.9
> Java version: 1.6.0_07
> OS name: "windows xp" version: "5.1" arch: "x86" Family: "windows"
> scm=CVS
> Reporter: jcrouvi
> Attachments: Patch-MRELEASE-389.txt
>
>
> Calling
> mvn --batch-mode release:prepare release:perform -Dtag=TEST_RELEASE-3_0_0 -DreleaseVersion=3.0.0 -DdevelopmentVersion=3.0.1-SNAPSHOT
> doesn't produce the expected results:
> * -DdevelopmentVersion=3.0.1-SNAPSHOT
> ** the value is not set correctly in the file pom.xml:
> *** Expected: <version>3.0.1-SNAPSHOT</version>
> *** But was: <version>2.0.5-SNAPSHOT</version>
> * -DreleaseVersion=3.0.0
> ** the artifacts are not created correctly:
> *** Expected artifact: ipi-multimodule-b-3.0.0.jar
> *** But was: ipi-multimodule-b-2.0.4.jar
> ** the value is not set correctly in the file pom.xml (comment in CVS: [maven-release-plugin] prepare release TEST_RELEASE-3_0_0):
> *** Expected: <version>3.0.0</version>
> *** But was: <version>2.0.4</version>
> * -Dtag=TEST_RELEASE-3_0_0
> ** the value is set correctly in the file pom.xml
> ** the tagging of the CVS module is also correct.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MRELEASE-389) Properties releaseVersion and
developmentVersion are not read correctly during release:prepare
(eventually release:perform)
Posted by "Paul Gier (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRELEASE-389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=156639#action_156639 ]
Paul Gier commented on MRELEASE-389:
------------------------------------
I wasn't able to reproduce this. Can you provide more information?
I ran a release:prepare in batch mode using -DdevelopmentVersion and releaseVersion and both were set correctly in the release.properties and in the poms.
Did you do a release:prepare before the release? Or did you have any other settings that might have interfered?
> Properties releaseVersion and developmentVersion are not read correctly during release:prepare (eventually release:perform)
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: MRELEASE-389
> URL: http://jira.codehaus.org/browse/MRELEASE-389
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Affects Versions: 2.0-beta-8
> Environment: Maven version: 2.0.9
> Java version: 1.6.0_07
> OS name: "windows xp" version: "5.1" arch: "x86" Family: "windows"
> scm=CVS
> Reporter: jcrouvi
> Fix For: 2.0-beta-9
>
> Attachments: Patch-MRELEASE-389.txt
>
>
> Calling
> mvn --batch-mode release:prepare release:perform -Dtag=TEST_RELEASE-3_0_0 -DreleaseVersion=3.0.0 -DdevelopmentVersion=3.0.1-SNAPSHOT
> doesn't produce the expected results:
> * -DdevelopmentVersion=3.0.1-SNAPSHOT
> ** the value is not set correctly in the file pom.xml:
> *** Expected: <version>3.0.1-SNAPSHOT</version>
> *** But was: <version>2.0.5-SNAPSHOT</version>
> * -DreleaseVersion=3.0.0
> ** the artifacts are not created correctly:
> *** Expected artifact: ipi-multimodule-b-3.0.0.jar
> *** But was: ipi-multimodule-b-2.0.4.jar
> ** the value is not set correctly in the file pom.xml (comment in CVS: [maven-release-plugin] prepare release TEST_RELEASE-3_0_0):
> *** Expected: <version>3.0.0</version>
> *** But was: <version>2.0.4</version>
> * -Dtag=TEST_RELEASE-3_0_0
> ** the value is set correctly in the file pom.xml
> ** the tagging of the CVS module is also correct.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MRELEASE-389) Properties releaseVersion and
developmentVersion are not read correctly during release:prepare
(eventually release:perform)
Posted by "Arnaud Heritier (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRELEASE-389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arnaud Heritier updated MRELEASE-389:
-------------------------------------
Component/s: prepare
> Properties releaseVersion and developmentVersion are not read correctly during release:prepare (eventually release:perform)
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: MRELEASE-389
> URL: http://jira.codehaus.org/browse/MRELEASE-389
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Components: prepare
> Affects Versions: 2.0-beta-8
> Environment: Maven version: 2.0.9
> Java version: 1.6.0_07
> OS name: "windows xp" version: "5.1" arch: "x86" Family: "windows"
> scm=CVS
> Reporter: jcrouvi
> Fix For: 2.0-beta-9
>
> Attachments: jcrouvi_20081204_test.log, Patch-MRELEASE-389.txt
>
>
> Calling
> mvn --batch-mode release:prepare release:perform -Dtag=TEST_RELEASE-3_0_0 -DreleaseVersion=3.0.0 -DdevelopmentVersion=3.0.1-SNAPSHOT
> doesn't produce the expected results:
> * -DdevelopmentVersion=3.0.1-SNAPSHOT
> ** the value is not set correctly in the file pom.xml:
> *** Expected: <version>3.0.1-SNAPSHOT</version>
> *** But was: <version>2.0.5-SNAPSHOT</version>
> * -DreleaseVersion=3.0.0
> ** the artifacts are not created correctly:
> *** Expected artifact: ipi-multimodule-b-3.0.0.jar
> *** But was: ipi-multimodule-b-2.0.4.jar
> ** the value is not set correctly in the file pom.xml (comment in CVS: [maven-release-plugin] prepare release TEST_RELEASE-3_0_0):
> *** Expected: <version>3.0.0</version>
> *** But was: <version>2.0.4</version>
> * -Dtag=TEST_RELEASE-3_0_0
> ** the value is set correctly in the file pom.xml
> ** the tagging of the CVS module is also correct.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MRELEASE-389) Properties releaseVersion and
developmentVersion are not read correctly during release:prepare
(eventually release:perform)
Posted by "jcrouvi (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRELEASE-389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=156709#action_156709 ]
jcrouvi commented on MRELEASE-389:
----------------------------------
I have just tested it again and it works (??). I can not reproduce the bug.
* Before the tests I called:
** {{mvn clean}}
** {{mvn release:clean}}
* The version of the original pom file before the test was:
{{<version>4.0.2-SNAPSHOT</version>}}
* Before the tests I removed all maven-release plugins from my repository
{{rm -rf $M2_REPOS/org/apache/maven/release}}
and downloaded them again:
** Downloading: http://repository.ipie.ch/content/groups/public/org/apache/maven/release/maven-release/5/maven-release-5.pom
** Downloading: http://repository.ipie.ch/content/groups/public/org/apache/maven/release/maven-release-manager/1.0-alpha-5/maven-release-manager-1.0-alpha-5.pom
** Downloading: http://repository.ipie.ch/content/groups/public/org/apache/maven/release/maven-release-manager/1.0-alpha-5/maven-release-manager-1.0-alpha-5.jar
The reason of the unexpected behiaviour is perhaps the patch and the modification I made to the maven-release-manager because of the bug
http://jira.codehaus.org/browse/MRELEASE-128?actionOrder=desc
I attached the protocol of my test: text file {{jcrouvi_20081204_test.log}}
> Properties releaseVersion and developmentVersion are not read correctly during release:prepare (eventually release:perform)
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: MRELEASE-389
> URL: http://jira.codehaus.org/browse/MRELEASE-389
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Affects Versions: 2.0-beta-8
> Environment: Maven version: 2.0.9
> Java version: 1.6.0_07
> OS name: "windows xp" version: "5.1" arch: "x86" Family: "windows"
> scm=CVS
> Reporter: jcrouvi
> Fix For: 2.0-beta-9
>
> Attachments: jcrouvi_20081204_test.log, Patch-MRELEASE-389.txt
>
>
> Calling
> mvn --batch-mode release:prepare release:perform -Dtag=TEST_RELEASE-3_0_0 -DreleaseVersion=3.0.0 -DdevelopmentVersion=3.0.1-SNAPSHOT
> doesn't produce the expected results:
> * -DdevelopmentVersion=3.0.1-SNAPSHOT
> ** the value is not set correctly in the file pom.xml:
> *** Expected: <version>3.0.1-SNAPSHOT</version>
> *** But was: <version>2.0.5-SNAPSHOT</version>
> * -DreleaseVersion=3.0.0
> ** the artifacts are not created correctly:
> *** Expected artifact: ipi-multimodule-b-3.0.0.jar
> *** But was: ipi-multimodule-b-2.0.4.jar
> ** the value is not set correctly in the file pom.xml (comment in CVS: [maven-release-plugin] prepare release TEST_RELEASE-3_0_0):
> *** Expected: <version>3.0.0</version>
> *** But was: <version>2.0.4</version>
> * -Dtag=TEST_RELEASE-3_0_0
> ** the value is set correctly in the file pom.xml
> ** the tagging of the CVS module is also correct.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (MRELEASE-389) Properties
releaseVersion and developmentVersion are not read correctly during
release:prepare (eventually release:perform)
Posted by "Ringo De Smet (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRELEASE-389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=156707#action_156707 ]
Ringo De Smet edited comment on MRELEASE-389 at 12/4/08 2:07 AM:
-----------------------------------------------------------------
I did not use batch mode.
However, looking at the source, I do not understand where the *command-line* properties are pushed towards a ReleaseDescriptor object besides the method ReleaseUtils.copyPropertiesToReleaseDescriptor(Properties).
With Maven 2.0.9 and maven-release-plugin:2.0-beta-8, I have never been able to have the command-line properties to be pushed through. If I configured the properties in the configuration section of the plugin under build>plugins>plugin in the POM, it works as expected. Via that path, the properties are set through the Plexus container on another ReleaseDescriptor object populated in PrepareReleaseMojo.execute()
Should there be another piece of code that transforms command line arguments to properties accessible to the Plexus container?
Ringo
was (Author: ringods):
I did not use batch mode.
However, looking at the source, I do not understand where the the *command-line* properties are pushed towards a ReleaseDescriptor object besides the method ReleaseUtils.copyPropertiesToReleaseDescriptor(Properties).
With Maven 2.0.9 and maven-release-plugin:2.0-beta-8, I have never been able to have the command-line properties to be pushed through. If I configured the properties in the configuration section of the plugin under build>plugins>plugin in the POM, it works as expected. Via that path, the properties are set through the Plexus container on another ReleaseDescriptor object populated in PrepareReleaseMojo.execute()
Should there be another piece of code that transforms command line arguments to properties accessible to the Plexus container?
Ringo
> Properties releaseVersion and developmentVersion are not read correctly during release:prepare (eventually release:perform)
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: MRELEASE-389
> URL: http://jira.codehaus.org/browse/MRELEASE-389
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Affects Versions: 2.0-beta-8
> Environment: Maven version: 2.0.9
> Java version: 1.6.0_07
> OS name: "windows xp" version: "5.1" arch: "x86" Family: "windows"
> scm=CVS
> Reporter: jcrouvi
> Fix For: 2.0-beta-9
>
> Attachments: Patch-MRELEASE-389.txt
>
>
> Calling
> mvn --batch-mode release:prepare release:perform -Dtag=TEST_RELEASE-3_0_0 -DreleaseVersion=3.0.0 -DdevelopmentVersion=3.0.1-SNAPSHOT
> doesn't produce the expected results:
> * -DdevelopmentVersion=3.0.1-SNAPSHOT
> ** the value is not set correctly in the file pom.xml:
> *** Expected: <version>3.0.1-SNAPSHOT</version>
> *** But was: <version>2.0.5-SNAPSHOT</version>
> * -DreleaseVersion=3.0.0
> ** the artifacts are not created correctly:
> *** Expected artifact: ipi-multimodule-b-3.0.0.jar
> *** But was: ipi-multimodule-b-2.0.4.jar
> ** the value is not set correctly in the file pom.xml (comment in CVS: [maven-release-plugin] prepare release TEST_RELEASE-3_0_0):
> *** Expected: <version>3.0.0</version>
> *** But was: <version>2.0.4</version>
> * -Dtag=TEST_RELEASE-3_0_0
> ** the value is set correctly in the file pom.xml
> ** the tagging of the CVS module is also correct.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MRELEASE-389) Properties releaseVersion and
developmentVersion are not read correctly during release:prepare
(eventually release:perform)
Posted by "Ringo De Smet (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRELEASE-389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=156707#action_156707 ]
Ringo De Smet commented on MRELEASE-389:
----------------------------------------
I did not use batch mode.
However, looking at the source, I do not understand where the the *command-line* properties are pushed towards a ReleaseDescriptor object besides the method ReleaseUtils.copyPropertiesToReleaseDescriptor(Properties).
With Maven 2.0.9 and maven-release-plugin:2.0-beta-8, I have never been able to have the command-line properties to be pushed through. If I configured the properties in the configuration section of the plugin under build>plugins>plugin in the POM, it works as expected. Via that path, the properties are set through the Plexus container on another ReleaseDescriptor object populated in PrepareReleaseMojo.execute()
Should there be another piece of code that transforms command line arguments to properties accessible to the Plexus container?
Ringo
> Properties releaseVersion and developmentVersion are not read correctly during release:prepare (eventually release:perform)
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: MRELEASE-389
> URL: http://jira.codehaus.org/browse/MRELEASE-389
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Affects Versions: 2.0-beta-8
> Environment: Maven version: 2.0.9
> Java version: 1.6.0_07
> OS name: "windows xp" version: "5.1" arch: "x86" Family: "windows"
> scm=CVS
> Reporter: jcrouvi
> Fix For: 2.0-beta-9
>
> Attachments: Patch-MRELEASE-389.txt
>
>
> Calling
> mvn --batch-mode release:prepare release:perform -Dtag=TEST_RELEASE-3_0_0 -DreleaseVersion=3.0.0 -DdevelopmentVersion=3.0.1-SNAPSHOT
> doesn't produce the expected results:
> * -DdevelopmentVersion=3.0.1-SNAPSHOT
> ** the value is not set correctly in the file pom.xml:
> *** Expected: <version>3.0.1-SNAPSHOT</version>
> *** But was: <version>2.0.5-SNAPSHOT</version>
> * -DreleaseVersion=3.0.0
> ** the artifacts are not created correctly:
> *** Expected artifact: ipi-multimodule-b-3.0.0.jar
> *** But was: ipi-multimodule-b-2.0.4.jar
> ** the value is not set correctly in the file pom.xml (comment in CVS: [maven-release-plugin] prepare release TEST_RELEASE-3_0_0):
> *** Expected: <version>3.0.0</version>
> *** But was: <version>2.0.4</version>
> * -Dtag=TEST_RELEASE-3_0_0
> ** the value is set correctly in the file pom.xml
> ** the tagging of the CVS module is also correct.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MRELEASE-389) Properties releaseVersion and
developmentVersion are not read correctly during release:prepare
(eventually release:perform)
Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRELEASE-389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olivier Lamy updated MRELEASE-389:
----------------------------------
Fix Version/s: (was: 2.0-beta-9)
2.0-beta-10
> Properties releaseVersion and developmentVersion are not read correctly during release:prepare (eventually release:perform)
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: MRELEASE-389
> URL: http://jira.codehaus.org/browse/MRELEASE-389
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Components: prepare
> Affects Versions: 2.0-beta-8
> Environment: Maven version: 2.0.9
> Java version: 1.6.0_07
> OS name: "windows xp" version: "5.1" arch: "x86" Family: "windows"
> scm=CVS
> Reporter: jcrouvi
> Fix For: 2.0-beta-10
>
> Attachments: jcrouvi_20081204_test.log, Patch-MRELEASE-389.txt
>
>
> Calling
> mvn --batch-mode release:prepare release:perform -Dtag=TEST_RELEASE-3_0_0 -DreleaseVersion=3.0.0 -DdevelopmentVersion=3.0.1-SNAPSHOT
> doesn't produce the expected results:
> * -DdevelopmentVersion=3.0.1-SNAPSHOT
> ** the value is not set correctly in the file pom.xml:
> *** Expected: <version>3.0.1-SNAPSHOT</version>
> *** But was: <version>2.0.5-SNAPSHOT</version>
> * -DreleaseVersion=3.0.0
> ** the artifacts are not created correctly:
> *** Expected artifact: ipi-multimodule-b-3.0.0.jar
> *** But was: ipi-multimodule-b-2.0.4.jar
> ** the value is not set correctly in the file pom.xml (comment in CVS: [maven-release-plugin] prepare release TEST_RELEASE-3_0_0):
> *** Expected: <version>3.0.0</version>
> *** But was: <version>2.0.4</version>
> * -Dtag=TEST_RELEASE-3_0_0
> ** the value is set correctly in the file pom.xml
> ** the tagging of the CVS module is also correct.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MRELEASE-389) Properties releaseVersion and
developmentVersion are not read correctly during release:prepare
(eventually release:perform)
Posted by "Paul Gier (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRELEASE-389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Gier closed MRELEASE-389.
------------------------------
Assignee: Paul Gier
Resolution: Cannot Reproduce
I'm closing this issue as "Cannot Reproduce" since I was not able to reproduce the problem and it seems to have gone away for the original submitter (jcrouvi).
> Properties releaseVersion and developmentVersion are not read correctly during release:prepare (eventually release:perform)
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: MRELEASE-389
> URL: http://jira.codehaus.org/browse/MRELEASE-389
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Components: prepare
> Affects Versions: 2.0-beta-8
> Environment: Maven version: 2.0.9
> Java version: 1.6.0_07
> OS name: "windows xp" version: "5.1" arch: "x86" Family: "windows"
> scm=CVS
> Reporter: jcrouvi
> Assignee: Paul Gier
> Fix For: 2.0-beta-10
>
> Attachments: jcrouvi_20081204_test.log, Patch-MRELEASE-389.txt
>
>
> Calling
> mvn --batch-mode release:prepare release:perform -Dtag=TEST_RELEASE-3_0_0 -DreleaseVersion=3.0.0 -DdevelopmentVersion=3.0.1-SNAPSHOT
> doesn't produce the expected results:
> * -DdevelopmentVersion=3.0.1-SNAPSHOT
> ** the value is not set correctly in the file pom.xml:
> *** Expected: <version>3.0.1-SNAPSHOT</version>
> *** But was: <version>2.0.5-SNAPSHOT</version>
> * -DreleaseVersion=3.0.0
> ** the artifacts are not created correctly:
> *** Expected artifact: ipi-multimodule-b-3.0.0.jar
> *** But was: ipi-multimodule-b-2.0.4.jar
> ** the value is not set correctly in the file pom.xml (comment in CVS: [maven-release-plugin] prepare release TEST_RELEASE-3_0_0):
> *** Expected: <version>3.0.0</version>
> *** But was: <version>2.0.4</version>
> * -Dtag=TEST_RELEASE-3_0_0
> ** the value is set correctly in the file pom.xml
> ** the tagging of the CVS module is also correct.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MRELEASE-389) Properties releaseVersion and
developmentVersion are not read correctly during release:prepare
(eventually release:perform)
Posted by "Paul Gier (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRELEASE-389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Gier updated MRELEASE-389:
-------------------------------
Fix Version/s: 2.0-beta-9
> Properties releaseVersion and developmentVersion are not read correctly during release:prepare (eventually release:perform)
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: MRELEASE-389
> URL: http://jira.codehaus.org/browse/MRELEASE-389
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Affects Versions: 2.0-beta-8
> Environment: Maven version: 2.0.9
> Java version: 1.6.0_07
> OS name: "windows xp" version: "5.1" arch: "x86" Family: "windows"
> scm=CVS
> Reporter: jcrouvi
> Fix For: 2.0-beta-9
>
> Attachments: Patch-MRELEASE-389.txt
>
>
> Calling
> mvn --batch-mode release:prepare release:perform -Dtag=TEST_RELEASE-3_0_0 -DreleaseVersion=3.0.0 -DdevelopmentVersion=3.0.1-SNAPSHOT
> doesn't produce the expected results:
> * -DdevelopmentVersion=3.0.1-SNAPSHOT
> ** the value is not set correctly in the file pom.xml:
> *** Expected: <version>3.0.1-SNAPSHOT</version>
> *** But was: <version>2.0.5-SNAPSHOT</version>
> * -DreleaseVersion=3.0.0
> ** the artifacts are not created correctly:
> *** Expected artifact: ipi-multimodule-b-3.0.0.jar
> *** But was: ipi-multimodule-b-2.0.4.jar
> ** the value is not set correctly in the file pom.xml (comment in CVS: [maven-release-plugin] prepare release TEST_RELEASE-3_0_0):
> *** Expected: <version>3.0.0</version>
> *** But was: <version>2.0.4</version>
> * -Dtag=TEST_RELEASE-3_0_0
> ** the value is set correctly in the file pom.xml
> ** the tagging of the CVS module is also correct.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MRELEASE-389) Properties releaseVersion and
developmentVersion are not read correctly during release:prepare
(eventually release:perform)
Posted by "James Roper (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRELEASE-389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=207009#action_207009 ]
James Roper commented on MRELEASE-389:
--------------------------------------
I had exactly the same problem, -Dtag was honoured, but -DreleaseVersion and -DdevelopmentVersion wasn't working. The problem was I was using an older maven release plugin version and didn't realise it. Upgrading to 2.0-beta-9 solved the problem.
> Properties releaseVersion and developmentVersion are not read correctly during release:prepare (eventually release:perform)
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: MRELEASE-389
> URL: http://jira.codehaus.org/browse/MRELEASE-389
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Components: prepare
> Affects Versions: 2.0-beta-8
> Environment: Maven version: 2.0.9
> Java version: 1.6.0_07
> OS name: "windows xp" version: "5.1" arch: "x86" Family: "windows"
> scm=CVS
> Reporter: jcrouvi
> Assignee: Paul Gier
> Fix For: 2.0
>
> Attachments: jcrouvi_20081204_test.log, Patch-MRELEASE-389.txt
>
>
> Calling
> mvn --batch-mode release:prepare release:perform -Dtag=TEST_RELEASE-3_0_0 -DreleaseVersion=3.0.0 -DdevelopmentVersion=3.0.1-SNAPSHOT
> doesn't produce the expected results:
> * -DdevelopmentVersion=3.0.1-SNAPSHOT
> ** the value is not set correctly in the file pom.xml:
> *** Expected: <version>3.0.1-SNAPSHOT</version>
> *** But was: <version>2.0.5-SNAPSHOT</version>
> * -DreleaseVersion=3.0.0
> ** the artifacts are not created correctly:
> *** Expected artifact: ipi-multimodule-b-3.0.0.jar
> *** But was: ipi-multimodule-b-2.0.4.jar
> ** the value is not set correctly in the file pom.xml (comment in CVS: [maven-release-plugin] prepare release TEST_RELEASE-3_0_0):
> *** Expected: <version>3.0.0</version>
> *** But was: <version>2.0.4</version>
> * -Dtag=TEST_RELEASE-3_0_0
> ** the value is set correctly in the file pom.xml
> ** the tagging of the CVS module is also correct.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira