[GitHub] [beam] riteshghorse commented on a diff in pull request #25634: Fix most Go SDK compile and bugs on Windows.

["riteshghorse (via GitHub)" <gi...@apache.org>]

riteshghorse commented on code in PR #25634:
URL: https://github.com/apache/beam/pull/25634#discussion_r1131147159


##########
sdks/go/test/integration/internal/jars/run_nonunix.go:
##########
@@ -29,7 +30,7 @@ import (
 // non-unix version does not handle timeout durations.
 func getTimeoutRunner() runCallback {
 	// Wrap run with error handling for OS that does not support timeout duration.
-	return func(dur time.Duration, jar string, args ...string) (*Process, error) {
+	return func(dur time.Duration, jar string, args ...string) (Process, error) {

Review Comment:
   Curious if this change was necessary?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org