[jira] [Commented] (SAMZA-1183) Fix TestAsyncRunLoop flaky tests

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SAMZA-1183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15954195#comment-15954195 ] 

ASF GitHub Bot commented on SAMZA-1183:
---------------------------------------

GitHub user shanthoosh opened a pull request:

    https://github.com/apache/samza/pull/108

    SAMZA-1183: Fix async run loop tests

    Changes
    * Moved all states locally within the test methods(no global state, since tests can be run parallely).
    * Increased the timeout waiting for all task threads to finish.
    * Changed message chooser mock to return null at the end(When EOS message is used a final msg, during some runs task.process gets invoked more than once for it. This is due to test setup, other tests within this test class also do the same.)
    
    How was it verified: 
    
    Ran the test class repeatedly to check for failures(there were none).
    
    `
    while [ $i -lt 30 ] do     sleep 3;     i=`expr $i + 1`;     ./gradlew :samza-core:clean :samza-core:test -Dtest.single=TestAsyncRunLoop  done
    `
    
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shanthoosh/samza fix-async-run-loop-tests-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/samza/pull/108.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #108
    
----
commit 2505a9d5ddff3bed441319d9a122c25cd4e8f2f8
Author: Shanthoosh Venkataraman <sv...@linkedin.com>
Date:   2017-04-03T21:11:10Z

    SAMZA-1183: Fixing async run loop non blocking commit tests.
    
    Changes
    * Moved all states within the tests(no global state, since tests can be run parallely).
    * Increased the timeout waiting for all task threads to finish.
    * Changed message chooser mock to return null at the end(Sometimes when EOS message is used a final msg,
    task.process gets invoked more than once for it.)

----


> Fix TestAsyncRunLoop flaky tests
> --------------------------------
>
>                 Key: SAMZA-1183
>                 URL: https://issues.apache.org/jira/browse/SAMZA-1183
>             Project: Samza
>          Issue Type: Bug
>            Reporter: Shanthoosh Venkataraman
>            Assignee: Shanthoosh Venkataraman
>            Priority: Minor
>
> Due to sequence of ordering and timeout related problems in task threads created in TestAsyncRunLoop, the following tests were failing intermittently. 
> * testCommitBehaviourWhenAsyncCommitIsEnabled
> * testProcessBehaviourWhenAsyncCommitIsEnabled    
> This will track the PR and the effort associated with the change.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)