You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/02/26 22:29:31 UTC
[GitHub] [geode] bschuchardt commented on a change in pull request #5970: GEODE-8877: Configurable membership bind address
bschuchardt commented on a change in pull request #5970:
URL: https://github.com/apache/geode/pull/5970#discussion_r583950359
##########
File path: geode-core/src/main/java/org/apache/geode/distributed/internal/direct/DirectChannel.java
##########
@@ -142,7 +143,23 @@ public DirectChannel(Membership<InternalDistributedMember> mgr,
props.setProperty("membership_port_range_start", "" + range[0]);
props.setProperty("membership_port_range_end", "" + range[1]);
- this.conduit = new TCPConduit(mgr, port, address, isBindAddress, this, bufferPool, props);
+ InetAddress conduitAddress = address;
+ if (!dc.getMembershipBindAddress().isEmpty()) {
+ try {
+ if (dc.getMembershipBindAddress().equals("*")) {
Review comment:
Should "*" be the DEFAULT_MEMBERSHIP_BIND_ADDRESS?
Whether or not that's true, I think this special value for the setting should be described in ConfigurationProperties.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org