[GitHub] [superset] ktmud commented on a change in pull request #13225: fix: missing key on welcome page

[GitBox <gi...@apache.org>]

ktmud commented on a change in pull request #13225:
URL: https://github.com/apache/superset/pull/13225#discussion_r579774509



##########
File path: superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx
##########
@@ -17,31 +17,16 @@
  * under the License.
  */
 import React from 'react';
-import moment from 'moment';
+
 import { styled, t } from '@superset-ui/core';
 
 import Loading from 'src/components/Loading';
-import ListViewCard from 'src/components/ListViewCard';
 import SubMenu from 'src/components/Menu/SubMenu';
+import ActivityTableRow from './ActivityTableRow';
 import { ActivityData } from './Welcome';
-import { mq, CardStyles } from '../utils';
+import { mq } from '../utils';

Review comment:
       We prefer absolute import path.
   
   ```suggestion
   import { mq } from 'src/views/CURD/utils';
   ```

##########
File path: superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx
##########
@@ -178,7 +115,13 @@ export default function ActivityTable({
       />
       <>
         {activityData[activeChild]?.length > 0 ? (
-          <ActivityContainer>{renderActivity()}</ActivityContainer>
+          <ActivityContainer>
+            <ActivityTableRow

Review comment:
       `TableRow` sounds like a row of a table, but it actually contains the whole table content for a selected tab. We should probably rename other `XxxTable` to simply `Recents`,  `Dashboards`, `Charts` and `SavedQueries` to be consistent with section titles, then the single table content can be named as `RecentsList`, `DashboardList`, etc.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org