You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildr.apache.org by "Ittay Dror (JIRA)" <ji...@apache.org> on 2008/10/26 17:44:44 UTC

[jira] Created: (BUILDR-190) make it easy to exclude java source files from compilation

make it easy to exclude java source files from compilation
----------------------------------------------------------

                 Key: BUILDR-190
                 URL: https://issues.apache.org/jira/browse/BUILDR-190
             Project: Buildr
          Issue Type: Bug
    Affects Versions: 1.3.2
            Reporter: Ittay Dror
             Fix For: 1.3.4


I have cases where there are source files that should not be compiled (and yet it is desired to keep them in scm). 

i can use FileList inside the project definition (assign to compile.sources), but then it means the files are scanned during the definition phase (where afterwards this project's build may not be invoked)

it would be nice if compile.sources could be a proc (or contain proc) that is evaluated only before compilation

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (BUILDR-190) make it easy to exclude java source files from compilation

Posted by "Ittay Dror (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BUILDR-190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ittay Dror reopened BUILDR-190:
-------------------------------


actually, sources are resolved in several places:
def from(*sources)
      @sources |= sources.flatten
      guess_compiler if @compiler.nil? && sources.flatten.any? { |source| File.exist?(source) }
      self
end
in the second line sources.flatten resolves the FileList

and since #from is called when 'compile' is called:
def compile(*sources, &block)
      task('compile').from(sources).enhance &block
end

it is very easily resolved. in particular, after_define resolves it.

finally, since @sources is converted to Array in invoke_prerequisites, it is hard to create prerequisite tasks that set sources using  a FileList

(fwiw, i track when FileList is resolved by adding a fail in FileList#resolve and running buildr with a non-existent task)


> make it easy to exclude java source files from compilation
> ----------------------------------------------------------
>
>                 Key: BUILDR-190
>                 URL: https://issues.apache.org/jira/browse/BUILDR-190
>             Project: Buildr
>          Issue Type: Wish
>    Affects Versions: 1.3.2
>            Reporter: Ittay Dror
>             Fix For: 1.3.4
>
>
> I have cases where there are source files that should not be compiled (and yet it is desired to keep them in scm). 
> i can use FileList inside the project definition (assign to compile.sources), but then it means the files are scanned during the definition phase (where afterwards this project's build may not be invoked)
> it would be nice if compile.sources could be a proc (or contain proc) that is evaluated only before compilation

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (BUILDR-190) make it easy / efficient to include / exclude source patterns from compilation

Posted by "Ittay Dror (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BUILDR-190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ittay Dror updated BUILDR-190:
------------------------------

    Summary: make it easy / efficient to include / exclude source patterns from compilation  (was: make it easy to exclude java source files from compilation)

> make it easy / efficient to include / exclude source patterns from compilation
> ------------------------------------------------------------------------------
>
>                 Key: BUILDR-190
>                 URL: https://issues.apache.org/jira/browse/BUILDR-190
>             Project: Buildr
>          Issue Type: Wish
>    Affects Versions: 1.3.2
>            Reporter: Ittay Dror
>             Fix For: 1.3.4
>
>
> I have cases where there are source files that should not be compiled (and yet it is desired to keep them in scm). 
> i can use FileList inside the project definition (assign to compile.sources), but then it means the files are scanned during the definition phase (where afterwards this project's build may not be invoked)
> it would be nice if compile.sources could be a proc (or contain proc) that is evaluated only before compilation

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (BUILDR-190) make it easy to exclude java source files from compilation

Posted by "Assaf Arkin (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BUILDR-190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12643058#action_12643058 ] 

Assaf Arkin commented on BUILDR-190:
------------------------------------

compile.sources is a FileList so you can do:

  compile.sources.exclude '**/*'

> make it easy to exclude java source files from compilation
> ----------------------------------------------------------
>
>                 Key: BUILDR-190
>                 URL: https://issues.apache.org/jira/browse/BUILDR-190
>             Project: Buildr
>          Issue Type: Wish
>    Affects Versions: 1.3.2
>            Reporter: Ittay Dror
>             Fix For: 1.3.4
>
>
> I have cases where there are source files that should not be compiled (and yet it is desired to keep them in scm). 
> i can use FileList inside the project definition (assign to compile.sources), but then it means the files are scanned during the definition phase (where afterwards this project's build may not be invoked)
> it would be nice if compile.sources could be a proc (or contain proc) that is evaluated only before compilation

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (BUILDR-190) make it easy to exclude java source files from compilation

Posted by "Ittay Dror (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BUILDR-190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ittay Dror updated BUILDR-190:
------------------------------

    Issue Type: Wish  (was: Bug)

> make it easy to exclude java source files from compilation
> ----------------------------------------------------------
>
>                 Key: BUILDR-190
>                 URL: https://issues.apache.org/jira/browse/BUILDR-190
>             Project: Buildr
>          Issue Type: Wish
>    Affects Versions: 1.3.2
>            Reporter: Ittay Dror
>             Fix For: 1.3.4
>
>
> I have cases where there are source files that should not be compiled (and yet it is desired to keep them in scm). 
> i can use FileList inside the project definition (assign to compile.sources), but then it means the files are scanned during the definition phase (where afterwards this project's build may not be invoked)
> it would be nice if compile.sources could be a proc (or contain proc) that is evaluated only before compilation

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (BUILDR-190) make it easy / efficient to include / exclude source patterns from compilation

Posted by "Ittay Dror (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BUILDR-190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12643318#action_12643318 ] 

Ittay Dror commented on BUILDR-190:
-----------------------------------

also, about the first comment:
since sources is set to <base_dir>/src/main/java, adding exclude patterns does not change anything

> make it easy / efficient to include / exclude source patterns from compilation
> ------------------------------------------------------------------------------
>
>                 Key: BUILDR-190
>                 URL: https://issues.apache.org/jira/browse/BUILDR-190
>             Project: Buildr
>          Issue Type: Wish
>    Affects Versions: 1.3.2
>            Reporter: Ittay Dror
>             Fix For: 1.3.4
>
>
> I have cases where there are source files that should not be compiled (and yet it is desired to keep them in scm). 
> i can use FileList inside the project definition (assign to compile.sources), but then it means the files are scanned during the definition phase (where afterwards this project's build may not be invoked)
> it would be nice if compile.sources could be a proc (or contain proc) that is evaluated only before compilation

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (BUILDR-190) make it easy / efficient to include / exclude source patterns from compilation

Posted by "Assaf Arkin (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BUILDR-190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645561#action_12645561 ] 

Assaf Arkin commented on BUILDR-190:
------------------------------------

Proper include/exclude out of scope for now, but you can do this:

  compile.sources.clear

I'm adding a spec for that.

> make it easy / efficient to include / exclude source patterns from compilation
> ------------------------------------------------------------------------------
>
>                 Key: BUILDR-190
>                 URL: https://issues.apache.org/jira/browse/BUILDR-190
>             Project: Buildr
>          Issue Type: Wish
>    Affects Versions: 1.3.2
>            Reporter: Ittay Dror
>             Fix For: 1.3.4
>
>
> I have cases where there are source files that should not be compiled (and yet it is desired to keep them in scm). 
> i can use FileList inside the project definition (assign to compile.sources), but then it means the files are scanned during the definition phase (where afterwards this project's build may not be invoked)
> it would be nice if compile.sources could be a proc (or contain proc) that is evaluated only before compilation

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (BUILDR-190) make it easy / efficient to include / exclude source patterns from compilation

Posted by "Assaf Arkin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BUILDR-190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Assaf Arkin updated BUILDR-190:
-------------------------------

    Fix Version/s:     (was: 1.3.4)

> make it easy / efficient to include / exclude source patterns from compilation
> ------------------------------------------------------------------------------
>
>                 Key: BUILDR-190
>                 URL: https://issues.apache.org/jira/browse/BUILDR-190
>             Project: Buildr
>          Issue Type: Wish
>    Affects Versions: 1.3.2
>            Reporter: Ittay Dror
>
> I have cases where there are source files that should not be compiled (and yet it is desired to keep them in scm). 
> i can use FileList inside the project definition (assign to compile.sources), but then it means the files are scanned during the definition phase (where afterwards this project's build may not be invoked)
> it would be nice if compile.sources could be a proc (or contain proc) that is evaluated only before compilation

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (BUILDR-190) make it easy to exclude java source files from compilation

Posted by "Ittay Dror (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BUILDR-190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ittay Dror closed BUILDR-190.
-----------------------------

    Resolution: Invalid

> make it easy to exclude java source files from compilation
> ----------------------------------------------------------
>
>                 Key: BUILDR-190
>                 URL: https://issues.apache.org/jira/browse/BUILDR-190
>             Project: Buildr
>          Issue Type: Wish
>    Affects Versions: 1.3.2
>            Reporter: Ittay Dror
>             Fix For: 1.3.4
>
>
> I have cases where there are source files that should not be compiled (and yet it is desired to keep them in scm). 
> i can use FileList inside the project definition (assign to compile.sources), but then it means the files are scanned during the definition phase (where afterwards this project's build may not be invoked)
> it would be nice if compile.sources could be a proc (or contain proc) that is evaluated only before compilation

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.