[GitHub] [beam] EDjur commented on a change in pull request #11040: [BEAM-9305] Allow value provider query strings in _CustomBigQuerySource

[GitBox <gi...@apache.org>]

EDjur commented on a change in pull request #11040: [BEAM-9305] Allow value provider query strings in _CustomBigQuerySource
URL: https://github.com/apache/beam/pull/11040#discussion_r389532725
 
 

 ##########
 File path: sdks/python/apache_beam/io/gcp/bigquery_read_it_test.py
 ##########
 @@ -156,12 +157,19 @@ def test_native_source(self):
 
   @attr('IT')
   def test_iobase_source(self):
+    query = StaticValueProvider(str, self.query)
     with beam.Pipeline(argv=self.args) as p:
       result = (
           p | 'read' >> beam.io._ReadFromBigQuery(
               query=self.query, use_standard_sql=True, project=self.project))
       assert_that(result, equal_to(self.TABLE_DATA))
 
+    with beam.Pipeline(argv=self.args) as p:
 
 Review comment:
   To actually evaluate the value providers, the pipeline needs to be executed right? Cause these are realistically only 'known' at runtime. The tests in `TestReadFromBigQuery` just validate the input data to the initialisation.
   
   We can of course just validate that query is of type `ValueProvider` after initialising a pipeline, but I figured we want to check that the value provider query is actually evaluated to a string type on pipeline execution.
   
   Am I perhaps missing something?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services