You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Bartek Plotka <bw...@gmail.com> on 2015/06/03 00:06:28 UTC
Re: Review Request 34748: Defined protobuf for usage returned by
Resource Monitor. Reused ResourceUsage
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34748/
-----------------------------------------------------------
(Updated June 2, 2015, 10:06 p.m.)
Review request for mesos, Ben Mahler, Jie Yu, Joris Van Remoortere, Niklas Nielsen, Szymon Konefal, and Vinod Kone.
Summary (updated)
-----------------
Defined protobuf for usage returned by Resource Monitor. Reused ResourceUsage
Bugs: MESOS-2772
https://issues.apache.org/jira/browse/MESOS-2772
Repository: mesos
Description
-------
Changed ResourceMonitor to use ResourceUsage instead of ResourceMonitor::Usage.
Reused old ResoureUsage in message mesos.proto
NOTE: That is required for modules which need to fetch ResourceUsage e.g ResourceEstimator and QoSController.
Discussed that message ResourceUsage in mesos.proto is free to reuse and modify, since it's not used anywhere else.
Diffs (updated)
-----
include/mesos/mesos.proto 5cf81e20bc77288eb4c183722c608827b5000cb4
src/slave/monitor.hpp 48fe59faacf53f1015665b0867aefd08d5b29225
src/slave/monitor.cpp a5a52b116ec38535dcc23e720e8a3a1fbc73762e
Diff: https://reviews.apache.org/r/34748/diff/
Testing
-------
make check
Thanks,
Bartek Plotka
Re: Review Request 34748: Defined protobuf for usage returned by
Resource Monitor. Reused ResourceUsage
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34748/#review86297
-----------------------------------------------------------
Ship it!
Ship It!
- Niklas Nielsen
On June 2, 2015, 3:06 p.m., Bartek Plotka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34748/
> -----------------------------------------------------------
>
> (Updated June 2, 2015, 3:06 p.m.)
>
>
> Review request for mesos, Ben Mahler, Jie Yu, Joris Van Remoortere, Niklas Nielsen, Szymon Konefal, and Vinod Kone.
>
>
> Bugs: MESOS-2772
> https://issues.apache.org/jira/browse/MESOS-2772
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Changed ResourceMonitor to use ResourceUsage instead of ResourceMonitor::Usage.
> Reused old ResoureUsage in message mesos.proto
>
> NOTE: That is required for modules which need to fetch ResourceUsage e.g ResourceEstimator and QoSController.
> Discussed that message ResourceUsage in mesos.proto is free to reuse and modify, since it's not used anywhere else.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 5cf81e20bc77288eb4c183722c608827b5000cb4
> src/slave/monitor.hpp 48fe59faacf53f1015665b0867aefd08d5b29225
> src/slave/monitor.cpp a5a52b116ec38535dcc23e720e8a3a1fbc73762e
>
> Diff: https://reviews.apache.org/r/34748/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Bartek Plotka
>
>
Re: Review Request 34748: Defined protobuf for usage returned by
Resource Monitor. Reused ResourceUsage
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34748/#review86298
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On June 2, 2015, 10:06 p.m., Bartek Plotka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34748/
> -----------------------------------------------------------
>
> (Updated June 2, 2015, 10:06 p.m.)
>
>
> Review request for mesos, Ben Mahler, Jie Yu, Joris Van Remoortere, Niklas Nielsen, Szymon Konefal, and Vinod Kone.
>
>
> Bugs: MESOS-2772
> https://issues.apache.org/jira/browse/MESOS-2772
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Changed ResourceMonitor to use ResourceUsage instead of ResourceMonitor::Usage.
> Reused old ResoureUsage in message mesos.proto
>
> NOTE: That is required for modules which need to fetch ResourceUsage e.g ResourceEstimator and QoSController.
> Discussed that message ResourceUsage in mesos.proto is free to reuse and modify, since it's not used anywhere else.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 5cf81e20bc77288eb4c183722c608827b5000cb4
> src/slave/monitor.hpp 48fe59faacf53f1015665b0867aefd08d5b29225
> src/slave/monitor.cpp a5a52b116ec38535dcc23e720e8a3a1fbc73762e
>
> Diff: https://reviews.apache.org/r/34748/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Bartek Plotka
>
>